[geeklog-hg] [Geeklog-Core/geeklog] 090443: Numerous Bug Fixes for Comment System

[Tom]

  Branch: refs/heads/master
  Home:   https://github.com/Geeklog-Core/geeklog
  Commit: 09044313f9ab87e2411e0cb697069062375c783e
      https://github.com/Geeklog-Core/geeklog/commit/09044313f9ab87e2411e0cb697069062375c783e
  Author: eSilverStrike <eSilverStrike at users.noreply.github.com>
  Date:   2020-02-12 (Wed, 12 Feb 2020)

  Changed paths:
    M language/english.php
    M language/english_utf-8.php
    M language/japanese_utf-8.php
    M plugins/polls/functions.inc
    M plugins/spamx/MassDelete.Admin.class.php
    M plugins/staticpages/functions.inc
    M public_html/admin/comment.php
    M public_html/admin/moderation.php
    A public_html/layout/denim/comment/commentlogin.thtml
    A public_html/layout/denim_three/comment/commentlogin.thtml
    A public_html/layout/modern_curve/comment/commentlogin.thtml
    M system/lib-article.php
    M system/lib-comment.php
    M system/lib-plugins.php

  Log Message:
  -----------
  Numerous Bug Fixes for Comment System

In part for issue #1023 (security issues with comments and some cleanup) and #1034 (new functions to fix comment moderation and deleting existing comments)

Many changes to lib-comments.php (while trying to keep everything backwards compatible) including:

-	New commentlogin.thtml template file displayed when $_CONF[‘comment_on_same_page’] = true and $_CONF[‘commentsloginrequired’] = true
-	Fixes to PLG_commentDelete to allow Boolean to be returned so Admin Comments list could delete multiple comments at once. Old version of plugin_deletecomment_ foo will depreciate by Geeklog v3.0.0
-	Updated Articles, Staticpages, and Polls to support new version of PLG_commentDelete
-	Fixed Polls to display message when comment goes to submission queue
-	SPAM-X Mass Delete Comments will now delete more than one
-	Moderation Submission Queue for Comments updated to just use CMT_approveModeration which calls CMT_rebuildTree  and PLG_approveCommentSubmission (this is new) so plugins like articles can do some extra work
-	CMT_rebuildTree fixed to include type along with id
-	Fixed $_CONF[‘comment_edit’] so Anonymous users could not edit comments and regular users from editing any comments and not just their own for a certain time. Users also cannot delete their own comments
-	If fields missing on comment edit form and message is displayed about it to user, comment preview is included so anchor point still works for when comments on the same page
-	When Comment is previewed, edited, deleting or submitted extra security checks are done. If user is not supposed to be doing this due to lack of permissions or comment not exisit then 404 error happens. Also now check if user has read permissions on item comment is form
-	Fix for comment notifications when moving from commentsubmission table to comments table


  Commit: e3db44e7752eb38b7498806ad623c94510c0a423
      https://github.com/Geeklog-Core/geeklog/commit/e3db44e7752eb38b7498806ad623c94510c0a423
  Author: eSilverStrike <eSilverStrike at users.noreply.github.com>
  Date:   2020-02-12 (Wed, 12 Feb 2020)

  Changed paths:
    M system/classes/config.class.php

  Log Message:
  -----------
  Merge branch 'master' of https://github.com/Geeklog-Core/geeklog


Compare: https://github.com/Geeklog-Core/geeklog/compare/5e825df1f7b2...e3db44e7752e