[geeklog-modules] Returning entries for the Admin menu

[Tony Bibbs]

Actually, unless you object Dirk, maybe it would be easier just to give 
Tom CVS access.  I've seen enough of his code to feel comfortable with 
that if you do.

Tom, Dirk has a point on the version used.  One big problem was for a long 
time the CVS version didn't use the $_TABLES[] stuff which made for 
support problems (it has since been fixed).  I believe the CVS version is 
ready for your additions to be merged now if you want to do it.

Having these changes in will help tremendously, thanks for working 
together on this.

--Tony

On Mon, 30 Dec 2002, Dirk Haun wrote:

> Tom Willett <tomw at pigstye.net> wrote:
> 
> >Fine with me -- the two major functionallities that I see used are the 
> >ability to use php and being privs aware.
> 
> Yep, I really would like to see the permissions added to static pages.
> Personally, I don't need the PHP support, but since many people seem to
> ask for that, why not.
> 
> 
> >I am not sure the expanded search is ever used
> 
> I didn't even know there was such a thing in your version ;-)
> 
> 
> >Tell me what you would like for me to do along these lines and I will do 
> >it.  Or you can just raid the cvs and incorporate what you want.
> 
> My main concern is that there are some subtle differences between the two
> versions (or at least I assume there are). I don't remember the exact
> circumstances, but when Phill announced that he was going to extend the
> plugin to support PHP, I asked him to use not the version from the
> Geeklog version that was out back then, but use the version from CVS
> instead. Unfortunately, he didn't do that and at least his versions have
> always had some minor differences since then. Things like valid HTML and
> the ability to wrap static pages in a block.
> 
> That's what held me back from just grabbing the extended version and
> throwing it into CVS. I've always wanted to merge the two versions again
> but never found the time (and doubt that I will now).
> 
> So if you're into painstakingly comparing the two versions line by line
> to figure out what those differences are (if any), then please feel free
> to do so ;-) Looking at the CVS history of the files should give you an
> idea of what I'm talking about.
> 
> Then there's the issue of the install script. We need to extend Geeklog's
> install script to safely(!) upgrade from any version of the plugin that
> the user may have installed. I've come across reports where the upgrade
> process failed for the extended version and the plugin was reported as
> being "locked" because of that. Apparently, people had some problems
> recovering from that state. It must be avoided that this happens when
> people run Geeklog's install script.
> 
> To summarize: I want the permissions, I would accept the PHP support, and
> I don't care about the extended search. If you think you can provide us
> with a version that has these and still has the changes that were made in
> the original plugin, then please do that. We would happily accept such a
> version as the new official version and ship it with Geeklog.
> 
> Of course, I would be available for any help you would need with this
> (especially, I assume, with the install script).
> 
> bye, Dirk
> 
> 
>