From dracul01 at gmail.com Thu Aug 2 13:13:51 2007 From: dracul01 at gmail.com (Damien Hodgkin) Date: Thu, 2 Aug 2007 13:13:51 -0400 Subject: [geeklog-devel] Editor for Gl2 Content Plugin Message-ID: <200708021313.56165.dracul01@gmail.com> Ok, so I have been working really hard on the content plugin, I am now implementing the editor. As of right now it has a very basic xhtml editor. I am trying to figure out what would be best to use for a more advanced editor, like Gl1 uses FCKEditor. I want to know what everyone thinks. I've been eyeballing TinyMCE, as it is small and easy to integrate, just two lines of code. Now what I would like to know, from everyone is: 1. How does everyone feel about the current editor in Gl1? 2. If the editor were to change in Gl2 would it disappoint people? 3. If you were to replace the editor what would you use? 4. what if the content plugin used a add-in feature so a different editor could be added later on, replacing the "standard" or "default" editor that is put in place? Your help and guidance is greatly appreciated. -- Best Regards, Damien ------------- "I only have two braincells left, one is missing, and the other is putting up flyers!" -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part. URL: From vfuria at gmail.com Thu Aug 2 13:23:50 2007 From: vfuria at gmail.com (Vincent Furia) Date: Thu, 2 Aug 2007 11:23:50 -0600 Subject: [geeklog-devel] Editor for Gl2 Content Plugin In-Reply-To: <200708021313.56165.dracul01@gmail.com> References: <200708021313.56165.dracul01@gmail.com> Message-ID: <8319e2d60708021023g2053d4q91aad1d15979294b@mail.gmail.com> I think #4 is a really good idea and would eliminate the need to consider 1, 2, and 3. -Vinny On 8/2/07, Damien Hodgkin wrote: > Ok, so I have been working really hard on the content plugin, I am now > implementing the editor. As of right now it has a very basic xhtml editor. > I am trying to figure out what would be best to use for a more advanced > editor, like Gl1 uses FCKEditor. I want to know what everyone thinks. > I've been eyeballing TinyMCE, as it is small and easy to integrate, just two > lines of code. > > Now what I would like to know, from everyone is: > 1. How does everyone feel about the current editor in Gl1? > 2. If the editor were to change in Gl2 would it disappoint people? > 3. If you were to replace the editor what would you use? > 4. what if the content plugin used a add-in feature so a different editor > could be added later on, replacing the "standard" or "default" editor that is > put in place? > > Your help and guidance is greatly appreciated. > -- > Best Regards, > Damien > ------------- > "I only have two braincells left, one is missing, and the other is putting up > flyers!" > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > > From devel at portalparts.com Thu Aug 2 15:28:34 2007 From: devel at portalparts.com (Blaine Lang) Date: Thu, 02 Aug 2007 15:28:34 -0400 Subject: [geeklog-devel] Editor for Gl2 Content Plugin In-Reply-To: <200708021313.56165.dracul01@gmail.com> References: <200708021313.56165.dracul01@gmail.com> Message-ID: <46B23062.9080403@portalparts.com> Hi Damien, I spent a number of months trying various editors and watching their projects before settling on FCKeditor and implementing it for GL. I may be a bit biased but I've used it now for multiple other projects and have only had good experience including developing plugins for it like Mark Evans has recently. In just the past month YUI has released their editor as well Jack has released one for the JS EXT library this week. For a basic inline text editor or a full blown CMS solution, I still think FCKeditor is hard to beat. Fred is very active and we have contributed in the past to this project which he then replies personally with great support. If you choose option 4 - you may just have to develop extra JS libraries to initialize and possibly extend it like we have in GL 1.4 where you can switch modes online and flip to a basic textarea if you want. The FCKeditor API is pretty flexible as this shows. Cheers, Blaine Damien Hodgkin wrote: > Ok, so I have been working really hard on the content plugin, I am now > implementing the editor. As of right now it has a very basic xhtml editor. > I am trying to figure out what would be best to use for a more advanced > editor, like Gl1 uses FCKEditor. I want to know what everyone thinks. > I've been eyeballing TinyMCE, as it is small and easy to integrate, just two > lines of code. > > Now what I would like to know, from everyone is: > 1. How does everyone feel about the current editor in Gl1? > 2. If the editor were to change in Gl2 would it disappoint people? > 3. If you were to replace the editor what would you use? > 4. what if the content plugin used a add-in feature so a different editor > could be added later on, replacing the "standard" or "default" editor that is > put in place? > > Your help and guidance is greatly appreciated. > > ------------------------------------------------------------------------ > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > From dracul01 at gmail.com Thu Aug 2 15:40:09 2007 From: dracul01 at gmail.com (Damien Hodgkin) Date: Thu, 2 Aug 2007 15:40:09 -0400 Subject: [geeklog-devel] Editor for Gl2 Content Plugin In-Reply-To: <46B23062.9080403@portalparts.com> References: <200708021313.56165.dracul01@gmail.com> <46B23062.9080403@portalparts.com> Message-ID: <200708021540.12885.dracul01@gmail.com> Obviously I want to try to go the easiest route possible. Of course if I end up getting an overwhelming amount of "FCKEditor is the way to go" then I am going to implement it. I am going to start playing around with FCKEditor tomorrow and do a personal analysis of the pros and cons of both it and TinyMCE. I will most likely post a comparison of the two editors on my blog. -- Best Regards, Damien ------------- "I only have two braincells left, one is missing, and the other is putting up flyers!" On Thursday 02 August 2007 3:28:34 pm you wrote: > Hi Damien, > > I spent a number of months trying various editors and watching their > projects before settling on FCKeditor and implementing it for GL. I may > be a bit biased but I've used it now for multiple other projects and > have only had good experience including developing plugins for it like > Mark Evans has recently. > > In just the past month YUI has released their editor as well Jack has > released one for the JS EXT library this week. For a basic inline text > editor or a full blown CMS solution, I still think FCKeditor is hard to > beat. Fred is very active and we have contributed in the past to this > project which he then replies personally with great support. > > If you choose option 4 - you may just have to develop extra JS libraries > to initialize and possibly extend it like we have in GL 1.4 where you > can switch modes online and flip to a basic textarea if you want. The > FCKeditor API is pretty flexible as this shows. > > Cheers, > Blaine > > Damien Hodgkin wrote: > > Ok, so I have been working really hard on the content plugin, I am now > > implementing the editor. As of right now it has a very basic xhtml > > editor. I am trying to figure out what would be best to use for a more > > advanced editor, like Gl1 uses FCKEditor. I want to know what everyone > > thinks. I've been eyeballing TinyMCE, as it is small and easy to > > integrate, just two lines of code. > > > > Now what I would like to know, from everyone is: > > 1. How does everyone feel about the current editor in Gl1? > > 2. If the editor were to change in Gl2 would it disappoint people? > > 3. If you were to replace the editor what would you use? > > 4. what if the content plugin used a add-in feature so a different editor > > could be added later on, replacing the "standard" or "default" editor > > that is put in place? > > > > Your help and guidance is greatly appreciated. > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > geeklog-devel mailing list > > geeklog-devel at lists.geeklog.net > > http://eight.pairlist.net/mailman/listinfo/geeklog-devel -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part. URL: From tony at tonybibbs.com Fri Aug 3 10:53:50 2007 From: tony at tonybibbs.com (Tony Bibbs) Date: Fri, 3 Aug 2007 07:53:50 -0700 (PDT) Subject: [geeklog-devel] Editor for Gl2 Content Plugin Message-ID: <550386.19392.qm@web701.biz.mail.mud.yahoo.com> I know one of Damien's issues with FCKEditor is that it's a bit "big" hence the TinyMCE suggestion. In my opinion most sane browsers cache JS so I'm not terribly concerned. Like Vinny said, I think it would make a ton of sense to make the editor configurable by providing a simple API each editor would implement for the various hooks. On the backside of all this is the issue of input filtering. I'd be curious if anybody has used the built-in filtering stuff recently introduced into PHP. FWIW, Damien's done a great job and we may be able to do a first alpha release at the end of the GSoC period. --Tony ----- Original Message ---- From: Damien Hodgkin To: Blaine Lang Cc: Geeklog Development Sent: Thursday, August 2, 2007 2:40:09 PM Subject: Re: [geeklog-devel] Editor for Gl2 Content Plugin Obviously I want to try to go the easiest route possible. Of course if I end up getting an overwhelming amount of "FCKEditor is the way to go" then I am going to implement it. I am going to start playing around with FCKEditor tomorrow and do a personal analysis of the pros and cons of both it and TinyMCE. I will most likely post a comparison of the two editors on my blog. -- Best Regards, Damien ------------- "I only have two braincells left, one is missing, and the other is putting up flyers!" On Thursday 02 August 2007 3:28:34 pm you wrote: > Hi Damien, > > I spent a number of months trying various editors and watching their > projects before settling on FCKeditor and implementing it for GL. I may > be a bit biased but I've used it now for multiple other projects and > have only had good experience including developing plugins for it like > Mark Evans has recently. > > In just the past month YUI has released their editor as well Jack has > released one for the JS EXT library this week. For a basic inline text > editor or a full blown CMS solution, I still think FCKeditor is hard to > beat. Fred is very active and we have contributed in the past to this > project which he then replies personally with great support. > > If you choose option 4 - you may just have to develop extra JS libraries > to initialize and possibly extend it like we have in GL 1.4 where you > can switch modes online and flip to a basic textarea if you want. The > FCKeditor API is pretty flexible as this shows. > > Cheers, > Blaine > > Damien Hodgkin wrote: > > Ok, so I have been working really hard on the content plugin, I am now > > implementing the editor. As of right now it has a very basic xhtml > > editor. I am trying to figure out what would be best to use for a more > > advanced editor, like Gl1 uses FCKEditor. I want to know what everyone > > thinks. I've been eyeballing TinyMCE, as it is small and easy to > > integrate, just two lines of code. > > > > Now what I would like to know, from everyone is: > > 1. How does everyone feel about the current editor in Gl1? > > 2. If the editor were to change in Gl2 would it disappoint people? > > 3. If you were to replace the editor what would you use? > > 4. what if the content plugin used a add-in feature so a different editor > > could be added later on, replacing the "standard" or "default" editor > > that is put in place? > > > > Your help and guidance is greatly appreciated. > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > geeklog-devel mailing list > > geeklog-devel at lists.geeklog.net > > http://eight.pairlist.net/mailman/listinfo/geeklog-devel From oliver at spiesshofer.com Sun Aug 5 06:28:36 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Sun, 05 Aug 2007 18:28:36 +0800 Subject: [geeklog-devel] Viewing Diffs in email Message-ID: <46B5A654.4090000@spiesshofer.com> Hi all, just in case you are interested: This add-on for Thunderbird colors the DIFF-reports from the CVS reports in your inbox: https://addons.mozilla.org/en-US/thunderbird/addon/4268 Oliver From info at heatherengineering.com Mon Aug 6 21:17:43 2007 From: info at heatherengineering.com (Heather Engineering) Date: Tue, 7 Aug 2007 10:17:43 +0900 Subject: [geeklog-devel] Fwd: locales References: <92C97D95-A178-44E3-9D41-9FC83E0DC5BF@heatherengineering.com> Message-ID: I posted this a while ago but there was no reaction. I wonder if anyone thinks this is a good idea? Any comments? I'm working on a site for a client that needs to set content according to locale. For now, I just added the $LANG_LOCALE string to each language file. Another alternative might be that the multilanguage array setting in config.php could be changed to use locale, not just language, as the array key: $_CONF['language_files'] = array ( 'en' => 'english_utf-8', 'ja' => 'japanese_utf-8' ); change to $_CONF['language_files'] = array ( 'en_GB' => 'english_utf-8', 'ja_JP' => 'japanese_utf-8' ); I think that once you start working with several languages you come to realise the importance of having locale settings available. I think this is a necessary modification. Cheers, Euan. Begin forwarded message: > From: Heather Engineering > Date: 2007?6?15? 0:10:51:JST > To: Geeklog Development > Subject: locales > > I'd like to request that the locale is added to each language file > next to the charset next time translations are updated: > > $LANG_CHARSET = 'utf-8'; > $LANG_LOCALE = 'en_GB'; > > unless there is some other way of working out the locale that I'm > missing? I know I could do it from the filename, but that seems a > little long winded to me and I think that the locale should be > available. The following array might also be useful if added to the > language files. > > For good measure, I've added an array of countries in English in > case anyone wants. This would also be useful in the language files. > > Euan. > > ? > > // partial list of locales > > $LANG_LOCALES = array ( > 'af_ZA' => 'Afrikaans (South Africa)', > 'ca_ES' => 'Catalan (Spain)', > 'cs_CZ' => 'Czech (Czech Republic)', > 'da_DK' => 'Danish (Denmark)', > 'de_CH' => 'German (Switzerland)', > 'de_DE' => 'German (Germany)', > 'el_GR' => 'Greek (Greece)', > 'en_GB' => 'English (UK)', > 'en_US' => 'English (USA)', > 'es_ES' => 'Spanish (Spain)', > 'fi_FI' => 'Finnish (Finland)', > 'fr_BE' => 'French (Belgium)', > 'fr_CA' => 'French (Canada)', > 'fr_CH' => 'French (Switzerland)', > 'fr_FR' => 'French (France)', > 'he_IL' => 'Hebrew (Israel)', > 'hu_HU' => 'Hungarian (Hungary)', > 'is_IS' => 'Islandic (Iceland)', > 'it_IT' => 'Italian (Italy)', > 'ja_JP' => 'Japanese (Japan)', > 'ko_KR' => 'Korean (Korea)', > 'lt_LT' => 'Lithuanian (Lithuania)', > 'nl_NL' => 'Dutch (the Netherlands)', > 'no_NO' => 'Norwegian (Norway)', > 'pl_PL' => 'Polish (Poland)', > 'pt_PT' => 'Portuguese (Portugal)', > 'ru_RU' => 'Russian (Russia)', > 'sk_SK' => 'Slovak (Slovakia)', > 'sl_SI' => 'Slovenian (Slovenia)', > 'sv_SE' => 'Swedish (Sweden)', > 'th_TH' => 'Thai (Thailand)', > 'tr_TR' => 'Turkish (Turkey)', > 'zh_CN' => 'Chinese (Simplified)', > 'zh_HK' => 'Chinese (Hong Kong)', > 'zh_TW' => 'Chinese (Traditional, Taiwan)' > ); > > // complete list of countries > > $LANG_COUNTRIES = array ( > 'af' => 'Afghanistan', > 'al' => 'Albania', > 'dz' => 'Algeria', > 'as' => 'American Samoa', > 'ad' => 'Andorra', > 'ao' => 'Angola', > 'ai' => 'Anguilla', > 'aq' => 'Antarctica', > 'ag' => 'Antigua and Barbuda', > 'ar' => 'Argentina', > 'am' => 'Armenia', > 'aw' => 'Aruba', > 'au' => 'Australia', > 'at' => 'Austria', > 'az' => 'Azerbaidjan', > 'bs' => 'Bahamas', > 'bh' => 'Bahrain', > 'bd' => 'Bangladesh', > 'bb' => 'Barbados', > 'by' => 'Belarus', > 'be' => 'Belgium', > 'bz' => 'Belize', > 'bj' => 'Benin', > 'bm' => 'Bermuda', > 'bt' => 'Bhutan', > 'bo' => 'Bolivia', > 'ba' => 'Bosnia-Herzegovina', > 'bw' => 'Botswana', > 'bv' => 'Bouvet Island', > 'br' => 'Brazil', > 'io' => 'British Indian Ocean Territory', > 'bn' => 'Brunei Darussalam', > 'bg' => 'Bulgaria', > 'bf' => 'Burkina Faso', > 'bi' => 'Burundi', > 'kh' => 'Cambodia', > 'cm' => 'Cameroon', > 'ca' => 'Canada', > 'cv' => 'Cape Verde', > 'ky' => 'Cayman Islands', > 'cf' => 'Central African Republic', > 'td' => 'Chad', > 'cl' => 'Chile', > 'cn' => 'China', > 'cx' => 'Christmas Island', > 'cc' => 'Cocos (Keeling) Islands', > 'co' => 'Colombia', > 'km' => 'Comoros', > 'cg' => 'Congo', > 'ck' => 'Cook Islands', > 'cr' => 'Costa Rica', > 'hr' => 'Croatia', > 'cu' => 'Cuba', > 'cy' => 'Cyprus', > 'cz' => 'Czech Republic', > 'dk' => 'Denmark', > 'dj' => 'Djibouti', > 'dm' => 'Dominica', > 'do' => 'Dominican Republic', > 'tp' => 'East Timor', > 'ec' => 'Ecuador', > 'eg' => 'Egypt', > 'sv' => 'El Salvador', > 'gq' => 'Equatorial Guinea', > 'er' => 'Eritrea', > 'ee' => 'Estonia', > 'et' => 'Ethiopia', > 'fk' => 'Falkland Islands', > 'fo' => 'Faroe Islands', > 'fj' => 'Fiji', > 'fi' => 'Finland', > 'cs' => 'Former Czechoslovakia', > 'su' => 'Former USSR', > 'fr' => 'France', > 'fx' => 'France (European Territory)', > 'gf' => 'French Guyana', > 'tf' => 'French Southern Territories', > 'ga' => 'Gabon', > 'gm' => 'Gambia', > 'ge' => 'Georgia', > 'de' => 'Germany', > 'gh' => 'Ghana', > 'gi' => 'Gibraltar', > 'gb' => 'Great Britain', > 'gr' => 'Greece', > 'gl' => 'Greenland', > 'gd' => 'Grenada', > 'gp' => 'Guadeloupe (French)', > 'gu' => 'Guam (USA)', > 'gt' => 'Guatemala', > 'gn' => 'Guinea', > 'gw' => 'Guinea Bissau', > 'gy' => 'Guyana', > 'ht' => 'Haiti', > 'hm' => 'Heard and McDonald Islands', > 'hn' => 'Honduras', > 'hk' => 'Hong Kong', > 'hu' => 'Hungary', > 'is' => 'Iceland', > 'in' => 'India', > 'id' => 'Indonesia', > 'ir' => 'Iran', > 'iq' => 'Iraq', > 'ie' => 'Ireland', > 'il' => 'Israel', > 'it' => 'Italy', > 'ci' => 'Ivory Coast (Cote D\'Ivoire)', > 'jm' => 'Jamaica', > 'jp' => 'Japan', > 'jo' => 'Jordan', > 'kz' => 'Kazakhstan', > 'ke' => 'Kenya', > 'ki' => 'Kiribati', > 'kw' => 'Kuwait', > 'kg' => 'Kyrgyzstan', > 'la' => 'Laos', > 'lv' => 'Latvia', > 'lb' => 'Lebanon', > 'ls' => 'Lesotho', > 'lr' => 'Liberia', > 'ly' => 'Libya', > 'li' => 'Liechtenstein', > 'lt' => 'Lithuania', > 'lu' => 'Luxembourg', > 'mo' => 'Macau', > 'mk' => 'Macedonia', > 'mg' => 'Madagascar', > 'mw' => 'Malawi', > 'my' => 'Malaysia', > 'mv' => 'Maldives', > 'ml' => 'Mali', > 'mt' => 'Malta', > 'mh' => 'Marshall Islands', > 'mq' => 'Martinique (French)', > 'mr' => 'Mauritania', > 'mu' => 'Mauritius', > 'yt' => 'Mayotte', > 'mx' => 'Mexico', > 'fm' => 'Micronesia', > 'md' => 'Moldavia', > 'mc' => 'Monaco', > 'mn' => 'Mongolia', > 'ms' => 'Montserrat', > 'ma' => 'Morocco', > 'mz' => 'Mozambique', > 'mm' => 'Myanmar', > 'na' => 'Namibia', > 'nr' => 'Nauru', > 'np' => 'Nepal', > 'nl' => 'Netherlands', > 'an' => 'Netherlands Antilles', > 'nt' => 'Neutral Zone', > 'nc' => 'New Caledonia (French)', > 'nz' => 'New Zealand', > 'ni' => 'Nicaragua', > 'ne' => 'Niger', > 'ng' => 'Nigeria', > 'nu' => 'Niue', > 'nf' => 'Norfolk Island', > 'kp' => 'North Korea', > 'mp' => 'Northern Mariana Islands', > 'no' => 'Norway', > 'om' => 'Oman', > 'pk' => 'Pakistan', > 'pw' => 'Palau', > 'pa' => 'Panama', > 'pg' => 'Papua New Guinea', > 'py' => 'Paraguay', > 'pe' => 'Peru', > 'ph' => 'Philippines', > 'pn' => 'Pitcairn Island', > 'pl' => 'Poland', > 'pf' => 'Polynesia (French)', > 'pt' => 'Portugal', > 'pr' => 'Puerto Rico', > 'qa' => 'Qatar', > 're' => 'Reunion (French)', > 'ro' => 'Romania', > 'ru' => 'Russian Federation', > 'rw' => 'Rwanda', > 'gs' => 'S. Georgia & S. Sandwich Isls.', > 'sh' => 'Saint Helena', > 'kn' => 'Saint Kitts & Nevis Anguilla', > 'lc' => 'Saint Lucia', > 'pm' => 'Saint Pierre and Miquelon', > 'st' => 'Saint Tome (Sao Tome) and Principe', > 'vc' => 'Saint Vincent & Grenadines', > 'ws' => 'Samoa', > 'sm' => 'San Marino', > 'sa' => 'Saudi Arabia', > 'sn' => 'Senegal', > 'sc' => 'Seychelles', > 'sl' => 'Sierra Leone', > 'sg' => 'Singapore', > 'sk' => 'Slovak Republic', > 'si' => 'Slovenia', > 'sb' => 'Solomon Islands', > 'so' => 'Somalia', > 'za' => 'South Africa', > 'kr' => 'South Korea', > 'es' => 'Spain', > 'lk' => 'Sri Lanka', > 'sd' => 'Sudan', > 'sr' => 'Suriname', > 'sj' => 'Svalbard and Jan Mayen Islands', > 'sz' => 'Swaziland', > 'se' => 'Sweden', > 'ch' => 'Switzerland', > 'sy' => 'Syria', > 'tj' => 'Tadjikistan', > 'tw' => 'Taiwan', > 'tz' => 'Tanzania', > 'th' => 'Thailand', > 'tg' => 'Togo', > 'tk' => 'Tokelau', > 'to' => 'Tonga', > 'tt' => 'Trinidad and Tobago', > 'tn' => 'Tunisia', > 'tr' => 'Turkey', > 'tm' => 'Turkmenistan', > 'tc' => 'Turks and Caicos Islands', > 'tv' => 'Tuvalu', > 'ug' => 'Uganda', > 'ua' => 'Ukraine', > 'ae' => 'United Arab Emirates', > 'uk' => 'United Kingdom', > 'us' => 'United States', > 'uy' => 'Uruguay', > 'um' => 'USA Minor Outlying Islands', > 'uz' => 'Uzbekistan', > 'vu' => 'Vanuatu', > 'va' => 'Vatican City State', > 've' => 'Venezuela', > 'vn' => 'Vietnam', > 'vg' => 'Virgin Islands (British)', > 'vi' => 'Virgin Islands (USA)', > 'wf' => 'Wallis and Futuna Islands', > 'eh' => 'Western Sahara', > 'ye' => 'Yemen', > 'yu' => 'Yugoslavia', > 'zr' => 'Zaire', > 'zm' => 'Zambia', > 'zw' => 'Zimbabwe' > ); > > > /** > * returns a string of option values for an HTML form > */ > function COM_country_select_list ($selected) > { > global $LANG_COUNTRIES; > > $retval = ''; > foreach ($LANG_COUNTRIES AS $key => $value) { > $retval .= ''; > } > return $retval; > } > > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: locales.txt URL: -------------- next part -------------- An HTML attachment was scrubbed... URL: From oliver at spiesshofer.com Tue Aug 7 03:31:23 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Tue, 07 Aug 2007 15:31:23 +0800 Subject: [geeklog-devel] Fwd: locales In-Reply-To: References: <92C97D95-A178-44E3-9D41-9FC83E0DC5BF@heatherengineering.com> Message-ID: <46B81FCB.7070603@spiesshofer.com> Euan, I generally agree with you but I made the experience that locales are different in every operating system and there is no clear standard that is followed. Correct me if I am wrong there. Oliver Heather Engineering wrote: > I posted this a while ago but there was no reaction. > I wonder if anyone thinks this is a good idea? Any comments? > > I'm working on a site for a client that needs to set content according > to locale. For now, I just added the $LANG_LOCALE string to each > language file. > > Another alternative might be that the multilanguage array setting in > config.php could be changed to use locale, not just language, as the > array key: > > $_CONF['language_files'] = array ( > 'en' => 'english_utf-8', > 'ja' => 'japanese_utf-8' > ); > > change to > > $_CONF['language_files'] = array ( > 'en_GB' => 'english_utf-8', > 'ja_JP' => 'japanese_utf-8' > ); > > I think that once you start working with several languages you come to > realise the importance of having locale settings available. I think > this is a necessary modification. > > Cheers, > > Euan. > > > > > Begin forwarded message: > >> *From: *Heather Engineering > > >> *Date: *2007?6?15? 0:10:51:JST >> *To: *Geeklog Development > > >> *Subject: **locales* >> >> I'd like to request that the locale is added to each language file >> next to the charset next time translations are updated: >> >> $LANG_CHARSET = 'utf-8'; >> $LANG_LOCALE = 'en_GB'; >> >> unless there is some other way of working out the locale that I'm >> missing? I know I could do it from the filename, but that seems a >> little long winded to me and I think that the locale should be >> available. The following array might also be useful if added to the >> language files. >> >> For good measure, I've added an array of countries in English in case >> anyone wants. This would also be useful in the language files. >> >> Euan. >> >> > ------------------------------------------------------------------------ > >> // partial list of locales >> $LANG_LOCALES = array ( >> 'af_ZA' => 'Afrikaans (South Africa)', >> 'ca_ES' => 'Catalan (Spain)', >> 'cs_CZ' => 'Czech (Czech Republic)', >> 'da_DK' => 'Danish (Denmark)', >> 'de_CH' => 'German (Switzerland)', >> 'de_DE' => 'German (Germany)', >> 'el_GR' => 'Greek (Greece)', >> 'en_GB' => 'English (UK)', >> 'en_US' => 'English (USA)', >> 'es_ES' => 'Spanish (Spain)', >> 'fi_FI' => 'Finnish (Finland)', >> 'fr_BE' => 'French (Belgium)', >> 'fr_CA' => 'French (Canada)', >> 'fr_CH' => 'French (Switzerland)', >> 'fr_FR' => 'French (France)', >> 'he_IL' => 'Hebrew (Israel)', >> 'hu_HU' => 'Hungarian (Hungary)', >> 'is_IS' => 'Islandic (Iceland)', >> 'it_IT' => 'Italian (Italy)', >> 'ja_JP' => 'Japanese (Japan)', >> 'ko_KR' => 'Korean (Korea)', >> 'lt_LT' => 'Lithuanian (Lithuania)', >> 'nl_NL' => 'Dutch (the Netherlands)', >> 'no_NO' => 'Norwegian (Norway)', >> 'pl_PL' => 'Polish (Poland)', >> 'pt_PT' => 'Portuguese (Portugal)', >> 'ru_RU' => 'Russian (Russia)', >> 'sk_SK' => 'Slovak (Slovakia)', >> 'sl_SI' => 'Slovenian (Slovenia)', >> 'sv_SE' => 'Swedish (Sweden)', >> 'th_TH' => 'Thai (Thailand)', >> 'tr_TR' => 'Turkish (Turkey)', >> 'zh_CN' => 'Chinese (Simplified)', >> 'zh_HK' => 'Chinese (Hong Kong)', >> 'zh_TW' => 'Chinese (Traditional, Taiwan)' >> ); >> // complete list of countries >> $LANG_COUNTRIES = array ( >> 'af' => 'Afghanistan', >> 'al' => 'Albania', >> 'dz' => 'Algeria', >> 'as' => 'American Samoa', >> 'ad' => 'Andorra', >> 'ao' => 'Angola', >> 'ai' => 'Anguilla', >> 'aq' => 'Antarctica', >> 'ag' => 'Antigua and Barbuda', >> 'ar' => 'Argentina', >> 'am' => 'Armenia', >> 'aw' => 'Aruba', >> 'au' => 'Australia', >> 'at' => 'Austria', >> 'az' => 'Azerbaidjan', >> 'bs' => 'Bahamas', >> 'bh' => 'Bahrain', >> 'bd' => 'Bangladesh', >> 'bb' => 'Barbados', >> 'by' => 'Belarus', >> 'be' => 'Belgium', >> 'bz' => 'Belize', >> 'bj' => 'Benin', >> 'bm' => 'Bermuda', >> 'bt' => 'Bhutan', >> 'bo' => 'Bolivia', >> 'ba' => 'Bosnia-Herzegovina', >> 'bw' => 'Botswana', >> 'bv' => 'Bouvet Island', >> 'br' => 'Brazil', >> 'io' => 'British Indian Ocean Territory', >> 'bn' => 'Brunei Darussalam', >> 'bg' => 'Bulgaria', >> 'bf' => 'Burkina Faso', >> 'bi' => 'Burundi', >> 'kh' => 'Cambodia', >> 'cm' => 'Cameroon', >> 'ca' => 'Canada', >> 'cv' => 'Cape Verde', >> 'ky' => 'Cayman Islands', >> 'cf' => 'Central African Republic', >> 'td' => 'Chad', >> 'cl' => 'Chile', >> 'cn' => 'China', >> 'cx' => 'Christmas Island', >> 'cc' => 'Cocos (Keeling) Islands', >> 'co' => 'Colombia', >> 'km' => 'Comoros', >> 'cg' => 'Congo', >> 'ck' => 'Cook Islands', >> 'cr' => 'Costa Rica', >> 'hr' => 'Croatia', >> 'cu' => 'Cuba', >> 'cy' => 'Cyprus', >> 'cz' => 'Czech Republic', >> 'dk' => 'Denmark', >> 'dj' => 'Djibouti', >> 'dm' => 'Dominica', >> 'do' => 'Dominican Republic', >> 'tp' => 'East Timor', >> 'ec' => 'Ecuador', >> 'eg' => 'Egypt', >> 'sv' => 'El Salvador', >> 'gq' => 'Equatorial Guinea', >> 'er' => 'Eritrea', >> 'ee' => 'Estonia', >> 'et' => 'Ethiopia', >> 'fk' => 'Falkland Islands', >> 'fo' => 'Faroe Islands', >> 'fj' => 'Fiji', >> 'fi' => 'Finland', >> 'cs' => 'Former Czechoslovakia', >> 'su' => 'Former USSR', >> 'fr' => 'France', >> 'fx' => 'France (European Territory)', >> 'gf' => 'French Guyana', >> 'tf' => 'French Southern Territories', >> 'ga' => 'Gabon', >> 'gm' => 'Gambia', >> 'ge' => 'Georgia', >> 'de' => 'Germany', >> 'gh' => 'Ghana', >> 'gi' => 'Gibraltar', >> 'gb' => 'Great Britain', >> 'gr' => 'Greece', >> 'gl' => 'Greenland', >> 'gd' => 'Grenada', >> 'gp' => 'Guadeloupe (French)', >> 'gu' => 'Guam (USA)', >> 'gt' => 'Guatemala', >> 'gn' => 'Guinea', >> 'gw' => 'Guinea Bissau', >> 'gy' => 'Guyana', >> 'ht' => 'Haiti', >> 'hm' => 'Heard and McDonald Islands', >> 'hn' => 'Honduras', >> 'hk' => 'Hong Kong', >> 'hu' => 'Hungary', >> 'is' => 'Iceland', >> 'in' => 'India', >> 'id' => 'Indonesia', >> 'ir' => 'Iran', >> 'iq' => 'Iraq', >> 'ie' => 'Ireland', >> 'il' => 'Israel', >> 'it' => 'Italy', >> 'ci' => 'Ivory Coast (Cote D\'Ivoire)', >> 'jm' => 'Jamaica', >> 'jp' => 'Japan', >> 'jo' => 'Jordan', >> 'kz' => 'Kazakhstan', >> 'ke' => 'Kenya', >> 'ki' => 'Kiribati', >> 'kw' => 'Kuwait', >> 'kg' => 'Kyrgyzstan', >> 'la' => 'Laos', >> 'lv' => 'Latvia', >> 'lb' => 'Lebanon', >> 'ls' => 'Lesotho', >> 'lr' => 'Liberia', >> 'ly' => 'Libya', >> 'li' => 'Liechtenstein', >> 'lt' => 'Lithuania', >> 'lu' => 'Luxembourg', >> 'mo' => 'Macau', >> 'mk' => 'Macedonia', >> 'mg' => 'Madagascar', >> 'mw' => 'Malawi', >> 'my' => 'Malaysia', >> 'mv' => 'Maldives', >> 'ml' => 'Mali', >> 'mt' => 'Malta', >> 'mh' => 'Marshall Islands', >> 'mq' => 'Martinique (French)', >> 'mr' => 'Mauritania', >> 'mu' => 'Mauritius', >> 'yt' => 'Mayotte', >> 'mx' => 'Mexico', >> 'fm' => 'Micronesia', >> 'md' => 'Moldavia', >> 'mc' => 'Monaco', >> 'mn' => 'Mongolia', >> 'ms' => 'Montserrat', >> 'ma' => 'Morocco', >> 'mz' => 'Mozambique', >> 'mm' => 'Myanmar', >> 'na' => 'Namibia', >> 'nr' => 'Nauru', >> 'np' => 'Nepal', >> 'nl' => 'Netherlands', >> 'an' => 'Netherlands Antilles', >> 'nt' => 'Neutral Zone', >> 'nc' => 'New Caledonia (French)', >> 'nz' => 'New Zealand', >> 'ni' => 'Nicaragua', >> 'ne' => 'Niger', >> 'ng' => 'Nigeria', >> 'nu' => 'Niue', >> 'nf' => 'Norfolk Island', >> 'kp' => 'North Korea', >> 'mp' => 'Northern Mariana Islands', >> 'no' => 'Norway', >> 'om' => 'Oman', >> 'pk' => 'Pakistan', >> 'pw' => 'Palau', >> 'pa' => 'Panama', >> 'pg' => 'Papua New Guinea', >> 'py' => 'Paraguay', >> 'pe' => 'Peru', >> 'ph' => 'Philippines', >> 'pn' => 'Pitcairn Island', >> 'pl' => 'Poland', >> 'pf' => 'Polynesia (French)', >> 'pt' => 'Portugal', >> 'pr' => 'Puerto Rico', >> 'qa' => 'Qatar', >> 're' => 'Reunion (French)', >> 'ro' => 'Romania', >> 'ru' => 'Russian Federation', >> 'rw' => 'Rwanda', >> 'gs' => 'S. Georgia & S. Sandwich Isls.', >> 'sh' => 'Saint Helena', >> 'kn' => 'Saint Kitts & Nevis Anguilla', >> 'lc' => 'Saint Lucia', >> 'pm' => 'Saint Pierre and Miquelon', >> 'st' => 'Saint Tome (Sao Tome) and Principe', >> 'vc' => 'Saint Vincent & Grenadines', >> 'ws' => 'Samoa', >> 'sm' => 'San Marino', >> 'sa' => 'Saudi Arabia', >> 'sn' => 'Senegal', >> 'sc' => 'Seychelles', >> 'sl' => 'Sierra Leone', >> 'sg' => 'Singapore', >> 'sk' => 'Slovak Republic', >> 'si' => 'Slovenia', >> 'sb' => 'Solomon Islands', >> 'so' => 'Somalia', >> 'za' => 'South Africa', >> 'kr' => 'South Korea', >> 'es' => 'Spain', >> 'lk' => 'Sri Lanka', >> 'sd' => 'Sudan', >> 'sr' => 'Suriname', >> 'sj' => 'Svalbard and Jan Mayen Islands', >> 'sz' => 'Swaziland', >> 'se' => 'Sweden', >> 'ch' => 'Switzerland', >> 'sy' => 'Syria', >> 'tj' => 'Tadjikistan', >> 'tw' => 'Taiwan', >> 'tz' => 'Tanzania', >> 'th' => 'Thailand', >> 'tg' => 'Togo', >> 'tk' => 'Tokelau', >> 'to' => 'Tonga', >> 'tt' => 'Trinidad and Tobago', >> 'tn' => 'Tunisia', >> 'tr' => 'Turkey', >> 'tm' => 'Turkmenistan', >> 'tc' => 'Turks and Caicos Islands', >> 'tv' => 'Tuvalu', >> 'ug' => 'Uganda', >> 'ua' => 'Ukraine', >> 'ae' => 'United Arab Emirates', >> 'uk' => 'United Kingdom', >> 'us' => 'United States', >> 'uy' => 'Uruguay', >> 'um' => 'USA Minor Outlying Islands', >> 'uz' => 'Uzbekistan', >> 'vu' => 'Vanuatu', >> 'va' => 'Vatican City State', >> 've' => 'Venezuela', >> 'vn' => 'Vietnam', >> 'vg' => 'Virgin Islands (British)', >> 'vi' => 'Virgin Islands (USA)', >> 'wf' => 'Wallis and Futuna Islands', >> 'eh' => 'Western Sahara', >> 'ye' => 'Yemen', >> 'yu' => 'Yugoslavia', >> 'zr' => 'Zaire', >> 'zm' => 'Zambia', >> 'zw' => 'Zimbabwe' >> ); >> /** >> * returns a string of option values for an HTML form >> */ >> function COM_country_select_list ($selected) >> { >> global $LANG_COUNTRIES; >> $retval = ''; >> foreach ($LANG_COUNTRIES AS $key => $value) { >> $retval .= ''; >> } >> return $retval; >> } > ------------------------------------------------------------------------ > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel From joe at ThrowingDice.com Tue Aug 7 10:26:59 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Tue, 07 Aug 2007 10:26:59 -0400 Subject: [geeklog-devel] Fwd: locales In-Reply-To: <46B81FCB.7070603@spiesshofer.com> References: <92C97D95-A178-44E3-9D41-9FC83E0DC5BF@heatherengineering.com> <46B81FCB.7070603@spiesshofer.com> Message-ID: <0JME004UBQT02IK0@mta1.srv.hcvlny.cv.net> At 03:31 AM 8/7/2007, Oliver wrote: >Euan, I generally agree with you but I made the experience that >locales are different in every operating system and there is no >clear standard that is followed. Correct me if I am wrong there. No, you are right. The help page for setlocale is full of exceptions for Windows and AIX. PEAR has two class trees for Internationalization I18N and I18Nv2. Both are beta. But they do encapsulate the differences between Unix and Windows. Someone serious about adding locales to Geeklog should look into those packages. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From info at heatherengineering.com Tue Aug 7 11:51:14 2007 From: info at heatherengineering.com (Heather Engineering) Date: Wed, 8 Aug 2007 00:51:14 +0900 Subject: [geeklog-devel] Fwd: locales In-Reply-To: <0JME004UBQT02IK0@mta1.srv.hcvlny.cv.net> References: <92C97D95-A178-44E3-9D41-9FC83E0DC5BF@heatherengineering.com> <46B81FCB.7070603@spiesshofer.com> <0JME004UBQT02IK0@mta1.srv.hcvlny.cv.net> Message-ID: <7B5F449E-2488-42AD-BC5E-B30A990F13E9@heatherengineering.com> On 2007/08/07, at 23:26, Joe Mucchiello wrote: > At 03:31 AM 8/7/2007, Oliver wrote: >> Euan, I generally agree with you but I made the experience that >> locales are different in every operating system and there is no >> clear standard that is followed. Correct me if I am wrong there. > > No, you are right. The help page for setlocale is full of > exceptions for Windows and AIX. PEAR has two class trees for > Internationalization I18N and I18Nv2. Both are beta. But they do > encapsulate the differences between Unix and Windows. Someone > serious about adding locales to Geeklog should look into those > packages. Actually, I just realised after looking at Dirk's implementation of the language switcher, that I can set the key of the multilanguage file array to whatever I like - so I can use any key (eg en_GB, ja_JP) that I like. Which means I can set these to my preferred locale strings and work from them. That'll do me for now, as no time to look into anything else for the moment. Will look at PEAR though later - thanks Joe. Cheers, Euan. From oliver at spiesshofer.com Wed Aug 8 22:37:34 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Thu, 09 Aug 2007 10:37:34 +0800 Subject: [geeklog-devel] Comments for static pages? Message-ID: <46BA7DEE.1090007@spiesshofer.com> Is there any objection to implement (optional) comments for static pages? I think this could be really helpful wonder if this came up already... Oliver From joe at ThrowingDice.com Thu Aug 9 00:22:19 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Thu, 09 Aug 2007 00:22:19 -0400 Subject: [geeklog-devel] Comments for static pages? In-Reply-To: <46BA7DEE.1090007@spiesshofer.com> References: <46BA7DEE.1090007@spiesshofer.com> Message-ID: <0JMH00I15O5JP5K0@mta3.srv.hcvlny.cv.net> A great idea as long as comments can be turned on or off for each individual staticpage. At 10:37 PM 8/8/2007, Oliver Spiesshofer wrote: >Is there any objection to implement (optional) comments for static pages? > >I think this could be really helpful >wonder if this came up already... ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From oliver at spiesshofer.com Thu Aug 9 00:26:36 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Thu, 09 Aug 2007 12:26:36 +0800 Subject: [geeklog-devel] Comments for static pages? In-Reply-To: <0JMH00I15O5JP5K0@mta3.srv.hcvlny.cv.net> References: <46BA7DEE.1090007@spiesshofer.com> <0JMH00I15O5JP5K0@mta3.srv.hcvlny.cv.net> Message-ID: <46BA977C.3010709@spiesshofer.com> Off course. It will work just like comments for stories. Oliver Joe Mucchiello wrote: > A great idea as long as comments can be turned on or off for each > individual staticpage. > > At 10:37 PM 8/8/2007, Oliver Spiesshofer wrote: >> Is there any objection to implement (optional) comments for static >> pages? >> >> I think this could be really helpful >> wonder if this came up already... > > ---- > Joe Mucchiello > Throwing Dice Games > http://www.throwingdice.com > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > From info at heatherengineering.com Thu Aug 9 00:57:47 2007 From: info at heatherengineering.com (Heather Engineering) Date: Thu, 9 Aug 2007 13:57:47 +0900 Subject: [geeklog-devel] Comments for static pages? In-Reply-To: <46BA977C.3010709@spiesshofer.com> References: <46BA7DEE.1090007@spiesshofer.com> <0JMH00I15O5JP5K0@mta3.srv.hcvlny.cv.net> <46BA977C.3010709@spiesshofer.com> Message-ID: While you're at it, an option in config.php to redirect to the page just edited instead of the staticpage admin list would be nice. I have some code somewhere if you want but it is trivial to implement. Cheers, Euan. On 2007/08/09, at 13:26, Oliver Spiesshofer wrote: > Off course. It will work just like comments for stories. > > Oliver > > Joe Mucchiello wrote: >> A great idea as long as comments can be turned on or off for each >> individual staticpage. >> >> At 10:37 PM 8/8/2007, Oliver Spiesshofer wrote: >>> Is there any objection to implement (optional) comments for >>> static pages? >>> >>> I think this could be really helpful >>> wonder if this came up already... >> >> ---- >> Joe Mucchiello >> Throwing Dice Games >> http://www.throwingdice.com >> _______________________________________________ >> geeklog-devel mailing list >> geeklog-devel at lists.geeklog.net >> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >> >> > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel From oliver at spiesshofer.com Thu Aug 9 01:32:04 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Thu, 09 Aug 2007 13:32:04 +0800 Subject: [geeklog-devel] Comments for static pages? In-Reply-To: References: <46BA7DEE.1090007@spiesshofer.com> <0JMH00I15O5JP5K0@mta3.srv.hcvlny.cv.net> <46BA977C.3010709@spiesshofer.com> Message-ID: <46BAA6D4.9000401@spiesshofer.com> Ah yes, thats something that is needed for all edited Items I suppose. It regularly freaks me out in stories, users etc etc. Oliver Heather Engineering wrote: > While you're at it, an option in config.php to redirect to the page > just edited instead of the staticpage admin list would be nice. I have > some code somewhere if you want but it is trivial to implement. > > Cheers, > > Euan. > > > On 2007/08/09, at 13:26, Oliver Spiesshofer wrote: > >> Off course. It will work just like comments for stories. >> >> Oliver >> >> Joe Mucchiello wrote: >>> A great idea as long as comments can be turned on or off for each >>> individual staticpage. >>> >>> At 10:37 PM 8/8/2007, Oliver Spiesshofer wrote: >>>> Is there any objection to implement (optional) comments for static >>>> pages? >>>> >>>> I think this could be really helpful >>>> wonder if this came up already... >>> >>> ---- >>> Joe Mucchiello >>> Throwing Dice Games >>> http://www.throwingdice.com >>> _______________________________________________ >>> geeklog-devel mailing list >>> geeklog-devel at lists.geeklog.net >>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >>> >>> >> >> _______________________________________________ >> geeklog-devel mailing list >> geeklog-devel at lists.geeklog.net >> http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > From dirk at haun-online.de Thu Aug 9 15:17:57 2007 From: dirk at haun-online.de (Dirk Haun) Date: Thu, 9 Aug 2007 21:17:57 +0200 Subject: [geeklog-devel] Link back from plugin comments? Message-ID: <20070809191757.1838430708@smtp.haun-online.de> Just something I noticed while playing with the new static pages comment feature: On a story, when you view just one comment via its permalink, e.g. you have the option to go back to the story it has been posted under. It's not too obvious, but clicking on the title above the comment bar ("Bad Behavior 2.0.10 Plugin Released" in this case) will take you back to the article page. There is, however, no such option for comments posted by plugins, e.g. Is that (yet another) restriction of the plugin API for comments? bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From vfuria at gmail.com Thu Aug 9 15:30:26 2007 From: vfuria at gmail.com (Vincent Furia) Date: Thu, 9 Aug 2007 13:30:26 -0600 Subject: [geeklog-devel] Link back from plugin comments? In-Reply-To: <20070809191757.1838430708@smtp.haun-online.de> References: <20070809191757.1838430708@smtp.haun-online.de> Message-ID: <8319e2d60708091230p234807ccpa0e8b2189e1f4714@mail.gmail.com> I thought I had fixed that when I did the comments API scrub a while back... I'll look into it tonight. -Vinny On 8/9/07, Dirk Haun wrote: > Just something I noticed while playing with the new static pages comment > feature: > > On a story, when you view just one comment via its permalink, e.g. > > > > you have the option to go back to the story it has been posted under. > It's not too obvious, but clicking on the title above the comment bar > ("Bad Behavior 2.0.10 Plugin Released" in this case) will take you back > to the article page. > > There is, however, no such option for comments posted by plugins, e.g. > > > > Is that (yet another) restriction of the plugin API for comments? > > bye, Dirk > > > -- > Geeklog Day at FrOSCon: August 25, 2007 - See you there! > http://www.geeklog.net/article.php/geeklog-day-at-froscon > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > From dirk at haun-online.de Thu Aug 9 15:43:54 2007 From: dirk at haun-online.de (Dirk Haun) Date: Thu, 9 Aug 2007 21:43:54 +0200 Subject: [geeklog-devel] Link back from plugin comments? In-Reply-To: <8319e2d60708091230p234807ccpa0e8b2189e1f4714@mail.gmail.com> References: <20070809191757.1838430708@smtp.haun-online.de> <8319e2d60708091230p234807ccpa0e8b2189e1f4714@mail.gmail.com> Message-ID: <20070809194354.1261645246@smtp.haun-online.de> Vincent Furia wrote: >I thought I had fixed that when I did the comments API scrub a while >back... I'll look into it tonight. Thanks, Vinny. It may simply be missing from the templates ... bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From vfuria at gmail.com Thu Aug 9 17:06:10 2007 From: vfuria at gmail.com (Vincent Furia) Date: Thu, 9 Aug 2007 15:06:10 -0600 Subject: [geeklog-devel] Link back from plugin comments? In-Reply-To: <20070809194354.1261645246@smtp.haun-online.de> References: <20070809191757.1838430708@smtp.haun-online.de> <8319e2d60708091230p234807ccpa0e8b2189e1f4714@mail.gmail.com> <20070809194354.1261645246@smtp.haun-online.de> Message-ID: <8319e2d60708091406s4f65fa2fje485111e7f95d231@mail.gmail.com> The comment bar should contain a link back to the main item (story, staticpage, etc). You do need the plugin function plugin_getcommenturlid_ or else it assumes the location is geeklog_url/plugin_name/index.php?id=XXX. The template variable that gets filled out is: story_link Let me know if that helps, Vinny On 8/9/07, Dirk Haun wrote: > Vincent Furia wrote: > > >I thought I had fixed that when I did the comments API scrub a while > >back... I'll look into it tonight. > > Thanks, Vinny. It may simply be missing from the templates ... > > bye, Dirk > > > -- > Geeklog Day at FrOSCon: August 25, 2007 - See you there! > http://www.geeklog.net/article.php/geeklog-day-at-froscon > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > From dracul01 at gmail.com Thu Aug 9 17:27:47 2007 From: dracul01 at gmail.com (Damien Hodgkin) Date: Thu, 9 Aug 2007 17:27:47 -0400 Subject: [geeklog-devel] Filtering unwanted markup and JS from posted content ie. Articles, Static pages and Flexy content. Message-ID: <200708091727.52447.dracul01@gmail.com> Wondering if anyone has any good ideas an the best way to implement such filtering. Kses as far as I know is being phased out. So I and working on a new filtering class to allow all the plugins in Gl2 to utilise for various filtering tasks, including, Email validation, URL validation, Markup filtering and validation and a few other things no decided on yet. This will closely tie in with the content plugin. But be available to any other in-house or thirdparty plugins that need such features. -- Best Regards, Damien ------------- "I only have two braincells left, one is missing, and the other is putting up flyers!" -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part. URL: From michael.tutty at gmail.com Thu Aug 9 19:07:49 2007 From: michael.tutty at gmail.com (Michael Tutty) Date: Thu, 9 Aug 2007 18:07:49 -0500 Subject: [geeklog-devel] Filtering unwanted markup and JS from posted content ie. Articles, Static pages and Flexy content. In-Reply-To: <200708091727.52447.dracul01@gmail.com> References: <200708091727.52447.dracul01@gmail.com> Message-ID: <62d0f2020708091607t56519ad4p2a0102076a8d37b8@mail.gmail.com> How about HTML Purifier ? Don't know if it's worth anything but the site says all the right things... M. On 8/9/07, Damien Hodgkin wrote: > > Wondering if anyone has any good ideas an the best way to implement such > filtering. Kses as far as I know is being phased out. So I and working on > a > new filtering class to allow all the plugins in Gl2 to utilise for various > filtering tasks, including, Email validation, URL validation, Markup > filtering and validation and a few other things no decided on yet. > > This will closely tie in with the content plugin. But be available to any > other in-house or thirdparty plugins that need such features. > > -- > Best Regards, > Damien > ------------- > "I only have two braincells left, one is missing, and the other is putting > up > flyers!" > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From joe at ThrowingDice.com Thu Aug 9 20:05:40 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Thu, 09 Aug 2007 20:05:40 -0400 Subject: [geeklog-devel] [geeklog-cvs] Geeklog-1.x/plugins/staticpages services.inc.php, NONE, 1.1 config.php, 1.16, 1.17 functions.inc, 1.98, 1.99 In-Reply-To: <20070809193222.2C52110FE12@qs1489.pair.com> References: <20070809193222.2C52110FE12@qs1489.pair.com> Message-ID: <0JMJ0062E6XO7RD0@mta4.srv.hcvlny.cv.net> Is there any documentation for the services API? At 03:32 PM 8/9/2007, Dirk Haun wrote: >Update of /cvsroot/geeklog/Geeklog-1.x/plugins/staticpages >In directory qs1489.pair.com:/tmp/cvs-serv58945/plugins/staticpages > >Modified Files: > config.php functions.inc >Added Files: > services.inc.php >Log Message: >Static pages plugin rewritten to use the internal API (and, later, >the webservices API), on behalf of Ramnath R Iyer ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From dracul01 at gmail.com Fri Aug 10 00:20:27 2007 From: dracul01 at gmail.com (Damien Hodgkin) Date: Fri, 10 Aug 2007 00:20:27 -0400 Subject: [geeklog-devel] Filtering unwanted markup and JS from posted content ie. Articles, Static pages and Flexy content. In-Reply-To: <62d0f2020708091607t56519ad4p2a0102076a8d37b8@mail.gmail.com> References: <200708091727.52447.dracul01@gmail.com> <62d0f2020708091607t56519ad4p2a0102076a8d37b8@mail.gmail.com> Message-ID: <200708100020.33748.dracul01@gmail.com> Thanks Michael I'll check into it. It would definitely save me lots of work and I could then start work on other things. On Thursday 09 August 2007 7:07:49 pm Michael Tutty wrote: > How about HTML Purifier ? Don't know if it's > worth anything but the site says all the right things... > M. > > On 8/9/07, Damien Hodgkin wrote: > > Wondering if anyone has any good ideas an the best way to implement such > > filtering. Kses as far as I know is being phased out. So I and working on > > a > > new filtering class to allow all the plugins in Gl2 to utilise for > > various filtering tasks, including, Email validation, URL validation, > > Markup filtering and validation and a few other things no decided on yet. > > > > This will closely tie in with the content plugin. But be available to any > > other in-house or thirdparty plugins that need such features. > > > > -- > > Best Regards, > > Damien > > ------------- > > "I only have two braincells left, one is missing, and the other is > > putting up > > flyers!" > > > > _______________________________________________ > > geeklog-devel mailing list > > geeklog-devel at lists.geeklog.net > > http://eight.pairlist.net/mailman/listinfo/geeklog-devel -- Best Regards, Damien ------------- "I only have two braincells left, one is missing, and the other is putting up flyers!" -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part. URL: From info at heatherengineering.com Fri Aug 10 01:28:58 2007 From: info at heatherengineering.com (Heather Engineering) Date: Fri, 10 Aug 2007 14:28:58 +0900 Subject: [geeklog-devel] Comments for static pages? In-Reply-To: <46BAA6D4.9000401@spiesshofer.com> References: <46BA7DEE.1090007@spiesshofer.com> <0JMH00I15O5JP5K0@mta3.srv.hcvlny.cv.net> <46BA977C.3010709@spiesshofer.com> <46BAA6D4.9000401@spiesshofer.com> Message-ID: <67A95349-E7AB-4FD6-A7FD-584F6DC5391C@heatherengineering.com> Oliver, If you're still looking at the staticpages plugin: in public_html/ staticpages/index.php, if there is an error/denied access, right blocks are automatically shown no matter what site settings you use: public_html/staticpages/index.php from about line 202: if ($failflg) { $retval = COM_siteHeader ('menu'); $retval .= COM_startBlock ($LANG_LOGIN[1], '', COM_getBlockTemplate ('_msg_block', 'header')); $login = new Template ($_CONF['path_layout'] . 'submit'); $login->set_file (array ('login' => 'submitloginrequired.thtml')); $login->set_var ('login_message', $LANG_LOGIN[2]); $login->set_var ('site_url', $_CONF['site_url']); $login->set_var ('lang_login', $LANG_LOGIN[3]); $login->set_var ('lang_newuser', $LANG_LOGIN[4]); $login->parse ('output', 'login'); $retval .= $login->finish ($login->get_var ('output')); $retval .= COM_endBlock (COM_getBlockTemplate ('_msg_block', 'footer')); $retval .= COM_siteFooter (true); } else { $retval = COM_siteHeader ('menu'); $retval .= COM_startBlock ($LANG_ACCESS['accessdenied'], '', COM_getBlockTemplate ('_msg_block', 'header')); $retval .= $LANG_STATIC['deny_msg']; $retval .= COM_endBlock (COM_getBlockTemplate ('_msg_block', 'footer')); $retval .= COM_siteFooter (true); } Personally I think that each site footer call should be if ($_CONF['show_right_blocks']) { $retval .= COM_siteFooter (true); } else { $retval .= COM_siteFooter (); } Cheers, Euan. On 2007/08/09, at 14:32, Oliver Spiesshofer wrote: > Ah yes, thats something that is needed for all edited Items I > suppose. It regularly freaks me out in stories, users etc etc. > > Oliver > > Heather Engineering wrote: >> While you're at it, an option in config.php to redirect to the >> page just edited instead of the staticpage admin list would be >> nice. I have some code somewhere if you want but it is trivial to >> implement. >> >> Cheers, >> >> Euan. >> >> >> On 2007/08/09, at 13:26, Oliver Spiesshofer wrote: >> >>> Off course. It will work just like comments for stories. >>> >>> Oliver >>> >>> Joe Mucchiello wrote: >>>> A great idea as long as comments can be turned on or off for >>>> each individual staticpage. >>>> >>>> At 10:37 PM 8/8/2007, Oliver Spiesshofer wrote: >>>>> Is there any objection to implement (optional) comments for >>>>> static pages? >>>>> >>>>> I think this could be really helpful >>>>> wonder if this came up already... >>>> >>>> ---- >>>> Joe Mucchiello >>>> Throwing Dice Games >>>> http://www.throwingdice.com >>>> _______________________________________________ >>>> geeklog-devel mailing list >>>> geeklog-devel at lists.geeklog.net >>>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >>>> >>>> >>> >>> _______________________________________________ >>> geeklog-devel mailing list >>> geeklog-devel at lists.geeklog.net >>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >> >> _______________________________________________ >> geeklog-devel mailing list >> geeklog-devel at lists.geeklog.net >> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >> >> > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel From dirk at haun-online.de Fri Aug 10 01:56:23 2007 From: dirk at haun-online.de (Dirk Haun) Date: Fri, 10 Aug 2007 07:56:23 +0200 Subject: [geeklog-devel] [geeklog-cvs] Geeklog-1.x/plugins/staticpages services.inc.php, NONE, 1.1 config.php, 1.16, 1.17 functions.inc, 1.98, 1.99 In-Reply-To: <0JMJ0062E6XO7RD0@mta4.srv.hcvlny.cv.net> References: <20070809193222.2C52110FE12@qs1489.pair.com> <0JMJ0062E6XO7RD0@mta4.srv.hcvlny.cv.net> Message-ID: <20070810055623.1813555721@smtp.haun-online.de> Joe Mucchiello wrote: >Is there any documentation for the services API? Coming - I just didn't get around to finish it yet. About two thirds of the documentation is already in the wiki: I'll add the rest today or tomorrow and post some more about it here. bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From oliver at spiesshofer.com Fri Aug 10 02:31:09 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Fri, 10 Aug 2007 14:31:09 +0800 Subject: [geeklog-devel] Comments for static pages? In-Reply-To: <67A95349-E7AB-4FD6-A7FD-584F6DC5391C@heatherengineering.com> References: <46BA7DEE.1090007@spiesshofer.com> <0JMH00I15O5JP5K0@mta3.srv.hcvlny.cv.net> <46BA977C.3010709@spiesshofer.com> <46BAA6D4.9000401@spiesshofer.com> <67A95349-E7AB-4FD6-A7FD-584F6DC5391C@heatherengineering.com> Message-ID: <46BC062D.7010102@spiesshofer.com> I agree with you but cannot find that code. My public_html/staticpages/index.php has only 60 lines... Oliver Heather Engineering wrote: > Oliver, > > If you're still looking at the staticpages plugin: in > public_html/staticpages/index.php, if there is an error/denied access, > right blocks are automatically shown no matter what site settings you > use: > > public_html/staticpages/index.php from about line 202: > > if ($failflg) { > $retval = COM_siteHeader ('menu'); > $retval .= COM_startBlock ($LANG_LOGIN[1], '', > COM_getBlockTemplate ('_msg_block', > 'header')); > $login = new Template ($_CONF['path_layout'] . 'submit'); > $login->set_file (array ('login' => > 'submitloginrequired.thtml')); > $login->set_var ('login_message', $LANG_LOGIN[2]); > $login->set_var ('site_url', $_CONF['site_url']); > $login->set_var ('lang_login', $LANG_LOGIN[3]); > $login->set_var ('lang_newuser', $LANG_LOGIN[4]); > $login->parse ('output', 'login'); > $retval .= $login->finish ($login->get_var ('output')); > $retval .= COM_endBlock (COM_getBlockTemplate ('_msg_block', > 'footer')); > $retval .= COM_siteFooter (true); > } else { > $retval = COM_siteHeader ('menu'); > $retval .= COM_startBlock ($LANG_ACCESS['accessdenied'], '', > COM_getBlockTemplate ('_msg_block', > 'header')); > $retval .= $LANG_STATIC['deny_msg']; > $retval .= COM_endBlock (COM_getBlockTemplate ('_msg_block', > 'footer')); > $retval .= COM_siteFooter (true); > } > > Personally I think that each site footer call should be > > if ($_CONF['show_right_blocks']) { > $retval .= COM_siteFooter (true); > } else { > $retval .= COM_siteFooter (); > } > > Cheers, > > Euan. > > > > > On 2007/08/09, at 14:32, Oliver Spiesshofer wrote: > >> Ah yes, thats something that is needed for all edited Items I >> suppose. It regularly freaks me out in stories, users etc etc. >> >> Oliver >> >> Heather Engineering wrote: >>> While you're at it, an option in config.php to redirect to the page >>> just edited instead of the staticpage admin list would be nice. I >>> have some code somewhere if you want but it is trivial to implement. >>> >>> Cheers, >>> >>> Euan. >>> >>> >>> On 2007/08/09, at 13:26, Oliver Spiesshofer wrote: >>> >>>> Off course. It will work just like comments for stories. >>>> >>>> Oliver >>>> >>>> Joe Mucchiello wrote: >>>>> A great idea as long as comments can be turned on or off for each >>>>> individual staticpage. >>>>> >>>>> At 10:37 PM 8/8/2007, Oliver Spiesshofer wrote: >>>>>> Is there any objection to implement (optional) comments for >>>>>> static pages? >>>>>> >>>>>> I think this could be really helpful >>>>>> wonder if this came up already... >>>>> >>>>> ---- >>>>> Joe Mucchiello >>>>> Throwing Dice Games >>>>> http://www.throwingdice.com >>>>> _______________________________________________ >>>>> geeklog-devel mailing list >>>>> geeklog-devel at lists.geeklog.net >>>>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >>>>> >>>>> >>>> >>>> _______________________________________________ >>>> geeklog-devel mailing list >>>> geeklog-devel at lists.geeklog.net >>>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >>> >>> _______________________________________________ >>> geeklog-devel mailing list >>> geeklog-devel at lists.geeklog.net >>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >>> >>> >> >> _______________________________________________ >> geeklog-devel mailing list >> geeklog-devel at lists.geeklog.net >> http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > From info at heatherengineering.com Fri Aug 10 02:55:53 2007 From: info at heatherengineering.com (Heather Engineering) Date: Fri, 10 Aug 2007 15:55:53 +0900 Subject: [geeklog-devel] Comments for static pages? In-Reply-To: <46BC062D.7010102@spiesshofer.com> References: <46BA7DEE.1090007@spiesshofer.com> <0JMH00I15O5JP5K0@mta3.srv.hcvlny.cv.net> <46BA977C.3010709@spiesshofer.com> <46BAA6D4.9000401@spiesshofer.com> <67A95349-E7AB-4FD6-A7FD-584F6DC5391C@heatherengineering.com> <46BC062D.7010102@spiesshofer.com> Message-ID: <7615C59B-E362-42D2-BCFE-569A97C63099@heatherengineering.com> I got that from the staticpages included in geeklog 1.4.1 tarball. Perhaps cvs is different - but the online cvs viewer is not working... Euan. On 2007/08/10, at 15:31, Oliver Spiesshofer wrote: > I agree with you but cannot find that code. My public_html/ > staticpages/index.php has only 60 lines... > > Oliver > > Heather Engineering wrote: >> Oliver, >> >> If you're still looking at the staticpages plugin: in public_html/ >> staticpages/index.php, if there is an error/denied access, right >> blocks are automatically shown no matter what site settings you use: >> >> public_html/staticpages/index.php from about line 202: >> >> if ($failflg) { >> $retval = COM_siteHeader ('menu'); >> $retval .= COM_startBlock ($LANG_LOGIN[1], '', >> COM_getBlockTemplate ('_msg_block', >> 'header')); >> $login = new Template ($_CONF['path_layout'] . 'submit'); >> $login->set_file (array ('login' => >> 'submitloginrequired.thtml')); >> $login->set_var ('login_message', $LANG_LOGIN[2]); >> $login->set_var ('site_url', $_CONF['site_url']); >> $login->set_var ('lang_login', $LANG_LOGIN[3]); >> $login->set_var ('lang_newuser', $LANG_LOGIN[4]); >> $login->parse ('output', 'login'); >> $retval .= $login->finish ($login->get_var ('output')); >> $retval .= COM_endBlock (COM_getBlockTemplate >> ('_msg_block', 'footer')); >> $retval .= COM_siteFooter (true); >> } else { >> $retval = COM_siteHeader ('menu'); >> $retval .= COM_startBlock ($LANG_ACCESS['accessdenied'], '', >> COM_getBlockTemplate ('_msg_block', >> 'header')); >> $retval .= $LANG_STATIC['deny_msg']; >> $retval .= COM_endBlock (COM_getBlockTemplate >> ('_msg_block', 'footer')); >> $retval .= COM_siteFooter (true); >> } >> >> Personally I think that each site footer call should be >> >> if ($_CONF['show_right_blocks']) { >> $retval .= COM_siteFooter (true); >> } else { >> $retval .= COM_siteFooter (); >> } >> >> Cheers, >> >> Euan. >> >> >> >> >> On 2007/08/09, at 14:32, Oliver Spiesshofer wrote: >> >>> Ah yes, thats something that is needed for all edited Items I >>> suppose. It regularly freaks me out in stories, users etc etc. >>> >>> Oliver >>> >>> Heather Engineering wrote: >>>> While you're at it, an option in config.php to redirect to the >>>> page just edited instead of the staticpage admin list would be >>>> nice. I have some code somewhere if you want but it is trivial >>>> to implement. >>>> >>>> Cheers, >>>> >>>> Euan. >>>> >>>> >>>> On 2007/08/09, at 13:26, Oliver Spiesshofer wrote: >>>> >>>>> Off course. It will work just like comments for stories. >>>>> >>>>> Oliver >>>>> >>>>> Joe Mucchiello wrote: >>>>>> A great idea as long as comments can be turned on or off for >>>>>> each individual staticpage. >>>>>> >>>>>> At 10:37 PM 8/8/2007, Oliver Spiesshofer wrote: >>>>>>> Is there any objection to implement (optional) comments for >>>>>>> static pages? >>>>>>> >>>>>>> I think this could be really helpful >>>>>>> wonder if this came up already... >>>>>> >>>>>> ---- >>>>>> Joe Mucchiello >>>>>> Throwing Dice Games >>>>>> http://www.throwingdice.com >>>>>> _______________________________________________ >>>>>> geeklog-devel mailing list >>>>>> geeklog-devel at lists.geeklog.net >>>>>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >>>>>> >>>>>> >>>>> >>>>> _______________________________________________ >>>>> geeklog-devel mailing list >>>>> geeklog-devel at lists.geeklog.net >>>>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >>>> >>>> _______________________________________________ >>>> geeklog-devel mailing list >>>> geeklog-devel at lists.geeklog.net >>>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >>>> >>>> >>> >>> _______________________________________________ >>> geeklog-devel mailing list >>> geeklog-devel at lists.geeklog.net >>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >> >> _______________________________________________ >> geeklog-devel mailing list >> geeklog-devel at lists.geeklog.net >> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >> >> > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel From dirk at haun-online.de Fri Aug 10 16:34:55 2007 From: dirk at haun-online.de (Dirk Haun) Date: Fri, 10 Aug 2007 22:34:55 +0200 Subject: [geeklog-devel] About the "internal" and Webservices APIs Message-ID: <20070810203456.1283526497@smtp.haun-online.de> Ramnath will be offline for a couple of days. In the meantime, I'm going through the code he provided so far to see what's ready to go into CVS and what's not there yet. In case you don't know or remember, the task[1] from the Google Summer of Code was asking for a Webservices API for Geeklog. We decided to tackle this in a two-layer approach. There won't be many Geeklog-specific clients for this API (initially or ever), so the API needs to be able to make the best of what it gets. So when a client sends something like "Hey, I've got a title and some text, and I think this should become a story" then we won't usually get all the permissions, comment, trackback, featured article, and other settings that Geeklog has with that. So we need to accept as little as makes sense and come up with reasonable defaults for the rest. Since only, say, the static pages plugin can know what the defaults for a new static page are, we need a way to tell it just that: Here's something that should become a static page - please fill in the rest. So we came up with what has come to be called the "internal API". Effectively, it's a new plugin API function[2] PLG_invokeService($plugin, $verb, $input, $output, $svc_msg); $verb would be 'submit' for storing something, 'get' to retrieve something, etc. The webservices API then sits on top of that API and translates whatever protocol it's talking with the external client into calls of that function. The nice thing is that PLG_invokeService can also be used by any other add-on. To test this, I wrote a simple script (see attachment) that imports *.txt files from Geeklog's data directory as new static pages. Effectively, other than reading those files, all it does is $args = array( 'sp_id' => $id, 'sp_title' => $title, 'sp_content' => $content, 'gl_svc' => true ); $plg_ret = PLG_invokeService('staticpages', 'submit', $args, $output, $svc_msg); (where $id is the file's name, $title is the first line of text and $content is the rest of the file) Of course, if you have more information - permissions, whatever - that you want to use for the new static page, you can simply add them in the array. This is just to demonstrate the minimal example (actually, sp_id is also optional - it will create a numeric ID if it's missing). I can see this becoming VERY useful in writing import scripts and the like, e.g. to help migration from (and to) other CMS. For the actual webservices API, we settled on the Atom Publishing Protocol (APP or Atompub, for short), which is in the final stages of becoming an internet standard[3]. Clients are a bit rare (I have a sidebar extension for Firefox that I haven't got to work yet), but are beginning to look promising. For example, how about being able to mount [4] your Geeklog site as a file system? Of course, you could implement any other protocol on top of the internal API. Atompub is just flexible, new, and - well - fun :-) Okay, there's lots of work left to do. In CVS at this moment are the changes to the static pages plugin to implement the internal API (so the attached import script works with that). I also have Ramnath's changes to the stories and the comments (although the latter are possibly not quite working yet). And then there's the actual code for the webservices API that I haven't even looked at yet. Expect at least some of this to show up in CVS over the weekend. Everything that should support the webservices API will have to be rewritten to implement the internal API, of course. So that may be a bit of work in places, but I think it's worth it. Not only for the webservices API but also because the internal API makes so much more possible. I have 3 or 4 half-finished add-ons here that are just waiting for something like this ... At this point, I'd also be interested to hear from other plugin authors what they think about this. If the above sounded confusing, look at it this way: You only have to implement the plugin's equivalents of PLG_invokeService (which are several functions, one for each verb) and your plugin will be able to talk to an Atompub client - or any other client of any other protocol that somebody may come up with. How does that sound? Oh, and of course all the hard work was done by Ramnath. I only asked a few stupid questions on occasion and made him start over when I didn't like the outcome ;-) bye, Dirk P.S. And if you haven't noticed yet - we also have a new install script in CVS, thanks to Matt West. [1] [2] [3] [4] -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon -------------- next part -------------- A non-text attachment was scrubbed... Name: spimport.php.gz Type: application/x-gzip Size: 1986 bytes Desc: not available URL: From joe at ThrowingDice.com Fri Aug 10 21:21:21 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Fri, 10 Aug 2007 21:21:21 -0400 Subject: [geeklog-devel] About the "internal" and Webservices APIs In-Reply-To: <20070810203456.1283526497@smtp.haun-online.de> References: <20070810203456.1283526497@smtp.haun-online.de> Message-ID: <0JML0076E53V4YD0@mta5.srv.hcvlny.cv.net> At 04:34 PM 8/10/2007, you wrote: > PLG_invokeService($plugin, $verb, $input, $output, $svc_msg); Ignoring security for a moment, is it feasible to turn your plugin's index.php into essentially this: include '../lib-common.php'; $mode = myplugin_scrub_mode($_REQUEST['mode']); // Or at least assume scrub is all the security needed. $A = myplugin_scrub_request($_REQUEST); $display = ''; $error = ''; echo COM_siteHeader($mode.'_title']); $ret = PLG_invokeService('myplugin',$mode, $A, $display, $error); if ($ret == PLG_RET_OK) { echo myplugin_xml2html($display); // is the XML? } else { echo $error; // how about this? } echo COM_siteFooter(); Getting back to security, does the webservice API do any scrubbing before calling the PLG_invokeService call? ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From oliver at spiesshofer.com Fri Aug 10 21:40:51 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Sat, 11 Aug 2007 09:40:51 +0800 Subject: [geeklog-devel] About the "internal" and Webservices APIs In-Reply-To: <20070810203456.1283526497@smtp.haun-online.de> References: <20070810203456.1283526497@smtp.haun-online.de> Message-ID: <46BD13A3.6020607@spiesshofer.com> Dirk, this all sounds very exciting, I have been wanting something like this for quite a while. It reminds me of a feature request for stories I did once where I asked if we could not have templates saved for special purposes. This sounds like another application of templates. Of course, one could save the HTML as a textfile somewhere, but a template would be better. And of course, someone could go to the last story that looked the way it is supposed to look, but then you have to search which is annoying. And all the permissions etc would not be saved. 1. stories: A lot of pages have recurring topics, articles about the same thing. If those articles looked similar, it would be easier if one could have the HTML of the article handy. 2. Calendar: Recurring events with a html structure that lists the even details etc etc there is so much where this could help. We would not even need another table for it, just a flag in the table which tells what is a template and exclude them from appearing online (like the draft-flag) and list them separately. There could also then be a special template for the web-api. Oliver Dirk Haun wrote: > Ramnath will be offline for a couple of days. In the meantime, I'm going > through the code he provided so far to see what's ready to go into CVS > and what's not there yet. > > In case you don't know or remember, the task[1] from the Google Summer > of Code was asking for a Webservices API for Geeklog. > > We decided to tackle this in a two-layer approach. There won't be many > Geeklog-specific clients for this API (initially or ever), so the API > needs to be able to make the best of what it gets. So when a client > sends something like "Hey, I've got a title and some text, and I think > this should become a story" then we won't usually get all the > permissions, comment, trackback, featured article, and other settings > that Geeklog has with that. So we need to accept as little as makes > sense and come up with reasonable defaults for the rest. > > Since only, say, the static pages plugin can know what the defaults for > a new static page are, we need a way to tell it just that: Here's > something that should become a static page - please fill in the rest. > > So we came up with what has come to be called the "internal API". > Effectively, it's a new plugin API function[2] > > PLG_invokeService($plugin, $verb, $input, $output, $svc_msg); > > $verb would be 'submit' for storing something, 'get' to retrieve > something, etc. > > The webservices API then sits on top of that API and translates whatever > protocol it's talking with the external client into calls of that function. > > The nice thing is that PLG_invokeService can also be used by any other > add-on. To test this, I wrote a simple script (see attachment) that > imports *.txt files from Geeklog's data directory as new static pages. > Effectively, other than reading those files, all it does is > > $args = array( > 'sp_id' => $id, > 'sp_title' => $title, > 'sp_content' => $content, > 'gl_svc' => true > ); > > $plg_ret = PLG_invokeService('staticpages', 'submit', $args, > $output, $svc_msg); > > (where $id is the file's name, $title is the first line of text and > $content is the rest of the file) > > Of course, if you have more information - permissions, whatever - that > you want to use for the new static page, you can simply add them in the > array. This is just to demonstrate the minimal example (actually, sp_id > is also optional - it will create a numeric ID if it's missing). > > I can see this becoming VERY useful in writing import scripts and the > like, e.g. to help migration from (and to) other CMS. > > > For the actual webservices API, we settled on the Atom Publishing > Protocol (APP or Atompub, for short), which is in the final stages of > becoming an internet standard[3]. Clients are a bit rare (I have a > sidebar extension for Firefox that I haven't got to work yet), but are > beginning to look promising. For example, how about being able to mount > [4] your Geeklog site as a file system? > > Of course, you could implement any other protocol on top of the internal > API. Atompub is just flexible, new, and - well - fun :-) > > > Okay, there's lots of work left to do. In CVS at this moment are the > changes to the static pages plugin to implement the internal API (so the > attached import script works with that). I also have Ramnath's changes > to the stories and the comments (although the latter are possibly not > quite working yet). And then there's the actual code for the webservices > API that I haven't even looked at yet. Expect at least some of this to > show up in CVS over the weekend. > > Everything that should support the webservices API will have to be > rewritten to implement the internal API, of course. So that may be a bit > of work in places, but I think it's worth it. Not only for the > webservices API but also because the internal API makes so much more > possible. I have 3 or 4 half-finished add-ons here that are just waiting > for something like this ... > > At this point, I'd also be interested to hear from other plugin authors > what they think about this. If the above sounded confusing, look at it > this way: You only have to implement the plugin's equivalents of > PLG_invokeService (which are several functions, one for each verb) and > your plugin will be able to talk to an Atompub client - or any other > client of any other protocol that somebody may come up with. How does > that sound? > > Oh, and of course all the hard work was done by Ramnath. I only asked a > few stupid questions on occasion and made him start over when I didn't > like the outcome ;-) > > bye, Dirk > > P.S. And if you haven't noticed yet - we also have a new install script > in CVS, thanks to Matt West. > > > [1] > [2] Webservices_API#Relation_of_the_Webse > rvices_component_with_the_rest_of_Geeklog> > [3] > [4] > > > > ------------------------------------------------------------------------ > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > From dirk at haun-online.de Sat Aug 11 04:22:34 2007 From: dirk at haun-online.de (Dirk Haun) Date: Sat, 11 Aug 2007 10:22:34 +0200 Subject: [geeklog-devel] About the "internal" and Webservices APIs In-Reply-To: <0JML0076E53V4YD0@mta5.srv.hcvlny.cv.net> References: <20070810203456.1283526497@smtp.haun-online.de> <0JML0076E53V4YD0@mta5.srv.hcvlny.cv.net> Message-ID: <20070811082234.1150509600@smtp.haun-online.de> Joe Mucchiello wrote: >$ret = PLG_invokeService('myplugin',$mode, $A, $display, $error); For the (end-user visble) index.php, I would assume that you'd only allow the 'get' verb here. >Getting back to security, does the webservice API do any scrubbing >before calling the PLG_invokeService call? No. Security is effectively done behind the PLG_invokeService call, in the plugin. The webservices API doesn't know anything about the plugin's idea of security - and how could it? I would assume it's doing some scrubbing but only as far as the protocol (e.g. Atompub) is concerned. bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From dirk at haun-online.de Sat Aug 11 04:25:27 2007 From: dirk at haun-online.de (Dirk Haun) Date: Sat, 11 Aug 2007 10:25:27 +0200 Subject: [geeklog-devel] About the "internal" and Webservices APIs In-Reply-To: <46BD13A3.6020607@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> Message-ID: <20070811082527.1325621733@smtp.haun-online.de> Oliver Spiesshofer wrote: >This sounds like another application of templates. Of course, one could >save the HTML as a textfile somewhere, but a template would be better. I would assume that is just something that sits on top of PLG_invokeService? Actually, it's something that could be done on the (webservice) client side - apply the template locally before sending the formatted story to your Geeklog site. bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From oliver at spiesshofer.com Sat Aug 11 05:20:03 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Sat, 11 Aug 2007 17:20:03 +0800 Subject: [geeklog-devel] About the "internal" and Webservices APIs In-Reply-To: <20070811082527.1325621733@smtp.haun-online.de> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> Message-ID: <46BD7F43.6020209@spiesshofer.com> Dirk Haun wrote: >> This sounds like another application of templates. Of course, one could >> save the HTML as a textfile somewhere, but a template would be better. >> > I would assume that is just something that sits on top of > PLG_invokeService? Actually, it's something that could be done on the > (webservice) client side - apply the template locally before sending the > formatted story to your Geeklog site. > I am not sure what you mean. I simply would have some page saved as a "template webservices", with default content, rights etc and the webservices, on incoming content simply take that such named template and append the content that comes in to it and save it as a new static page, with a new ID. There would be such templates for all kind of occasions and plugins, to be used by webservices or for birthdays or whatever. Its like those template files you can use in Office softwares... Oliver From joe at ThrowingDice.com Sat Aug 11 10:25:44 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 11 Aug 2007 10:25:44 -0400 Subject: [geeklog-devel] About the "internal" and Webservices APIs In-Reply-To: <46BD7F43.6020209@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> Message-ID: <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> At 05:20 AM 8/11/2007, Oliver Spiesshofer wrote: >I am not sure what you mean. I simply would have some page saved as >a "template webservices", with default content, rights etc >and the webservices, on incoming content simply take that such named >template and append the content that comes in to it and save it as a >new static page, with a new ID. I don't think you are explaining yourself well. There is nothing about webservices that makes having templates better or worse. Webservices are orthogonal to having templates. Your first example of story templates is a great idea regardless of whether Geeklog has or doesn't have webservices. IOW, it would be nice for the story editor to take the submitted story and click a dropdown containing "existing story templates". He selects a template appropriate to the story and magically the story text is merged with the template and now this story about cows looks like all the other stories about cows. Or in this case, all livejournal submitted stories look like other livejournal stories. >There would be such templates for all kind of occasions and plugins, >to be used by webservices or for birthdays or whatever. Right, but is there some reason you are linking this idea to webservices? ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From oliver at spiesshofer.com Sat Aug 11 10:52:36 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Sat, 11 Aug 2007 22:52:36 +0800 Subject: [geeklog-devel] About the "internal" and Webservices APIs In-Reply-To: <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> Message-ID: <46BDCD34.8030307@spiesshofer.com> Joe Mucchiello wrote: > He selects a template appropriate to the story and magically the story > text is merged with the template and now this story about cows looks > like all the other stories about cows. Or in this case, all > livejournal submitted stories look like other livejournal stories. that sounds nice but I guess there is no programming skill around here to do that magic. I was more thinking about a template that is loaded first and you fill in the text into the placeholders. >> There would be such templates for all kind of occasions and plugins, >> to be used by webservices or for birthdays or whatever. > Right, but is there some reason you are linking this idea to webservices? when the webservices are receiving content from a cellphone, blogger API or whatever else, they automatically select the "webservices" template and fill the text into it. this ensures that the permissions are correct and the layout is also done. Oliver From joe at ThrowingDice.com Sat Aug 11 11:04:04 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 11 Aug 2007 11:04:04 -0400 Subject: [geeklog-devel] About the "internal" and Webservices APIs In-Reply-To: <46BDCD34.8030307@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> Message-ID: <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> At 10:52 AM 8/11/2007, Oliver Spiesshofer wrote: >that sounds nice but I guess there is no programming skill around >here to do that magic. I was more thinking about a template that is >loaded first and you fill in the text into the placeholders. So are you saying you want to modify stories (and whatever else) so that instead of submitting "intro" and "bodytext" as giant blobs, the user is given a list of fields to enter responses into and the story is generated like a Mad Lib[1] only hopefully more seriously? Is that what templates would do? If so, you want my dynamic forms plugin which I'm now not working on in favor of the calendar bounty. But I expect to finish dynamic forms early next year. Joe [1] http://en.wikipedia.org/wiki/Mad_Libs ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From oliver at spiesshofer.com Sat Aug 11 11:26:23 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Sat, 11 Aug 2007 23:26:23 +0800 Subject: [geeklog-devel] About the "internal" and Webservices APIs In-Reply-To: <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> Message-ID: <46BDD51F.8000200@spiesshofer.com> Naaaa..... I think much more basic. check out my site. http://tokyoahead.com all my articles look the same: this is the header:
[image1]text text text
this is the content: [ repeats ]
[image2][image3][image4]
text text text
since they are always the same, I do not want to type that in everytime. I could store that in a textfile on my computer, or go to an older story and copy it into a new story. But since I always move the images around after uploading, it becomes a headache. I want to have that text prefilled in new stories with space for 30 images. And for my company, we have stories to announce news and some to introduce new employees. they have a specific layout that people do not want to recreate each time, and searching it among the old stories and then cop-pasting it is a nuisance. So imagine this: when you open you stories-admin-page you do not only see one list of stories, but two. One with templates and one with the actually published stories. When you open one of the templates, it will open the story-editor with all the fields prefilled: header, content, archive settings, user rights. you just have to write the text and do not care about the layout since it is already there. Now when the Webservices API comes and gets content from the outside, it does not know what kind of permissions to use and what archive settings to have (currently). With templates, you could assign one of the templates as the default webservices template. This would automatically use one of the access-rights etc settings and fill the text into the header and content by a certain rule such as [header: text text] and [content: text text] or such. this would solve the issue that Dirk mentioned: the webservice does not provide info about permissions etc. They have found a solution as it seems but I think the templates can do the same to a certain extent at least and also fulfill other requirements. Oliver Joe Mucchiello wrote: > At 10:52 AM 8/11/2007, Oliver Spiesshofer wrote: >> that sounds nice but I guess there is no programming skill around >> here to do that magic. I was more thinking about a template that is >> loaded first and you fill in the text into the placeholders. > > So are you saying you want to modify stories (and whatever else) so > that instead of submitting "intro" and "bodytext" as giant blobs, the > user is given a list of fields to enter responses into and the story > is generated like a Mad Lib[1] only hopefully more seriously? Is that > what templates would do? If so, you want my dynamic forms plugin which > I'm now not working on in favor of the calendar bounty. But I expect > to finish dynamic forms early next year. > > Joe > > [1] http://en.wikipedia.org/wiki/Mad_Libs From joe at ThrowingDice.com Sat Aug 11 12:53:14 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 11 Aug 2007 12:53:14 -0400 Subject: [geeklog-devel] About the "internal" and Webservices APIs In-Reply-To: <46BDD51F.8000200@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> Message-ID: <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> At 11:26 AM 8/11/2007, Oliver Spiesshofer wrote: >this is the header: > > > >
[image1]text text text
> >this is the content: > > > > >[ repeats ] >
[image2][image3][image4]
text text text
Couldn't this be easily done using the existing template code. Just add something like this to SP_renderArticle(): if( !empty( $bodytext )) { //... } if (!empty($_CONF['global_template'])) { // or however you want to find the template $T = new Template($_CONF['path_global_templates']); $T->set_file('data',$_CONF['global_template']); $T->set_var('intro_text',$intro_text); $T->set_var('body_text',$body_text); /// etc $templated_text = $T->finish($T->parse('output','data')); } else { $templated_text = $introtext . $bodytext; } Then your normal template just includes {templated_text} where you want to show the templated version. Everything else is just interface. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From dirk at haun-online.de Sat Aug 11 13:06:04 2007 From: dirk at haun-online.de (Dirk Haun) Date: Sat, 11 Aug 2007 19:06:04 +0200 Subject: [geeklog-devel] Webservices API in CVS (was: About the "internal" and Webservices APIs) In-Reply-To: <20070810203456.1283526497@smtp.haun-online.de> References: <20070810203456.1283526497@smtp.haun-online.de> Message-ID: <20070811170604.613332147@smtp.haun-online.de> Dirk Haun wrote: >Clients are a bit rare (I have a >sidebar extension for Firefox that I haven't got to work yet) Okay, it's still a bit wobbly, but I just managed to edit an existing static page as well as create a new one via the Webservices API and the Firefox extension, so I decided to add it to CVS. Try installing the Firefox extension from (ignore the "Atomojo Server"). Once installed, you can call it up from the menu: View -> Sidebar -> Atomic. It will ask you for a name for the configuration, your username and password as well as an introspection URL. Use http://www.example.com/webservices/atom/?introspection It should try to connect to your site, picking up the site's name and eventually display the well-known orange feed icon with the word "Entries" next to it. Double-click that. A new window opens, listing your existing static pages. You should be able to edit and create static pages from there. As I said, it's a bit wobbly - and that includes the Firefox extension itself which sometimes just doesn't seem to respond any more. In that case, try closing and re-opening the sidebar. After saving a page, you'll also get an XML error. When creating a new page, that's a bug in the Webservices API, I think, which is supposed to return the new element but currently doesn't. When modifying a page, however, I think the bug is in the FF extension, since in that case no XML is being sent (only a "200 OK" response). Anyway, that should give you something to play with. If you find any other Atompub clients, please post about them here. And I would be interested if anyone could get that Atompub filesystem[1] working (I couldn't even get it to install ...). bye, Dirk [1] -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From dirk at haun-online.de Sat Aug 11 13:31:09 2007 From: dirk at haun-online.de (Dirk Haun) Date: Sat, 11 Aug 2007 19:31:09 +0200 Subject: [geeklog-devel] Webservices API in CVS In-Reply-To: <20070811170604.613332147@smtp.haun-online.de> References: <20070810203456.1283526497@smtp.haun-online.de> <20070811170604.613332147@smtp.haun-online.de> Message-ID: <20070811173109.2131306773@smtp.haun-online.de> If you're getting a note about an undefined function: service_getTopicList_staticpages() in plugins/staticpages/ services.inc.php is calling a function COM_topicArray(). Not sure where that's coming from - I don't have the code for such a function. Just comment it out or update from CVS again. Also, I forgot to point out that the Webservices API requires PHP 5. We should probably add a check for that somewhere ... bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From oliver at spiesshofer.com Sat Aug 11 13:47:31 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Sun, 12 Aug 2007 01:47:31 +0800 Subject: [geeklog-devel] About the "internal" and Webservices APIs In-Reply-To: <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> Message-ID: <46BDF633.3050509@spiesshofer.com> Joe, To write the whole thing, you should store several templates in the database to accommodate different purposes for each content type, and make a template-flag in the database to store them, so you need code to upgrade the plugins and the stories tables. You would need a list-function that allows the creator of content to choose from several templates, so you need to rewrite the list-function of each plugin, the edit-code, write a small documentation etc. Your code does something I could include in my site code, and it does the same as the simple textfile in which I currently store that text - but in a much more complicated way. But it is nothing that would ever see the core code of the next version. I am discussing here if it would be good to implement a new, simple but convenient feature, and if that would also help with the webservices API. That would however, despite being easy, include more than 10 lines of code. I rather assume about a full day work once you include it into all plugins and do it with a proper interface, upgrade functions, testing etc. I am not discussing if its difficult, I rather discuss if its worth it before sitting down and doing all the work instead of doing a one-off hack that I would have to repeat every time a new version comes out. Please do not take what I write in the wrong way - I appreciate your readiness to always provide sample code for your explanations - but the discussion i wanted to start was about extending the gl functionality, not asking for help on how to write a small hack. Oliver Joe Mucchiello wrote: > Couldn't this be easily done using the existing template code. Just > add something like this to SP_renderArticle(): > > if( !empty( $bodytext )) > { > //... > } > > if (!empty($_CONF['global_template'])) { // or however you want to > find the template > $T = new Template($_CONF['path_global_templates']); > $T->set_file('data',$_CONF['global_template']); > $T->set_var('intro_text',$intro_text); > $T->set_var('body_text',$body_text); > /// etc > $templated_text = $T->finish($T->parse('output','data')); > } else { > $templated_text = $introtext . $bodytext; > } > > > Then your normal template just includes {templated_text} where you > want to show the templated version. Everything else is just interface. From joe at ThrowingDice.com Sat Aug 11 14:46:49 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 11 Aug 2007 14:46:49 -0400 Subject: [geeklog-devel] Story Templates (was Re: About the "internal" and Webservices APIs) In-Reply-To: <46BDF633.3050509@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> Message-ID: <0JMM00JQTHID4T20@mta3.srv.hcvlny.cv.net> At 01:47 PM 8/11/2007, Oliver Spiesshofer wrote: >Joe, > >To write the whole thing, you should store several templates in the >database to accommodate different purposes for each content type, >and make a template-flag in the database to store them, so you need >code to upgrade the plugins and the stories tables. You would need a >list-function that allows the creator of content to choose from >several templates, so you need to rewrite the list-function of each >plugin, the edit-code, write a small documentation etc. No, you should store control data in the database. The actual templates should be stored on the disk so you can use the existing template library to perform the variable substitutions. Geeklog has a template library. You are proposing adding templates to objects. Why wouldn't you use the existing template library? >Your code does something I could include in my site code, and it >does the same as the simple textfile in which I currently store that >text - but in a much more complicated way. But it is nothing that >would ever see the core code of the next version. Actually, I don't think anything but stories needs your templates and thus would prefer my version over a huge plugin interface. But besides that, ultimately my 10 lines of code are the core of your proposal. Everything else is just gloss. Selecting which template goes with the story is a dropdown in the story editor. Remember the first line of my code was commented "or however you want to find the template". You want to put the filename in the database. Have fun. That table only needs a few fields "name", "filename", perms (optional), maybe a hits counter. The story table gets a template field that holds the name. >I am discussing here if it would be good to implement a new, simple >but convenient feature, and if that would also help with the webservices API. I still see no connection here to webservices. But that's not really important. >Please do not take what I write in the wrong way - I appreciate your >readiness to always provide sample code for your explanations - but >the discussion i wanted to start was about extending the gl >functionality, not asking for help on how to write a small hack. Fine. I've already said I don't think it needs to be a global function and should be limited to stories. Here's why: polls, links and calendar objects are already very modular in the database and modifying their thtml files should be enough to handle just about anything you want to do with them. Stories only need it because the introtext/bodytext has no structure. Comments certainly don't need it. Staticpages might find it useful. But still, that's only two places it could be used and since one is a plugin and one isn't, a plugin API is not optimal here. (When will stories become a plugin? A rant for a different time. Just think though how much special code exists in the core to handle stories with them being a plugin that could go away.) Why not write this idea as a plugin? It would work exactly like the Ratings plugin. You use PLG_templatesetvars and PLG_saveItem to hook the story and staticpage editor screens. The user has to add {template_options} to the appropriate thtml files. Your database table is "cid, templatename". When PLG_templatesetvars is called for viewing stories or staticpages. You run my 10 lines of code against $T->get_var('body_text') and call $T->set_var('body_text') with the result. Those of us out here is user land have to do things this way. Just because you have CVS access doesn't mean you should just checkin anything you feel like. I'm not saying you do that Oliver, I'm just saying there is nothing about your proposal that makes it better than the ratings plugin. But the ratings plugin isn't supported by core and every upgrade people using that plugin have to put that ratings_option tag into every thtml file they want ratings to exist in. (OOo, an idea. See next email...) So while porting a hack from version to version can be difficult, porting an extension from version to version is just annoying. But your proposal isn't any more core-worthy than the ratings plugin, really. I should move this to another thread but I'm lazy. This is not really directed at Oliver but at the whole core team. Where is the Geeklog roadmap? How are decisions about adding core functionality made? Is there a list of projects for 1.4.2? 1.4.3? 1.5? Is there any architectural guidance? Should Oliver write his idea into the core or should he write a plugin? Who decides? Roadmaps are prominently displayed on most OSS webpages. Geeklog's page is completely silent about it. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From joe at ThrowingDice.com Sat Aug 11 14:54:37 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 11 Aug 2007 14:54:37 -0400 Subject: [geeklog-devel] Proposal: Plugin vars in templates In-Reply-To: <46BDF633.3050509@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> Message-ID: <0JMM00M3RHVEFW20@mta5.srv.hcvlny.cv.net> This is a simple suggestion. The professional theme should be modified to add the following to just about every thtml file: {plg1}{plg2}{plg3}{plg4}{plg5} The location would be "at the end" but before any form buttons. Why? So plugins like the ratings plugin would work across version upgrades without necessitating that the user go in an modify their thtml files over and over again. In the plugin's config file would be a placeholder option: $_PLG_CONF['placeholder'] = 'plg3'; The user would be responsible for making sure each plugin requiring the placeholder service had a unique placeholder. Now when the template wanted to add itself to an existing page it would use $T->set_var($_PLG_CONF['placeholder'], $mycontent); to do so. As long as the user ensures the placeholders are unique, nothing stomps all over something else. About the only other change probably needed would be to add the following to the Template class' constructor. for ($i = 1 to 5) { set_var("plg$i", ''); } I'm sure folks using stuff like the Ratings plugin would find this helpful. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From joe at ThrowingDice.com Sat Aug 11 14:56:55 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 11 Aug 2007 14:56:55 -0400 Subject: [geeklog-devel] code scrubbing: stripslashes In-Reply-To: <20070811082234.1150509600@smtp.haun-online.de> References: <20070810203456.1283526497@smtp.haun-online.de> <0JML0076E53V4YD0@mta5.srv.hcvlny.cv.net> <20070811082234.1150509600@smtp.haun-online.de> Message-ID: <0JMM00H9DHZBRM30@mta2.srv.hcvlny.cv.net> [preamble]The list was quiet when I started writing this. But I don't want to put it off so....[/preamble] Well, I'm actively programming Geeklog again and so a bunch of my issues have risen again. Code cleanup returns. This is just one of several emails I'll send on this. I want to start with my favorite whipping boy: stripslashes. I propose a change to lib_common.php. Before everything else: ------------------- // since most installs leave magic quotes off, this is a no-op. if (get_magic_quotes_gpc() == 1) { $_POST = array_filter($_POST, 'stripslashes'); $_GET = array_filter($_GET, 'stripslashes'); $_COOKIE = array_filter($_COOKIE, 'stripslashes'); $_REQUEST = array_filter($_REQUEST, 'stripslashes'); } require_once( '/path/to/geeklog/config.php' ); ------------------- This makes COM_stripslashes become: ------------------- // DEPRECATED function COM_stripslashes($str) { return $str; } ------------------- Reducing the number of calls to get_magic_quotes_gpc() from who know how many to 1 should also be a slight speed boost. The hard part is removing all the calls directly to stripslashes(). The last time I brought this up, it seemed like such an impossible thing to go through everything and fix. This way, it doesn't seem so hard. There are 140 direct calls to stripslashes in CVS (as of about a week ago). That shouldn't be hard to remove. If I write a patch will someone apply it? ------------------- On the geeklog Wiki it gives this advice about stripslashes: http://wiki.geeklog.net/wiki/index.php/StripSlashes 1. When your code is to deal with a value from $_GET, $_POST or $_COOKIE immediately load it into an internal variable after calling COM_stripSlashes, this will deal correctly with the value whether or not Magic Quotes GPC is on or off. 2. Immediately before using a value in SQL, addslashes to it. 3. Immediately after loading a value from SQL, stripslashes on it. #3 will result in missing characters eventually. The addslashes in #2 gets the text into the database. No extra slashes are actually added to the text in the database. So when you fetch the data, it is already equal to what was sent to the database and by calling stripslashes you modify the original text unintentionally. Of course with the above changes most of the WIKI article should be removed and replaced with "DON'T CALL STRIPSLASHES." ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From oliver at spiesshofer.com Sat Aug 11 15:15:39 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Sun, 12 Aug 2007 03:15:39 +0800 Subject: [geeklog-devel] Story Templates (was Re: About the "internal" and Webservices APIs) In-Reply-To: <0JMM00JQTHID4T20@mta3.srv.hcvlny.cv.net> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> <0JMM00JQTHID4T20@mta3.srv.hcvlny.cv.net> Message-ID: <46BE0ADB.1060905@spiesshofer.com> Joe Mucchiello wrote: > Those of us out here is user land have to do things this way. Just > because you have CVS access doesn't mean you should just checkin > anything you feel like. I'm not saying you do that Oliver, I'm just > saying there is nothing about your proposal that makes it better than > the ratings plugin. sorry? I dont get your point. I put a featuer up for discussion, not entering into a comeptition with one you proposed some time ago. The fact that I discuss it means that I want other people s input. and this IS the gl_dev mailing list, in which core code is discussed... > But the ratings plugin isn't supported by core and every upgrade > people using that plugin have to put that ratings_option tag into > every thtml file they want ratings to exist in. (OOo, an idea. See > next email...) So while porting a hack from version to version can be > difficult, porting an extension from version to version is just > annoying. But your proposal isn't any more core-worthy than the > ratings plugin, really. again, this is not a competition. we simply have a misunderstanding on what my idea is supposed to do and what it is meant for, therefore any discussion about how to do it seems not really helpful as I know realize. > I should move this to another thread but I'm lazy. This is not really > directed at Oliver but at the whole core team. Where is the Geeklog > roadmap? How are decisions about adding core functionality made? Is > there a list of projects for 1.4.2? 1.4.3? 1.5? Is there any > architectural guidance? Should Oliver write his idea into the core or > should he write a plugin? Who decides? Roadmaps are prominently > displayed on most OSS webpages. Geeklog's page is completely silent > about it. to give you my very personal view on that, the others who are in the core team can confirm this or not. we are not a commercial operation. We are a group of people that got together to write code and publish it under the GPL. the people who are writing core code select, if necessary, among those who contribute to the code (with plugins, patches for example) with a certain quality new members to contribute to the code too. All others are free to fork the code and do the same by themselves, or criticize what the current core team is doing. but they should not expect that the current core team includes whatever they ask for. the core team is using GL for their own sites or even jobs. whatever time they spend on the code is usually to make their own interest in the code reality. If a proposal for a new feature aligns with the time, interest and abilities of one of the core coders, they probably implement that code. The relationship between being user-friendly and responsive to other users problems and demands is a mix between the individual's character and the hope that a more distributed program will attract more contributors of plugins and reveal insecurities and bugs. That is, however, the second level of importance. I have personally no interest in coding something that I do not use. And I have no interest in helping complete strangers with a code that I do not use. if i help them, its is only to strengthen the community. And since all our schedules are all quite full (dont ask me what my normal day job is), we have to set priorities in what we code and therefore our own interest is always a level above strengthening the community (= helping others, coding for them etc) in short words: if you want something implemented, you have to market it to the core coders so that they like the idea and do it. Or even provide a 100% finished patch towards the source code. Otherwise it will not become core code. In return, if a feature you want does not happen, it was not "sold" properly to the coders. We do not have a parliament that decides who's code comes first. We have a group of people with personal interests. a roadmap would only reflect that. It would not change what was implemented first. If I have an idea I write it in this list and often get a "What the hell?" and then do not do it. Other times I think its small and then just do it, and even then get a "what the hell" and remove it. In any other way I guess we would spend a LOT of time to come to an agreement what to do in the next 3 years of development anyhow. Oliver From oliver at spiesshofer.com Sat Aug 11 15:17:14 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Sun, 12 Aug 2007 03:17:14 +0800 Subject: [geeklog-devel] Proposal: Plugin vars in templates In-Reply-To: <0JMM00M3RHVEFW20@mta5.srv.hcvlny.cv.net> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> <0JMM00M3RHVEFW20@mta5.srv.hcvlny.cv.net> Message-ID: <46BE0B3A.9060500@spiesshofer.com> We should urgently take up the discussion again about the plugin vars... that has been sleeping for 6 month now or so... Oliver Joe Mucchiello wrote: > This is a simple suggestion. The professional theme should be modified > to add the following to just about every thtml file: > {plg1}{plg2}{plg3}{plg4}{plg5} > > The location would be "at the end" but before any form buttons. > > Why? So plugins like the ratings plugin would work across version > upgrades without necessitating that the user go in an modify their > thtml files over and over again. > > In the plugin's config file would be a placeholder option: > $_PLG_CONF['placeholder'] = 'plg3'; The user would be responsible for > making sure each plugin requiring the placeholder service had a unique > placeholder. Now when the template wanted to add itself to an existing > page it would use $T->set_var($_PLG_CONF['placeholder'], $mycontent); > to do so. As long as the user ensures the placeholders are unique, > nothing stomps all over something else. > > About the only other change probably needed would be to add the > following to the Template class' constructor. > > for ($i = 1 to 5) { set_var("plg$i", ''); } > > I'm sure folks using stuff like the Ratings plugin would find this > helpful. > > ---- > Joe Mucchiello > Throwing Dice Games > http://www.throwingdice.com > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > From oliver at spiesshofer.com Sat Aug 11 15:19:44 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Sun, 12 Aug 2007 03:19:44 +0800 Subject: [geeklog-devel] code scrubbing: stripslashes In-Reply-To: <0JMM00H9DHZBRM30@mta2.srv.hcvlny.cv.net> References: <20070810203456.1283526497@smtp.haun-online.de> <0JML0076E53V4YD0@mta5.srv.hcvlny.cv.net> <20070811082234.1150509600@smtp.haun-online.de> <0JMM00H9DHZBRM30@mta2.srv.hcvlny.cv.net> Message-ID: <46BE0BD0.5050506@spiesshofer.com> I do not know if there are implications doing this code to lib_common as proposed... any body else has an opinion on that? Oliver Joe Mucchiello wrote: > I propose a change to lib_common.php. Before everything else: > ------------------- > // since most installs leave magic quotes off, this is a no-op. > if (get_magic_quotes_gpc() == 1) { > $_POST = array_filter($_POST, 'stripslashes'); > $_GET = array_filter($_GET, 'stripslashes'); > $_COOKIE = array_filter($_COOKIE, 'stripslashes'); > $_REQUEST = array_filter($_REQUEST, 'stripslashes'); > } > > require_once( '/path/to/geeklog/config.php' ); > ------------------- > > This makes COM_stripslashes become: > ------------------- > // DEPRECATED > function COM_stripslashes($str) { return $str; } > ------------------- > > Reducing the number of calls to get_magic_quotes_gpc() from who know > how many to 1 should also be a slight speed boost. > > The hard part is removing all the calls directly to stripslashes(). > The last time I brought this up, it seemed like such an impossible > thing to go through everything and fix. This way, it doesn't seem so > hard. There are 140 direct calls to stripslashes in CVS (as of about a > week ago). That shouldn't be hard to remove. If I write a patch will > someone apply it? From kantai at gmail.com Sat Aug 11 15:30:15 2007 From: kantai at gmail.com (Aaron Blankstein) Date: Sat, 11 Aug 2007 15:30:15 -0400 Subject: [geeklog-devel] code scrubbing: stripslashes In-Reply-To: <46BE0BD0.5050506@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <0JML0076E53V4YD0@mta5.srv.hcvlny.cv.net> <20070811082234.1150509600@smtp.haun-online.de> <0JMM00H9DHZBRM30@mta2.srv.hcvlny.cv.net> <46BE0BD0.5050506@spiesshofer.com> Message-ID: <2a1a3bb50708111230i482f2716s80aa1d55d2a08ec@mail.gmail.com> Well first of all there would be a problem for any array variables. You need to do a stripslashes_deep somewhat like the example at http://us.php.net/manual/en/security.magicquotes.disabling.php (though the example itself won't strip slashes from array keys.) Also, anytime the function parse_str is used, it returns a magicquoted string. I don't know if its ever used in GL code, but it would have to be another consideration. Aaron On 8/11/07, Oliver Spiesshofer wrote: > > I do not know if there are implications doing this code to lib_common as > proposed... any body else has an opinion on that? > > Oliver > > Joe Mucchiello wrote: > > I propose a change to lib_common.php. Before everything else: > > ------------------- > > // since most installs leave magic quotes off, this is a no-op. > > if (get_magic_quotes_gpc() == 1) { > > $_POST = array_filter($_POST, 'stripslashes'); > > $_GET = array_filter($_GET, 'stripslashes'); > > $_COOKIE = array_filter($_COOKIE, 'stripslashes'); > > $_REQUEST = array_filter($_REQUEST, 'stripslashes'); > > } > > > > require_once( '/path/to/geeklog/config.php' ); > > ------------------- > > > > This makes COM_stripslashes become: > > ------------------- > > // DEPRECATED > > function COM_stripslashes($str) { return $str; } > > ------------------- > > > > Reducing the number of calls to get_magic_quotes_gpc() from who know > > how many to 1 should also be a slight speed boost. > > > > The hard part is removing all the calls directly to stripslashes(). > > The last time I brought this up, it seemed like such an impossible > > thing to go through everything and fix. This way, it doesn't seem so > > hard. There are 140 direct calls to stripslashes in CVS (as of about a > > week ago). That shouldn't be hard to remove. If I write a patch will > > someone apply it? > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From dirk at haun-online.de Sat Aug 11 15:53:14 2007 From: dirk at haun-online.de (Dirk Haun) Date: Sat, 11 Aug 2007 21:53:14 +0200 Subject: [geeklog-devel] Link back from plugin comments? In-Reply-To: <8319e2d60708091406s4f65fa2fje485111e7f95d231@mail.gmail.com> References: <20070809191757.1838430708@smtp.haun-online.de> <8319e2d60708091230p234807ccpa0e8b2189e1f4714@mail.gmail.com> <20070809194354.1261645246@smtp.haun-online.de> <8319e2d60708091406s4f65fa2fje485111e7f95d231@mail.gmail.com> Message-ID: <20070811195314.2138421597@smtp.haun-online.de> Vincent Furia wrote: >You do need the plugin function >plugin_getcommenturlid_ or else it assumes the location is >geeklog_url/plugin_name/index.php?id=XXX. > >The template variable that gets filled out is: story_link Okay, that's (at least) two problems here then: 1) None of our plugins implement that function. 2) None of the templates contain a {story_link} variable. I see there's a note about {story_link} in the changelog - for 1.3.10rc1. Looks like it got lost in a later update. It also looks like the link back to a story doesn't work in CVS either, so at least that's consistent now. Consistently wrong, but still ... :-/ In 1.4.1, in commentbar.thtml, we had {start_storylink_anchortag}{story_title}{end_storylink_anchortag} In CVS, that's only {story_title} now. Changing it back to the above, however, displays the story title twice. *sigh* bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From joe at ThrowingDice.com Sat Aug 11 16:02:27 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 11 Aug 2007 16:02:27 -0400 Subject: [geeklog-devel] code scrubbing: stripslashes In-Reply-To: <2a1a3bb50708111230i482f2716s80aa1d55d2a08ec@mail.gmail.com> References: <20070810203456.1283526497@smtp.haun-online.de> <0JML0076E53V4YD0@mta5.srv.hcvlny.cv.net> <20070811082234.1150509600@smtp.haun-online.de> <0JMM00H9DHZBRM30@mta2.srv.hcvlny.cv.net> <46BE0BD0.5050506@spiesshofer.com> <2a1a3bb50708111230i482f2716s80aa1d55d2a08ec@mail.gmail.com> Message-ID: <0JMM009ZEL0GAHR0@mta2.srv.hcvlny.cv.net> At 03:30 PM 8/11/2007, Aaron Blankstein wrote: >Well first of all there would be a problem for any array variables. >You need to do a stripslashes_deep somewhat like the example at >http://us.php.net/manual/en/security.magicquotes.disabling.php >(though the example itself won't strip slashes from array keys.) >Also, anytime the function parse_str is used, it returns a >magicquoted string. I don't know if its ever used in GL code, but it >would have to be another consideration. Dang, you are right. I forgot about arrays. It would need to use array_walk_recursive in some manner. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From joe at ThrowingDice.com Sat Aug 11 16:07:48 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 11 Aug 2007 16:07:48 -0400 Subject: [geeklog-devel] Proposal: Plugin vars in templates In-Reply-To: <46BE0B3A.9060500@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> <0JMM00M3RHVEFW20@mta5.srv.hcvlny.cv.net> <46BE0B3A.9060500@spiesshofer.com> Message-ID: <0JMM00IPKL9CHP20@mta1.srv.hcvlny.cv.net> Heck, I'd given up on that months ago. I've been trying to embrace the PLG_tamplatesetvars version. It works but it feels very kludgy. This proposal though is kind of orthogonal to the original plugin vars discussion. The original discussion involved having plugin functions for data state changes: to editor, to display, and to database. I'd still like to see a cleaner interface. In fact, that set of interfaces probably works well in conjunction with (or parallel to) the webservices API. At 03:17 PM 8/11/2007, Oliver Spiesshofer wrote: >We should urgently take up the discussion again about the plugin >vars... that has been sleeping for 6 month now or so... ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From dirk at haun-online.de Sat Aug 11 16:05:49 2007 From: dirk at haun-online.de (Dirk Haun) Date: Sat, 11 Aug 2007 22:05:49 +0200 Subject: [geeklog-devel] Link back from plugin comments? In-Reply-To: <20070811195314.2138421597@smtp.haun-online.de> References: <20070809191757.1838430708@smtp.haun-online.de> <8319e2d60708091230p234807ccpa0e8b2189e1f4714@mail.gmail.com> <20070809194354.1261645246@smtp.haun-online.de> <8319e2d60708091406s4f65fa2fje485111e7f95d231@mail.gmail.com> <20070811195314.2138421597@smtp.haun-online.de> Message-ID: <20070811200549.751858068@smtp.haun-online.de> Dirk Haun wrote: >In CVS, that's only {story_title} now. Changing it back to the above, >however, displays the story title twice. That's because {start_storylink_anchortag} now contains a complete link instead of only the opening tag, as the name suggests ... And speaking of comments: Anonymous comments now display as Authored by: on ... i.e. without the "Anonymous". Unless you're looking at them via their permalink, then it's Authored by: {author_link} on ... *more sighs* bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From oliver at spiesshofer.com Sat Aug 11 16:21:20 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Sun, 12 Aug 2007 04:21:20 +0800 Subject: [geeklog-devel] Link back from plugin comments? In-Reply-To: <20070811195314.2138421597@smtp.haun-online.de> References: <20070809191757.1838430708@smtp.haun-online.de> <8319e2d60708091230p234807ccpa0e8b2189e1f4714@mail.gmail.com> <20070809194354.1261645246@smtp.haun-online.de> <8319e2d60708091406s4f65fa2fje485111e7f95d231@mail.gmail.com> <20070811195314.2138421597@smtp.haun-online.de> Message-ID: <46BE1A40.9050107@spiesshofer.com> i will fix that. Dirk Haun wrote: > In 1.4.1, in commentbar.thtml, we had > > {start_storylink_anchortag}{story_title}{end_storylink_anchortag} > > In CVS, that's only {story_title} now. Changing it back to the above, > however, displays the story title twice. > > *sigh* > > bye, Dirk > > > From vfuria at gmail.com Sat Aug 11 18:38:23 2007 From: vfuria at gmail.com (Vincent Furia) Date: Sat, 11 Aug 2007 16:38:23 -0600 Subject: [geeklog-devel] Link back from plugin comments? In-Reply-To: <46BE1A40.9050107@spiesshofer.com> References: <20070809191757.1838430708@smtp.haun-online.de> <8319e2d60708091230p234807ccpa0e8b2189e1f4714@mail.gmail.com> <20070809194354.1261645246@smtp.haun-online.de> <8319e2d60708091406s4f65fa2fje485111e7f95d231@mail.gmail.com> <20070811195314.2138421597@smtp.haun-online.de> <46BE1A40.9050107@spiesshofer.com> Message-ID: <8319e2d60708111538rf7a0109y5d79a05ce4df9ff@mail.gmail.com> Let me know if you need any help. I know that code in there pretty well. -Vinny On 8/11/07, Oliver Spiesshofer wrote: > i will fix that. > > Dirk Haun wrote: > > In 1.4.1, in commentbar.thtml, we had > > > > {start_storylink_anchortag}{story_title}{end_storylink_anchortag} > > > > In CVS, that's only {story_title} now. Changing it back to the above, > > however, displays the story title twice. > > > > *sigh* > > > > bye, Dirk > > > > > > > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > From joe at ThrowingDice.com Sat Aug 11 18:52:12 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 11 Aug 2007 18:52:12 -0400 Subject: [geeklog-devel] Story Templates (was Re: About the "internal" and Webservices APIs) In-Reply-To: <46BE0ADB.1060905@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> <0JMM00JQTHID4T20@mta3.srv.hcvlny.cv.net> <46BE0ADB.1060905@spiesshofer.com> Message-ID: <0JMM00LMDSVDMXB0@mta5.srv.hcvlny.cv.net> At 03:15 PM 8/11/2007, Oliver Spiesshofer wrote: >sorry? I dont get your point. I put a featuer up for discussion, not >entering into a comeptition with one you proposed some time ago. The >fact that I discuss it means that I want other people s input. >and this IS the gl_dev mailing list, in which core code is discussed... My point was that the only reason you don't propose doing this as a plugin is you have CVS access. There's nothing important about making story templates a core function. It's not an indictment; it's an observation. I would prefer that geeklog core was streamlined and just about everything was a plugin. Stories, topics, comments, all of it, out. (Yeah, I should just jump to GL2, right? That's a different issue.) What did I propose some time ago that you are referring to? I'm not talking about any prior work of mine. I'm just pointing out that your idea in my opinion is not needed in the core of GL. Since this is the mailing list in which core is discussed and I'm a member of the list, I'm discussing it. >>But the ratings plugin isn't supported by core and every upgrade >>people using that plugin have to put that ratings_option tag into >>every thtml file they want ratings to exist in. (OOo, an idea. See >>next email...) So while porting a hack from version to version can >>be difficult, porting an extension from version to version is just >>annoying. But your proposal isn't any more core-worthy than the >>ratings plugin, really. >again, this is not a competition. we simply have a misunderstanding >on what my idea is supposed to do and what it is meant for, >therefore any discussion about how to do it seems not really helpful >as I know realize. You are looking to provide templates that will cause stories entered at different times by different authors to share a similar look and feel. Some story types may have different looks but all stories of the same type should be uniform. This isn't rocket science. I'm just saying you can accomplish this with the existing template library and a few well placed calls. I'm also saying that other than stories and staticpages, there's not much other need for this templating system. And I'm saying that you can do this through the plugin API without modifying core. Have I missed something? I've seen the forum posts requesting such a feature and I believe it use to be in the bug tracker/feature requests. (Another planning tool missing.) Still, doing it as a plugin means sites that don't use it aren't burdened by the additional runtime if'ing around the code. >>I should move this to another thread but I'm lazy. This is not >>really directed at Oliver but at the whole core team. Where is the >>Geeklog roadmap? How are decisions about adding core functionality >>made? Is there a list of projects for 1.4.2? 1.4.3? 1.5? Is there >>any architectural guidance? Should Oliver write his idea into the >>core or should he write a plugin? Who decides? Roadmaps are >>prominently displayed on most OSS webpages. Geeklog's page is >>completely silent about it. >to give you my very personal view on that, the others who are in the >core team can confirm this or not. we are not a commercial operation. There's no reason why a non-commercial group cannot plan ahead. Most OSS projects have Roadmaps. Most OSS are not commercial operations. Roadmaps are about planning. This goes back to the end of life for PHP4 and my comment when that was announced that GL should have an announcement that GL 1.5 will be PHP5 only. Or 1.4.2, or 1.4.3? Something. There should be a plan. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From devel at portalparts.com Sat Aug 11 21:08:18 2007 From: devel at portalparts.com (Blaine Lang) Date: Sat, 11 Aug 2007 21:08:18 -0400 Subject: [geeklog-devel] Webservices API in CVS In-Reply-To: <20070811173109.2131306773@smtp.haun-online.de> References: <20070810203456.1283526497@smtp.haun-online.de> <20070811170604.613332147@smtp.haun-online.de> <20070811173109.2131306773@smtp.haun-online.de> Message-ID: <46BE5D82.60208@portalparts.com> Hi Dirk, I like the generic API PLG_invokeService and agree that being generic it can be of use. Although, I think the full power of webservices would be seen if we did implement security and this is how it could be implemented: You send a "authenticate" verb with you username and password and get back a secure oid (object id) that is like the MD5 password field now. This is not something a hacker would easily get. Now once we have the oid, it would be passed in as a parm for all secure calls. RSS Feeds are great for public access data. But what if I wanted to have remote access to secure files or forum posts. Someone could post now to the forum as their userid. I think without security, all requests are anonymous and I'm trying to think of where this is better then the RSS feeds API. get list_forums get list_forum_topics post reply get new privatemessages get file (secure category) Blaine Dirk Haun wrote: > If you're getting a note about an undefined function: > service_getTopicList_staticpages() in plugins/staticpages/ > services.inc.php is calling a function COM_topicArray(). Not sure where > that's coming from - I don't have the code for such a function. > > Just comment it out or update from CVS again. > > Also, I forgot to point out that the Webservices API requires PHP 5. We > should probably add a check for that somewhere ... > > bye, Dirk > > > From devel at portalparts.com Sat Aug 11 21:09:05 2007 From: devel at portalparts.com (Blaine Lang) Date: Sat, 11 Aug 2007 21:09:05 -0400 Subject: [geeklog-devel] Proposal: Plugin vars in templates In-Reply-To: <46BE0B3A.9060500@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> <0JMM00M3RHVEFW20@mta5.srv.hcvlny.cv.net> <46BE0B3A.9060500@spiesshofer.com> Message-ID: <46BE5DB0.40801@portalparts.com> I don't see the need to add these generic template vars to all of our templates because there would likely just be confusion and collision when the ratings plugin uses {plg1} and myplugin uses {plg1}. A generic name is just confusing as to what is' being used for. The plugin API PLG_templateSetVars has been an excellent addition to GL and very flexible - granted you need to update a template to add the variable if it does not exist but it's not hard to distribute those updates or directions. If you don't have a plugin and want to use this feature which has been the case for me on a few projects, adding your code to CUSTOM_templateSetVars is straight forward and you can test for the template file you need to to set the new variables for. There just may be a few more places we want to add PLG_templateSetVars(); Blaine Oliver Spiesshofer wrote: > We should urgently take up the discussion again about the plugin > vars... that has been sleeping for 6 month now or so... > > Oliver > > Joe Mucchiello wrote: >> This is a simple suggestion. The professional theme should be >> modified to add the following to just about every thtml file: >> {plg1}{plg2}{plg3}{plg4}{plg5} >> >> The location would be "at the end" but before any form buttons. >> >> Why? So plugins like the ratings plugin would work across version >> upgrades without necessitating that the user go in an modify their >> thtml files over and over again. >> >> In the plugin's config file would be a placeholder option: >> $_PLG_CONF['placeholder'] = 'plg3'; The user would be responsible for >> making sure each plugin requiring the placeholder service had a >> unique placeholder. Now when the template wanted to add itself to an >> existing page it would use $T->set_var($_PLG_CONF['placeholder'], >> $mycontent); to do so. As long as the user ensures the placeholders >> are unique, nothing stomps all over something else. >> >> About the only other change probably needed would be to add the >> following to the Template class' constructor. >> >> for ($i = 1 to 5) { set_var("plg$i", ''); } >> >> I'm sure folks using stuff like the Ratings plugin would find this >> helpful. >> >> ---- >> Joe Mucchiello >> Throwing Dice Games >> http://www.throwingdice.com >> _______________________________________________ >> geeklog-devel mailing list >> geeklog-devel at lists.geeklog.net >> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >> >> > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > From joe at ThrowingDice.com Sat Aug 11 21:39:26 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 11 Aug 2007 21:39:26 -0400 Subject: [geeklog-devel] Proposal: Plugin vars in templates In-Reply-To: <46BE5DB0.40801@portalparts.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> <0JMM00M3RHVEFW20@mta5.srv.hcvlny.cv.net> <46BE0B3A.9060500@spiesshofer.com> <46BE5DB0.40801@portalparts.com> Message-ID: <0JMN00GWA0M3EED0@mta1.srv.hcvlny.cv.net> At 09:09 PM 8/11/2007, Blaine Lang wrote: >I don't see the need to add these generic template vars to all of >our templates because there would likely just be confusion and >collision when the ratings plugin uses {plg1} and myplugin uses >{plg1}. A generic name is just confusing as to what is' being used for. I provided a convention for handling this. It wouldn't be hard to explain. Worst case, the plugin writers should be encouraged to use set_var('plg1', $content, true). If all plugins do that, {plg1} can be used by multiple plugins. >The plugin API PLG_templateSetVars has been an excellent addition to >GL and very flexible - granted you need to update a template to add >the variable if it does not exist but it's not hard to distribute >those updates or directions. If you don't have a plugin and want to >use this feature which has been the case for me on a few projects, >adding your code to CUSTOM_templateSetVars is straight forward and >you can test for the template file you need to to set the new variables for. Asking admins to modify templates is inelegant. Granted, this is a band-aid but how does it really hurt add the fields. >There just may be a few more places we want to add PLG_templateSetVars(); There's really no place it shouldn't be called. Anywhere there's a final $T->parse(), there should probably be a call to PLG_templateSetVars just before it. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From devel at portalparts.com Sat Aug 11 22:09:49 2007 From: devel at portalparts.com (Blaine Lang) Date: Sat, 11 Aug 2007 22:09:49 -0400 Subject: [geeklog-devel] Proposal: Plugin vars in templates In-Reply-To: <0JMN00GWA0M3EED0@mta1.srv.hcvlny.cv.net> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> <0JMM00M3RHVEFW20@mta5.srv.hcvlny.cv.net> <46BE0B3A.9060500@spiesshofer.com> <46BE5DB0.40801@portalparts.com> <0JMN00GWA0M3EED0@mta1.srv.hcvlny.cv.net> Message-ID: <46BE6BED.6040301@portalparts.com> Joe Mucchiello wrote: > There's really no place it shouldn't be called. Anywhere there's a final $T->parse(), there should probably be a call to PLG_templateSetVars just before it. Not likely as we do not want to add the extra overhead of calling this plugin API and all the related plugin functions for every template and should be added where it's needed or makes sense. > I provided a convention for handling this. It wouldn't be hard to explain. Worst case, the plugin writers should be encouraged to use set_var('plg1', $content, true). If all plugins do that, {plg1} can be used by multiple plugins. Likely would not work when my cart plugin uses {plg1} to add a shopping cart feature and the ratings plugin or other wants to add a formatted table with voting buttons and messes up the layout of a story. I'd still want more control over the story template and want to use a {cart} template var. In the case of my cart plugin, I use an autotag anyways so the [cart] tag can be where the user wants it. In the case of the ratings plugin specifically, why not use a [ratings] autotag which the story author or forum post author can then use to add a formatted ratings block at the end of the story or in the middle. Not need then for a template variable. > At 09:09 PM 8/11/2007, Blaine Lang wrote: >> I don't see the need to add these generic template vars to all of our >> templates because there would likely just be confusion and collision >> when the ratings plugin uses {plg1} and myplugin uses {plg1}. A >> generic name is just confusing as to what is' being used for. > > I provided a convention for handling this. It wouldn't be hard to > explain. Worst case, the plugin writers should be encouraged to use > set_var('plg1', $content, true). If all plugins do that, {plg1} can be > used by multiple plugins. > >> The plugin API PLG_templateSetVars has been an excellent addition to >> GL and very flexible - granted you need to update a template to add >> the variable if it does not exist but it's not hard to distribute >> those updates or directions. If you don't have a plugin and want to >> use this feature which has been the case for me on a few projects, >> adding your code to CUSTOM_templateSetVars is straight forward and >> you can test for the template file you need to to set the new >> variables for. > > Asking admins to modify templates is inelegant. Granted, this is a > band-aid but how does it really hurt add the fields. > >> There just may be a few more places we want to add >> PLG_templateSetVars(); > > There's really no place it shouldn't be called. Anywhere there's a > final $T->parse(), there should probably be a call to > PLG_templateSetVars just before it. > > > ---- > Joe Mucchiello > Throwing Dice Games > http://www.throwingdice.com > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > From oliver at spiesshofer.com Sat Aug 11 23:15:45 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Sun, 12 Aug 2007 11:15:45 +0800 Subject: [geeklog-devel] User requests (was: Story Templates) In-Reply-To: <0JMM00LMDSVDMXB0@mta5.srv.hcvlny.cv.net> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> <0JMM00JQTHID4T20@mta3.srv.hcvlny.cv.net> <46BE0ADB.1060905@spiesshofer.com> <0JMM00LMDSVDMXB0@mta5.srv.hcvlny.cv.net> Message-ID: <46BE7B61.7040102@spiesshofer.com> Joe Mucchiello wrote: > My point was that the only reason you don't propose doing this as a > plugin is you have CVS access. You assumption is false. I do not think that this is sensible to be done in a plugin. that is why i think it should be core code. i do not think it is good to have to go to a plugin-admin page to start a story, a static page, a calendar event with pre-filled text for a special occasion. > You are looking to provide templates that will cause stories entered > at different times by different authors to share a similar look and > feel. Some story types may have different looks but all stories of the > same type should be uniform. This isn't rocket science. I'm just > saying you can accomplish this with the existing template library and > a few well placed calls. I'm also saying that other than stories and > staticpages, there's not much other need for this templating system. > And I'm saying that you can do this through the plugin API without > modifying core. Have I missed something? Yes. You teach me how to do something in a plugin and assume at the same time that I know how to do that, and that I think it would be better thing to do it as a plugin - and that I still propose it as core code just because i have CVS access. Sorry, but that sounds like you assume i am a guy who does thing in the wrong way despite knowing better, but you still seem to feel the necessity to teach me how to do it better... that does not make sense and tells me that you do not think much of the way I work and/or my work. Maybe you should go through the list of my contributions to the core code in the history file before you start accusing me of such things. > I've seen the forum posts requesting such a feature and I believe it > use to be in the bug tracker/feature requests. (Another planning tool > missing.) Still, doing it as a plugin means sites that don't use it > aren't burdened by the additional runtime if'ing around the code. same as above. why do you tell me why it should b a plugin and say at the same time that I know that already and that I ignore it? And I still think that this should be done in the core code. > There's no reason why a non-commercial group cannot plan ahead. Most > OSS projects have Roadmaps. Most OSS are not commercial operations. > Roadmaps are about planning. This goes back to the end of life for > PHP4 and my comment when that was announced that GL should have an > announcement that GL 1.5 will be PHP5 only. Or 1.4.2, or 1.4.3? > Something. There should be a plan. I do no say we cannot. And you should not blankly assume that we do not have any plans. We simply do not hace many planned thing and did not publish a refined list. We definitely know some things that will be in the code by a certain point in time, we simply did not write it up so far as a public list. The summer of code program lists points that are on the "roadmap" for example. I just say that until now we had better things to do. I do not say that is the best way to do it. I say that is what we did so far. And again, you can agree with that or criticize that. But do not expect that your ciritcism will be heard by people you accuse of the behavior mentioned above. You will have to sell you request so that people like it. Btw: this template issue is becoming a pure theoretical discussion. I talked to another core developer and we came to the point that the feature is not worth doing sincet the application is too specific and it will be able to be become reality as soon as the webservices are life. by discussion btw, not accusations. Oliver From joe at ThrowingDice.com Sat Aug 11 23:34:28 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 11 Aug 2007 23:34:28 -0400 Subject: [geeklog-devel] Proposal: Plugin vars in templates In-Reply-To: <46BE6BED.6040301@portalparts.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> <0JMM00M3RHVEFW20@mta5.srv.hcvlny.cv.net> <46BE0B3A.9060500@spiesshofer.com> <46BE5DB0.40801@portalparts.com> <0JMN00GWA0M3EED0@mta1.srv.hcvlny.cv.net> <46BE6BED.6040301@portalparts.com> Message-ID: <0JMN00GSV5XTEEG0@mta1.srv.hcvlny.cv.net> At 10:09 PM 8/11/2007, Blaine Lang wrote: >In the case of my cart plugin, I use an autotag anyways so the >[cart] tag can be where the user wants it. In the case of the >ratings plugin specifically, why not use a [ratings] autotag which >the story author or forum post author can then use to add a >formatted ratings block at the end of the story or in the middle. >Not need then for a template variable. Because autotags are not called with context. Where do I get the sid of the story inside a call to plugin_autotag_yourplugin? There was a patch for PLG_replaceTags where you could pass an array of info into it: PLG_replaceTags($content, '', Array('type' => 'story', 'sid' => $sid)); But it hasn't been put to CVS. I think it's somewhere in the lost bug tracking/feature request database. Without it, how does the ratings plugin link the rating to the current story? With a template var, you know the template type is 'story' and you can call $T->get_var('sid') to get the story id. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From joe at ThrowingDice.com Sat Aug 11 23:54:15 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 11 Aug 2007 23:54:15 -0400 Subject: [geeklog-devel] User requests (was: Story Templates) In-Reply-To: <46BE7B61.7040102@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> <0JMM00JQTHID4T20@mta3.srv.hcvlny.cv.net> <46BE0ADB.1060905@spiesshofer.com> <0JMM00LMDSVDMXB0@mta5.srv.hcvlny.cv.net> <46BE7B61.7040102@spiesshofer.com> Message-ID: <0JMN00GVK6USYWE0@mta1.srv.hcvlny.cv.net> At 11:15 PM 8/11/2007, Oliver Spiesshofer wrote: >Joe Mucchiello wrote: >>My point was that the only reason you don't propose doing this as a >>plugin is you have CVS access. >You assumption is false. I do not think that this is sensible to be >done in a plugin. that is why i think it should be core code. i do >not think it is good to have to go to a plugin-admin page to start a >story, a static page, a calendar event with pre-filled text for a >special occasion. You wouldn't have to go to a plugin page to start a story. The plugin would fill in the template selection on the normal story or staticpage editor without the story or staticpage knowing the extra field was there. The only reason to go to the plugin admin page is to add a template to the system. Once the templates exist, you use the normal story or staticpage editors to use the templates. >Yes. You teach me how to do something in a plugin and assume at the >same time that I know how to do that, and that I think it would be >better thing to do it as a plugin - and that I still propose it as >core code just because i have CVS access. Sorry, but that sounds >like you assume i am a guy who does thing in the wrong way despite >knowing better, but you still seem to feel the necessity to teach me >how to do it better... that does not make sense and tells me that >you do not think much of the way I work and/or my work. Maybe you >should go through the list of my contributions to the core code in >the history file before you start accusing me of such things. I haven't accused you knowing or not knowing anything. I thought you wanted to discuss the idea of adding templates to core. I'm showing you an alternative that you obviously didn't think of. The first part above shows you don't know how it would work as a plugin. And I know you've added lots of stuff to GL. I've said repeatedly I'm not attacking you and I've tried to be civil. Stop reading venom where there isn't any. >>I've seen the forum posts requesting such a feature and I believe >>it use to be in the bug tracker/feature requests. (Another planning >>tool missing.) Still, doing it as a plugin means sites that don't >>use it aren't burdened by the additional runtime if'ing around the code. >same as above. why do you tell me why it should b a plugin and say >at the same time that I know that already and that I ignore it? Now I get it. You are taking my "accusation" that you aren't considering a plugin due to CVS access in a far more inflammatory way than I intended it. Several ideas there were conflated and I didn't mean to link CVS access so strongly with the template proposal. Let's try this: It's obvious to me you can do the template thing as a plugin. So I assumed it was obvious to you. It is certainly easier putting it into core though if you can. And you can. That's all I'm saying about CVS access with regard to templates. I had no way of knowing you had never considered doing it in a plugin. If you feel that I'm slighting you somehow because we disagree about this I'm sorry. But now, the focus of what I'm saying is there is more than one way to implement this feature. You proposed a feature and asked for people's thoughts. My thoughts were not to add clutter to core. >I do no say we cannot [plan]. And you should not blankly assume that >we do not have any plans. We simply do not hace many planned thing >and did not publish a refined list. See, now this is odd. Having documented plans make Geeklog look better to people seeing it for the first time. People like to know where the software will be tomorrow. Geeklog is not a commercial entity but you sell to folks. Anything that provides them peace of mind should be front and center on the Geeklog homepage. People outside the inner circle need to be able to plan for their own usage of Geeklog. Having plans makes our lives easier. I'm a user and I'd like to know where Geeklog is going. Are you saying it isn't worth your time to keep people in the know? ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From oliver at spiesshofer.com Sun Aug 12 00:23:06 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Sun, 12 Aug 2007 12:23:06 +0800 Subject: [geeklog-devel] User requests In-Reply-To: <0JMN00GVK6USYWE0@mta1.srv.hcvlny.cv.net> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> <0JMM00JQTHID4T20@mta3.srv.hcvlny.cv.net> <46BE0ADB.1060905@spiesshofer.com> <0JMM00LMDSVDMXB0@mta5.srv.hcvlny.cv.net> <46BE7B61.7040102@spiesshofer.com> <0JMN00GVK6USYWE0@mta1.srv.hcvlny.cv.net> Message-ID: <46BE8B2A.8020206@spiesshofer.com> Joe Mucchiello wrote: > You wouldn't have to go to a plugin page to start a story. The plugin > would fill in the template selection on the normal story or staticpage > editor without the story or staticpage knowing the extra field was > there. The only reason to go to the plugin admin page is to add a > template to the system. Once the templates exist, you use the normal > story or staticpage editors to use the templates. where would you go to select one of 5 story-content-templates that you created? If you did not mean to accuse mean then this is fine with me. lets forget this. > See, now this is odd. Having documented plans make Geeklog look better > to people seeing it for the first time. People like to know where the > software will be tomorrow. Geeklog is not a commercial entity but you > sell to folks. Anything that provides them peace of mind should be > front and center on the Geeklog homepage. People outside the inner > circle need to be able to plan for their own usage of Geeklog. Having > plans makes our lives easier. I'm a user and I'd like to know where > Geeklog is going. Are you saying it isn't worth your time to keep > people in the know? well as I said, if you have more things to do than you have time to, you have to set priorities. and between fixing bugs and writing code for the next version that is already decided to be implemented, no-one had done so far the concentrated effort of creating such a roadmap. I fully agree with you that it would be better to have one. We just do not because of time and coordination reasons. we have a larger backlog of issues than plan for the future currently. Oliver From joe at ThrowingDice.com Sun Aug 12 01:09:45 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sun, 12 Aug 2007 01:09:45 -0400 Subject: [geeklog-devel] User requests In-Reply-To: <46BE8B2A.8020206@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <46BD13A3.6020607@spiesshofer.com> <20070811082527.1325621733@smtp.haun-online.de> <46BD7F43.6020209@spiesshofer.com> <0JMM00LCK5F84QS0@mta4.srv.hcvlny.cv.net> <46BDCD34.8030307@spiesshofer.com> <0JMM002E07743PR0@mta1.srv.hcvlny.cv.net> <46BDD51F.8000200@spiesshofer.com> <0JMM00LMKC92BWN0@mta4.srv.hcvlny.cv.net> <46BDF633.3050509@spiesshofer.com> <0JMM00JQTHID4T20@mta3.srv.hcvlny.cv.net> <46BE0ADB.1060905@spiesshofer.com> <0JMM00LMDSVDMXB0@mta5.srv.hcvlny.cv.net> <46BE7B61.7040102@spiesshofer.com> <0JMN00GVK6USYWE0@mta1.srv.hcvlny.cv.net> <46BE8B2A.8020206@spiesshofer.com> Message-ID: <0JMN00MKHACNFWI0@mta5.srv.hcvlny.cv.net> At 12:23 AM 8/12/2007, Oliver Spiesshofer wrote: >Joe Mucchiello wrote: >>You wouldn't have to go to a plugin page to start a story. The >>plugin would fill in the template selection on the normal story or >>staticpage editor without the story or staticpage knowing the extra >>field was there. The only reason to go to the plugin admin page is >>to add a template to the system. Once the templates exist, you use >>the normal story or staticpage editors to use the templates. >where would you go to select one of 5 story-content-templates that >you created? It would be right on the story editor screen, stick between SID and Title, or stick it at the end, it doesn't matter where. Hooking PLG_tempalteSetVars enables you to add a dropdown box that displays the list of story template names. You pick one before you save the story (if you don't pick one, the story doesn't use a template). When PLG_saveItem is called you save the template name selected in your template table associated with a certain sid and type='story'. Whenever the story is displayed, SP_renderArticle will call PLG_templateSetVars. Your hook looks up the sid in your table, runs my 10 line sample magic function something like this: $T->set_var('body_text', magic_template_function($T->get_var('body_text'), $T); And Voila`, the story is templated. If I weren't busy with the calendar bounty I'd mock it up. There are folks who have asked for this feature. Now that I've spent a while discussing it, it really would be easy to do. About the only thing special would be the story magic function would have to call STORY_replace_images() in addition to running $T->parse(). >well as I said, if you have more things to do than you have time to, >you have to set priorities. and between fixing bugs and writing code >for the next version that is already decided to be implemented, >no-one had done so far the concentrated effort of creating such a >roadmap. I fully agree with you that it would be better to have one. >We just do not because of time and coordination reasons. we have a >larger backlog of issues than plan for the future currently. How about a wiki page were the various coders could just go in an list their current projects? I know, they'd never go back and update it. But it would be a start. :) ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From dirk at haun-online.de Sun Aug 12 03:24:09 2007 From: dirk at haun-online.de (Dirk Haun) Date: Sun, 12 Aug 2007 09:24:09 +0200 Subject: [geeklog-devel] Webservices API in CVS In-Reply-To: <46BE5D82.60208@portalparts.com> References: <20070810203456.1283526497@smtp.haun-online.de> <20070811170604.613332147@smt p.haun-online.de> <20070811173109.2131306773@smtp.haun-online.de> <46BE5D82.60208@portalparts.com> Message-ID: <20070812072409.993354388@smtp.haun-online.de> Blaine Lang wrote: >Although, I think the full power of webservices would be seen if we did >implement security and this is how it could be implemented: > >You send a "authenticate" verb (...) Authentication is, of course, handled by the protocol the webservices uses. So Atompub in this case: >14. Securing the Atom Publishing Protocol > > The Atom Publishing Protocol is based on HTTP. Authentication > requirements for HTTP are covered in Section 11 of [RFC2616]. (...) > At a minimum, client and server > implementations MUST be capable of being configured to use HTTP Basic > Authentication [RFC2617] in conjunction with a connection made with > TLS 1.0 [RFC2246] or a subsequent standards-track version of TLS (actually, I think it's currently only doing Basic Authentication, without TLS - but then again that's about as secure as a direct login) Once authenticated, it's like the user logged directly into the Geeklog site. bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From devel at portalparts.com Sun Aug 12 08:45:33 2007 From: devel at portalparts.com (Blaine Lang) Date: Sun, 12 Aug 2007 08:45:33 -0400 Subject: [geeklog-devel] Webservices API in CVS In-Reply-To: <20070812072409.993354388@smtp.haun-online.de> References: <20070810203456.1283526497@smtp.haun-online.de> <20070811170604.613332147@smt p.haun-online.de> <20070811173109.2131306773@smtp.haun-online.de> <46BE5D82.60208@portalparts.com> <20070812072409.993354388@smtp.haun-online.de> Message-ID: <46BF00ED.7030302@portalparts.com> Dirk Haun wrote: > Authentication is, of course, handled by the protocol the webservices uses. So Atompub in this case: Right and thats fine for Atompub but I was hinting at a generic authentication service which would require (I'm suggesting) a new field to hold a unique encrypted key which could be returned and used in subsequent webservices calls. Otherwise, it appears to me (and I have not looked at the code or the Atompub service) that others that want to write a secure service, they need to also implement authentication. Would it not be a good idea to offer a base authentication service. Webservice could still add/layer on their own like Atompub is doing. Anyway, I am off the net for the next 8 days or so..... > Blaine Lang wrote: > > >> Although, I think the full power of webservices would be seen if we did >> implement security and this is how it could be implemented: >> >> You send a "authenticate" verb (...) >> > > Authentication is, of course, handled by the protocol the webservices > uses. So Atompub in this case: > > >> 14. Securing the Atom Publishing Protocol >> >> The Atom Publishing Protocol is based on HTTP. Authentication >> requirements for HTTP are covered in Section 11 of [RFC2616]. >> > (...) > >> At a minimum, client and server >> implementations MUST be capable of being configured to use HTTP Basic >> Authentication [RFC2617] in conjunction with a connection made with >> TLS 1.0 [RFC2246] or a subsequent standards-track version of TLS >> > > (actually, I think it's currently only doing Basic Authentication, > without TLS - but then again that's about as secure as a direct login) > > Once authenticated, it's like the user logged directly into the Geeklog site. > > bye, Dirk > > > From dirk at haun-online.de Sun Aug 12 14:07:03 2007 From: dirk at haun-online.de (Dirk Haun) Date: Sun, 12 Aug 2007 20:07:03 +0200 Subject: [geeklog-devel] Webservices API in CVS (was: About the "internal" and Webservices APIs) In-Reply-To: <20070811170604.613332147@smtp.haun-online.de> References: <20070810203456.1283526497@smtp.haun-online.de> <20070811170604.613332147@smtp.haun-online.de> Message-ID: <20070812180703.1238551084@smtp.haun-online.de> Dirk Haun wrote: >I would be interested if anyone could get that Atompub filesystem[1] >working (I couldn't even get it to install ...). Okay, finally got it installed. The instructions have at least one error and are obviously not made for Ruby newbies like me. And someone please remind me to add more RAM to this Linux box - it was swapping most of the time ... Anyway, got it to this point now: dirk at pandora:~> ./appfs.rb mountdir unexpected response Content-Type: "application/atomserv+xml". should be one of: ["application/atomsvc+xml"] So apparently it's expecting an Atom service document (whatever that is ...), not the introspection I tried to feed it with. Oh well. Ramnath, if you're reading this: Do you know what that is and how easy (or not) it would be to add it? bye, Dirk [1] -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From oliver at spiesshofer.com Sun Aug 12 21:21:06 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Mon, 13 Aug 2007 09:21:06 +0800 Subject: [geeklog-devel] Link back from plugin comments? In-Reply-To: <20070811195314.2138421597@smtp.haun-online.de> References: <20070809191757.1838430708@smtp.haun-online.de> <8319e2d60708091230p234807ccpa0e8b2189e1f4714@mail.gmail.com> <20070809194354.1261645246@smtp.haun-online.de> <8319e2d60708091406s4f65fa2fje485111e7f95d231@mail.gmail.com> <20070811195314.2138421597@smtp.haun-online.de> Message-ID: <46BFB202.3000400@spiesshofer.com> Fixed. Oliver Dirk Haun wrote: > Vincent Furia wrote: > > >> You do need the plugin function >> plugin_getcommenturlid_ or else it assumes the location is >> geeklog_url/plugin_name/index.php?id=XXX. >> >> The template variable that gets filled out is: story_link >> > > Okay, that's (at least) two problems here then: > > 1) None of our plugins implement that function. > > 2) None of the templates contain a {story_link} variable. > > I see there's a note about {story_link} in the changelog - for > 1.3.10rc1. Looks like it got lost in a later update. > > It also looks like the link back to a story doesn't work in CVS either, > so at least that's consistent now. Consistently wrong, but still ... :-/ > > In 1.4.1, in commentbar.thtml, we had > > {start_storylink_anchortag}{story_title}{end_storylink_anchortag} > > In CVS, that's only {story_title} now. Changing it back to the above, > however, displays the story title twice. > > *sigh* > > bye, Dirk > > > From oliver at spiesshofer.com Sun Aug 12 21:28:37 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Mon, 13 Aug 2007 09:28:37 +0800 Subject: [geeklog-devel] Link back from plugin comments? In-Reply-To: <20070811200549.751858068@smtp.haun-online.de> References: <20070809191757.1838430708@smtp.haun-online.de> <8319e2d60708091230p234807ccpa0e8b2189e1f4714@mail.gmail.com> <20070809194354.1261645246@smtp.haun-online.de> <8319e2d60708091406s4f65fa2fje485111e7f95d231@mail.gmail.com> <20070811195314.2138421597@smtp.haun-online.de> <20070811200549.751858068@smtp.haun-online.de> Message-ID: <46BFB3C5.3000104@spiesshofer.com> Also fixed. Oliver Dirk Haun wrote: > Dirk Haun wrote: > > >> In CVS, that's only {story_title} now. Changing it back to the above, >> however, displays the story title twice. >> > > That's because {start_storylink_anchortag} now contains a complete link > instead of only the opening tag, as the name suggests ... > > And speaking of comments: Anonymous comments now display as > > Authored by: on ... > > i.e. without the "Anonymous". Unless you're looking at them via their > permalink, then it's > > Authored by: {author_link} on ... > > *more sighs* > > bye, Dirk > > > From info at heatherengineering.com Sun Aug 12 22:24:47 2007 From: info at heatherengineering.com (Heather Engineering) Date: Mon, 13 Aug 2007 11:24:47 +0900 Subject: [geeklog-devel] Links plugin Message-ID: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> Dirk, Oliver, Is there anything I can do to speed up progress on the links plugin code that I sent you some time ago? I would like to make use of the new plugin, but for ease of upgrading etc. I want to use the final 'official' version rather than my own version. Cheers, Euan. From oliver at spiesshofer.com Sun Aug 12 22:50:11 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Mon, 13 Aug 2007 10:50:11 +0800 Subject: [geeklog-devel] Links plugin In-Reply-To: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> Message-ID: <46BFC6E3.7010307@spiesshofer.com> Euan, I will make another test of the plugin now. You get my feedback soon. Dirk, if the version is OK shall I update the CVS with it? Oliver Heather Engineering wrote: > Dirk, Oliver, > > Is there anything I can do to speed up progress on the links plugin > code that I sent you some time ago? I would like to make use of the > new plugin, but for ease of upgrading etc. I want to use the final > 'official' version rather than my own version. > > Cheers, > > Euan. > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > From dirk at haun-online.de Mon Aug 13 01:55:13 2007 From: dirk at haun-online.de (Dirk Haun) Date: Mon, 13 Aug 2007 07:55:13 +0200 Subject: [geeklog-devel] Links plugin In-Reply-To: <46BFC6E3.7010307@spiesshofer.com> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> Message-ID: <20070813055513.1136795207@smtp.haun-online.de> Oliver Spiesshofer wrote: >if the version is OK shall I update the CVS with it? Yes, please. bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From mjervis at gmail.com Mon Aug 13 04:44:05 2007 From: mjervis at gmail.com (Michael Jervis) Date: Mon, 13 Aug 2007 09:44:05 +0100 Subject: [geeklog-devel] code scrubbing: stripslashes In-Reply-To: <0JMM009ZEL0GAHR0@mta2.srv.hcvlny.cv.net> References: <20070810203456.1283526497@smtp.haun-online.de> <0JML0076E53V4YD0@mta5.srv.hcvlny.cv.net> <20070811082234.1150509600@smtp.haun-online.de> <0JMM00H9DHZBRM30@mta2.srv.hcvlny.cv.net> <46BE0BD0.5050506@spiesshofer.com> <2a1a3bb50708111230i482f2716s80aa1d55d2a08ec@mail.gmail.com> <0JMM009ZEL0GAHR0@mta2.srv.hcvlny.cv.net> Message-ID: <7b42e7470708130144v69b806a7tac4c3eed95dc755@mail.gmail.com> I think the /concept/ is right, doing an auto-and-correct stripslashes on all HTTP globals on start of the page. Obviously as noted the implementation is incorrect. Should be reasonably easy to clean up everything. Only problem is if someone badly upgrades their lib-common.php when upgrading, they may have a gaping hole in their security... From oliver at spiesshofer.com Mon Aug 13 04:51:20 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Mon, 13 Aug 2007 16:51:20 +0800 Subject: [geeklog-devel] code scrubbing: stripslashes In-Reply-To: <7b42e7470708130144v69b806a7tac4c3eed95dc755@mail.gmail.com> References: <20070810203456.1283526497@smtp.haun-online.de> <0JML0076E53V4YD0@mta5.srv.hcvlny.cv.net> <20070811082234.1150509600@smtp.haun-online.de> <0JMM00H9DHZBRM30@mta2.srv.hcvlny.cv.net> <46BE0BD0.5050506@spiesshofer.com> <2a1a3bb50708111230i482f2716s80aa1d55d2a08ec@mail.gmail.com> <0JMM009ZEL0GAHR0@mta2.srv.hcvlny.cv.net> <7b42e7470708130144v69b806a7tac4c3eed95dc755@mail.gmail.com> Message-ID: <46C01B88.4040900@spiesshofer.com> With the changes done during some of the upgrades I seriously doubt the site will work if the upgrade of that file is not done. Just take COM_createLink. w/o that one, almost every page that creates any kind of link crashes. Oliver Michael Jervis wrote: > I think the /concept/ is right, doing an auto-and-correct stripslashes > on all HTTP globals on start of the page. Obviously as noted the > implementation is incorrect. > > Should be reasonably easy to clean up everything. > > Only problem is if someone badly upgrades their lib-common.php when > upgrading, they may have a gaping hole in their security... > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > > From mjervis at gmail.com Mon Aug 13 05:09:30 2007 From: mjervis at gmail.com (Michael Jervis) Date: Mon, 13 Aug 2007 10:09:30 +0100 Subject: [geeklog-devel] code scrubbing: stripslashes In-Reply-To: <46C01B88.4040900@spiesshofer.com> References: <20070810203456.1283526497@smtp.haun-online.de> <0JML0076E53V4YD0@mta5.srv.hcvlny.cv.net> <20070811082234.1150509600@smtp.haun-online.de> <0JMM00H9DHZBRM30@mta2.srv.hcvlny.cv.net> <46BE0BD0.5050506@spiesshofer.com> <2a1a3bb50708111230i482f2716s80aa1d55d2a08ec@mail.gmail.com> <0JMM009ZEL0GAHR0@mta2.srv.hcvlny.cv.net> <7b42e7470708130144v69b806a7tac4c3eed95dc755@mail.gmail.com> <46C01B88.4040900@spiesshofer.com> Message-ID: <7b42e7470708130209g62e60b6bw48cc204e623fc809@mail.gmail.com> On 13/08/07, Oliver Spiesshofer wrote: > With the changes done during some of the upgrades I seriously doubt the > site will work if the upgrade of that file is not done. > Just take COM_createLink. w/o that one, almost every page that creates > any kind of link crashes. Well it's a case of how you upgrade it. You /should/ overwrite the file and amend the path line (and re-add the bad-behaviour hook). But, some people don't and might just upgrade the chunk that's full of function defs. From tony at tonybibbs.com Mon Aug 13 08:48:27 2007 From: tony at tonybibbs.com (Tony Bibbs) Date: Mon, 13 Aug 2007 05:48:27 -0700 (PDT) Subject: [geeklog-devel] Webservices API in CVS Message-ID: <137805.17792.qm@web703.biz.mail.mud.yahoo.com> FWIW, you guys may want to check into how the GL2 codebase implemented security at the WS layer. --Tony ----- Original Message ---- From: Blaine Lang To: Geeklog Development Sent: Saturday, August 11, 2007 8:08:18 PM Subject: Re: [geeklog-devel] Webservices API in CVS Hi Dirk, I like the generic API PLG_invokeService and agree that being generic it can be of use. Although, I think the full power of webservices would be seen if we did implement security and this is how it could be implemented: You send a "authenticate" verb with you username and password and get back a secure oid (object id) that is like the MD5 password field now. This is not something a hacker would easily get. Now once we have the oid, it would be passed in as a parm for all secure calls. RSS Feeds are great for public access data. But what if I wanted to have remote access to secure files or forum posts. Someone could post now to the forum as their userid. I think without security, all requests are anonymous and I'm trying to think of where this is better then the RSS feeds API. get list_forums get list_forum_topics post reply get new privatemessages get file (secure category) Blaine Dirk Haun wrote: > If you're getting a note about an undefined function: > service_getTopicList_staticpages() in plugins/staticpages/ > services.inc.php is calling a function COM_topicArray(). Not sure where > that's coming from - I don't have the code for such a function. > > Just comment it out or update from CVS again. > > Also, I forgot to point out that the Webservices API requires PHP 5. We > should probably add a check for that somewhere ... > > bye, Dirk > > > _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel From joe at ThrowingDice.com Mon Aug 13 09:34:00 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Mon, 13 Aug 2007 09:34:00 -0400 Subject: [geeklog-devel] code scrubbing: stripslashes In-Reply-To: <7b42e7470708130209g62e60b6bw48cc204e623fc809@mail.gmail.co m> References: <20070810203456.1283526497@smtp.haun-online.de> <0JML0076E53V4YD0@mta5.srv.hcvlny.cv.net> <20070811082234.1150509600@smtp.haun-online.de> <0JMM00H9DHZBRM30@mta2.srv.hcvlny.cv.net> <46BE0BD0.5050506@spiesshofer.com> <2a1a3bb50708111230i482f2716s80aa1d55d2a08ec@mail.gmail.com> <0JMM009ZEL0GAHR0@mta2.srv.hcvlny.cv.net> <7b42e7470708130144v69b806a7tac4c3eed95dc755@mail.gmail.com> <46C01B88.4040900@spiesshofer.com> <7b42e7470708130209g62e60b6bw48cc204e623fc809@mail.gmail.com> Message-ID: <0JMP00C84SD6S7L0@mta2.srv.hcvlny.cv.net> At 05:09 AM 8/13/2007, Michael Jervis wrote: >On 13/08/07, Oliver Spiesshofer wrote: > > With the changes done during some of the upgrades I seriously doubt the > > site will work if the upgrade of that file is not done. > > Just take COM_createLink. w/o that one, almost every page that creates > > any kind of link crashes. > >Well it's a case of how you upgrade it. You /should/ overwrite the >file and amend the path line (and re-add the bad-behaviour hook). But, >some people don't and might just upgrade the chunk that's full of >function defs. Really, I've always overwritten the lib-common and grafted any of my hacks into the new file. Also, the only folks really in trouble here are those who have magic_quote_gpc set to true. That should be pretty rare (and frankly they should just get that fixed in the php.ini). Remember for most installations, my code change is an if() that returns false. And Oliver is right, I grabbed calendar from CVS and had to add COM_createLink to the function.inc (inside an if function_exists, of course) in order to use it with 1.4.1. Although, that was the only change I had to copy over from CVS to get it running. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From dirk at haun-online.de Mon Aug 13 13:55:37 2007 From: dirk at haun-online.de (Dirk Haun) Date: Mon, 13 Aug 2007 19:55:37 +0200 Subject: [geeklog-devel] Webservices API in CVS (was: About the "internal" and Webservices APIs) In-Reply-To: <20070812180703.1238551084@smtp.haun-online.de> References: <20070810203456.1283526497@smtp.haun-online.de> <20070811170604.613332147@smtp.haun-online.de> <20070812180703.1238551084@smtp.haun-online.de> Message-ID: <20070813175537.1776396100@smtp.haun-online.de> Dirk Haun wrote: >So apparently it's expecting an Atom service document (whatever that >is ...), not the introspection I tried to feed it with. Oh well. Okay, cleared up that confusion (thanks, Ramnath): The introspection _is_ the service document. This was apparently renamed quite late in the process so different folks use different names for the same thing now. And the content type was also wrong. So let's try that again (slightly censored): dirk at pandora:~> mkdir geeklog dirk at pandora:~> ./appfs.rb geeklog --svc-url http://www.example.com/ webservices/atom/?introspection --user Dirk --password *censored* & [1] 11491 dirk at pandora:~> ll geeklog/ total 0 dr-xr-xr-x 1 dirk dirk 4096 Aug 13 19:46 Geeklog_CVS/ Sweet! That's the name of my Geeklog site here. dirk at pandora:~> ll geeklog/Geeklog_CVS/ total 0 dr-xr-xr-x 1 dirk dirk 4096 Aug 13 19:46 Entries/ dirk at pandora:~> ll geeklog/Geeklog_CVS/Entries/ total 0 dr-xr-xr-x 1 dirk dirk 4096 Aug 13 19:46 drafts/ dr-xr-xr-x 1 dirk dirk 4096 Aug 13 19:46 published/ That's the appfs separating content into drafts and visible things. Since the static pages don't have a draft flag, that directory is empty. dirk at pandora:~> ll geeklog/Geeklog_CVS/Entries/published/ total 0 -rw-rw-rw- 1 dirk dirk 0 Aug 13 19:46 Anonymous_CVS_Access -rw-rw-rw- 1 dirk dirk 0 Aug 13 19:46 Bounties! (etc.) ... and those are my static pages! Editing doesn't seem to work yet (haven't checked why), but deletion works (just remove the file and the page is gone from Geeklog). And you can view the content. Now imagine to open those files in your favourite word processor. Or just drop new files in that directory and have them appear on your website. Can everybody see now why I'm so excited about this? This is not only cool, this could actually become damn useful. bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From vfuria at gmail.com Fri Aug 17 19:34:46 2007 From: vfuria at gmail.com (Vincent Furia) Date: Fri, 17 Aug 2007 17:34:46 -0600 Subject: [geeklog-devel] Windows Live ID Opened Message-ID: <8319e2d60708171634t56870163uaba50367a7ce3c7@mail.gmail.com> http://blogs.msdn.com/angus_logan/archive/2007/08/16/service-release-announcment-windows-live-id-web-authentication-released.aspx I'm sure most of you saw this on slashdot. But liveid has been opened. I haven't taken a look yet, but apparently there is a sample implementation for PHP available. -Vinny From joe at ThrowingDice.com Sat Aug 18 23:12:41 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sat, 18 Aug 2007 23:12:41 -0400 Subject: [geeklog-devel] E_ALL / E_STRICT In-Reply-To: <8319e2d60708171634t56870163uaba50367a7ce3c7@mail.gmail.com> References: <8319e2d60708171634t56870163uaba50367a7ce3c7@mail.gmail.com> Message-ID: <0JN0002453LJCLO0@mta1.srv.hcvlny.cv.net> With the move toward PHP5, any thoughts on changing lib-common.php from // Prevent PHP from reporting uninitialized variables error_reporting( E_ERROR | E_WARNING | E_PARSE | E_COMPILE_ERROR ); to error_reporting( E_ALL ); I did it on a vanilla 1.4.1 install and it worked fine. Plugin writers can get use to the new error reporting level, couldn't they? ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From dirk at haun-online.de Sun Aug 19 03:17:05 2007 From: dirk at haun-online.de (Dirk Haun) Date: Sun, 19 Aug 2007 09:17:05 +0200 Subject: [geeklog-devel] E_ALL / E_STRICT In-Reply-To: <0JN0002453LJCLO0@mta1.srv.hcvlny.cv.net> References: <8319e2d60708171634t56870163uaba50367a7ce3c7@mail.gmail.com> <0JN0002453LJCLO0@mta1.srv.hcvlny.cv.net> Message-ID: <20070819071705.912078842@smtp.haun-online.de> Joe Mucchiello wrote: >error_reporting( E_ALL ); To quote myself from April (missing from the mailing list archives, alas): >Some day, Geeklog should work with E_ALL by default (or rather, without >the need for that error_reporting() statement). We're not that far off, >actually. There are only some pesky issues with unchecked checkboxes >that are tedious to code around ... Try saving a story to see what I mean ... bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From joe at ThrowingDice.com Sun Aug 19 03:38:16 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sun, 19 Aug 2007 03:38:16 -0400 Subject: [geeklog-devel] E_ALL / E_STRICT In-Reply-To: <20070819071705.912078842@smtp.haun-online.de> References: <8319e2d60708171634t56870163uaba50367a7ce3c7@mail.gmail.com> <0JN0002453LJCLO0@mta1.srv.hcvlny.cv.net> <20070819071705.912078842@smtp.haun-online.de> Message-ID: <0JN00077RFW7C9E0@mta5.srv.hcvlny.cv.net> At 03:17 AM 8/19/2007, Dirk Haun wrote: >Joe Mucchiello wrote: > > >error_reporting( E_ALL ); > >To quote myself from April (missing from the mailing list archives, alas): > > >Some day, Geeklog should work with E_ALL by default (or rather, without > >the need for that error_reporting() statement). We're not that far off, > >actually. There are only some pesky issues with unchecked checkboxes > >that are tedious to code around ... > >Try saving a story to see what I mean ... Took 10 minutes to fix. line 1312 of 1.4.1 /admin/story.php $expire_hour = COM_applyFilter (isset($_POST['expire_hour']) ? $_POST['expire_hour'] : '', true); if (isset ($_CONF['hour_mode']) && ($_CONF['hour_mode'] == 24)) { if ($expire_hour >= 12) { if ($expire_hour > 12) { $expire_hour -= 12; } $expire_ampm = 'pm'; } else { if ($expire_hour == 0) { $expire_hour = 12; } $expire_ampm = 'am'; } } else { $expire_ampm = COM_applyFilter (isset($_POST['expire_ampm']) ? $_POST['expire_ampm'] : ''); } $expire_minute = COM_applyFilter (isset($_POST['expire_minute']) ? $_POST['expire_minute'] : '', true); $expire_second = COM_applyFilter (isset($_POST['expire_second']) ? $_POST['expire_second'] : '', true); $expire_year = COM_applyFilter (isset($_POST['expire_year']) ? $_POST['expire_year'] : '', true); $expire_month = COM_applyFilter (isset($_POST['expire_month']) ? $_POST['expire_month'] : '', true); $expire_day = COM_applyFilter (isset($_POST['expire_day']) ? $_POST['expire_day'] : '', true); line 1353 submitstory ($type, COM_applyFilter ($_POST['sid']), $uid, COM_applyFilter ($_POST['tid']), COM_stripslashes ($_POST['title']), COM_stripslashes ($_POST['introtext']), COM_stripslashes ($_POST['bodytext']), COM_applyFilter ($_POST['hits'], true), $unixdate, $expiredate, COM_applyFilter ($_POST['featured'], true), COM_applyFilter ($_POST['commentcode'], true), COM_applyFilter ($_POST['trackbackcode'], true), COM_applyFilter (isset($_POST['statuscode']) ? $_POST['statuscode'] : '', true), trim(COM_applyFilter ($_POST['postmode'])), COM_applyFilter (isset($_POST['frontpage']) ? $_POST['frontpage'] : '', true), COM_applyFilter (isset($_POST['draft_flag']) ? $_POST['draft_flag'] : ''), COM_applyFilter ($_POST['numemails'], true), COM_applyFilter ($_POST['owner_id'], true), COM_applyFilter ($_POST['group_id'], true), $_POST['perm_owner'], $_POST['perm_group'], $_POST['perm_members'], $_POST['perm_anon'], isset($_POST['delete']) ? $_POST['delete'] : Array(), COM_applyFilter (isset($_POST['show_topic_icon']) ? $_POST['show_topic_icon'] : ''), COM_applyFilter ($_POST['old_sid'])); isset and ? : are tedious. But taking 10 minutes to add them isn't that onerous. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From joe at ThrowingDice.com Sun Aug 19 13:32:12 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sun, 19 Aug 2007 13:32:12 -0400 Subject: [geeklog-devel] Feature Request: Add $uid to COM_getUserDateTimeFormat In-Reply-To: <0JN00077RFW7C9E0@mta5.srv.hcvlny.cv.net> References: <8319e2d60708171634t56870163uaba50367a7ce3c7@mail.gmail.com> <0JN0002453LJCLO0@mta1.srv.hcvlny.cv.net> <20070819071705.912078842@smtp.haun-online.de> <0JN00077RFW7C9E0@mta5.srv.hcvlny.cv.net> Message-ID: <0JN100MCS7EC9UK0@mta4.srv.hcvlny.cv.net> Sometimes you need to user date format for a user who is not the current user. I've also cleaned up the code, removed typos from the comment and included 1.4.1 and CVS compatible versions. /** * Returns formatted date/time for user * * This function takes a date in either unixtimestamp or in english and * formats it to the users preference. If the user didn't specify a format * the format in the config file is used. This returns an array where array[0] * is the formatted date and array[1] is the unixtimestamp * * @param string $date date to format, otherwise we format current date/time * @param numeric $uid Which user id to get the format for. If empty, current user is used. * @return array array[0] is the formatted date and array[1] is the unixtimestamp. */ function COM_getUserDateTimeFormat($date='', $uid = 0) { global $_TABLES, $_USER, $_CONF; // Get display format for time if (!empty($uid) AND $uid > 1) { $dateformat = DB_getItem($_TABLES['users'], 'format', "uid = $uid"); } else if (!COM_isAnonUser() AND !empty($_USER['format'])) { // the CVS version // } else if (!empty($_USER['uid']) AND $_USER['uid'] > 1 AND !empty($_USER['format'])) { // the 1.4.1 version $dateformat = $_USER['format']; } else { $dateformat = $_CONF['date']; } if (empty($date)) { $stamp = time(); // Date is empty, get current date/time } else if (is_numeric($date)) { $stamp = $date; // This is a timestamp } else { $stamp = strtotime($date); // This is a string representation of a date/time } // Format the date $date = strftime($dateformat, $stamp); return array($date, $stamp); } ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From dirk at haun-online.de Sun Aug 19 13:40:29 2007 From: dirk at haun-online.de (Dirk Haun) Date: Sun, 19 Aug 2007 19:40:29 +0200 Subject: [geeklog-devel] COM_topicList Message-ID: <20070819174029.2124655680@smtp.haun-online.de> Is anyone aware of a plugin or add-on that uses COM_topicList? That function started its life as a quick&dirty copy of the more generic COM_optionList, but most of the options aren't used and probably won't even work. I'd like to clean that function up, but that would change its API. bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From joe at ThrowingDice.com Sun Aug 19 13:54:02 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Sun, 19 Aug 2007 13:54:02 -0400 Subject: [geeklog-devel] COM_topicList In-Reply-To: <20070819174029.2124655680@smtp.haun-online.de> References: <20070819174029.2124655680@smtp.haun-online.de> Message-ID: <0JN100K708EIO7T0@mta3.srv.hcvlny.cv.net> From my plugins directory, I only got one hit from mediagallery (public_html/maint/album_edit.php): $featurepage_select .= COM_topicList('tid,topic',$A['cbpage']); That directory contains amz, archive, bad_behavior2, ban, captcha, dokuwiki, faq, filemgmt, forum, glutil, gus, mediagallery, ratings, and (of course) autotags. And if there are any other common (non-premium) plugins out there, let me know so I can add them to my plugins directory. Staticpages also has a hit (but I'm guessing you know about that one). At 01:40 PM 8/19/2007, Dirk Haun wrote: >Is anyone aware of a plugin or add-on that uses COM_topicList? > >That function started its life as a quick&dirty copy of the more generic >COM_optionList, but most of the options aren't used and probably won't >even work. > >I'd like to clean that function up, but that would change its API. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From mevans at ecsnet.com Sun Aug 19 14:08:01 2007 From: mevans at ecsnet.com (Mark R. Evans) Date: Sun, 19 Aug 2007 13:08:01 -0500 Subject: [geeklog-devel] COM_topicList In-Reply-To: <20070819174029.2124655680@smtp.haun-online.de> References: <20070819174029.2124655680@smtp.haun-online.de> Message-ID: <46C88701.9060200@ecsnet.com> Dirk, Media Gallery does use this function, but feel free to change it how you want and I'll update MG to handle the changes. I already have code in place to check GLs version and do this or that based on the version. I can do the same thing for COM_topicList. Basically, MG can have a different featured album per topic, so I need a list of topics for the album edit screen. If there is another or better way to get the list of topics, I'll use it instead. Thanks! Mark Dirk Haun wrote: > Is anyone aware of a plugin or add-on that uses COM_topicList? > > That function started its life as a quick&dirty copy of the more generic > COM_optionList, but most of the options aren't used and probably won't > even work. > > I'd like to clean that function up, but that would change its API. > > bye, Dirk > > > From dirk at haun-online.de Sun Aug 19 14:43:53 2007 From: dirk at haun-online.de (Dirk Haun) Date: Sun, 19 Aug 2007 20:43:53 +0200 Subject: [geeklog-devel] COM_topicList In-Reply-To: <46C88701.9060200@ecsnet.com> References: <20070819174029.2124655680@smtp.haun-online.de> <46C88701.9060200@ecsnet.com> Message-ID: <20070819184353.1665247470@smtp.haun-online.de> Mark, >Media Gallery does use this function, but feel free to change it how you >want and I'll update MG to handle the changes. Out of curiosity: How are you using it? Do you use the third and fourth parameters at all? In Geeklog itself, pretty much every call is of the form COM_topicList('tid,topic', $current_topic) In a few cases, the fourth parameter is set to "true" to get a list of all topics in multi-language setups. But that's about it. And, as I said, I doubt it would work if you tried to use it any other way. Maybe I'll write a new function and keep COM_topicList as a call to the new one that only works with the above parameter set ... bye, Dirk -- Geeklog Day at FrOSCon: August 25, 2007 - See you there! http://www.geeklog.net/article.php/geeklog-day-at-froscon From mevans at ecsnet.com Sun Aug 19 15:19:01 2007 From: mevans at ecsnet.com (Mark R. Evans) Date: Sun, 19 Aug 2007 14:19:01 -0500 Subject: [geeklog-devel] COM_topicList In-Reply-To: <20070819184353.1665247470@smtp.haun-online.de> References: <20070819174029.2124655680@smtp.haun-online.de> <46C88701.9060200@ecsnet.com> <20070819184353.1665247470@smtp.haun-online.de> Message-ID: <50aae8730708191219y78b2e2acy17309fa1c9af016b@mail.gmail.com> Dirk, I'm only using the first two parameters as well. Again, it is no big deal for me to change MG if you think it would be better in the long run to change COM_topicList(). Thanks! Mark On 8/19/07, Dirk Haun wrote: > > Mark, > > >Media Gallery does use this function, but feel free to change it how you > >want and I'll update MG to handle the changes. > > Out of curiosity: How are you using it? Do you use the third and fourth > parameters at all? > > In Geeklog itself, pretty much every call is of the form > > COM_topicList('tid,topic', $current_topic) > > In a few cases, the fourth parameter is set to "true" to get a list of > all topics in multi-language setups. But that's about it. And, as I > said, I doubt it would work if you tried to use it any other way. > > Maybe I'll write a new function and keep COM_topicList as a call to the > new one that only works with the above parameter set ... > > bye, Dirk > > > -- > Geeklog Day at FrOSCon: August 25, 2007 - See you there! > http://www.geeklog.net/article.php/geeklog-day-at-froscon > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From info at heatherengineering.com Sun Aug 19 17:28:03 2007 From: info at heatherengineering.com (Heather Engineering) Date: Mon, 20 Aug 2007 06:28:03 +0900 Subject: [geeklog-devel] COM_topicList In-Reply-To: <20070819174029.2124655680@smtp.haun-online.de> References: <20070819174029.2124655680@smtp.haun-online.de> Message-ID: <0F7AB341-8720-41BE-9433-9C2A59DC2B3C@heatherengineering.com> I use it in two locations in the category.php file in Links 1.2. Can be easily changed. Euan. On 2007/08/20, at 2:40, Dirk Haun wrote: > Is anyone aware of a plugin or add-on that uses COM_topicList? > > That function started its life as a quick&dirty copy of the more > generic > COM_optionList, but most of the options aren't used and probably won't > even work. > > I'd like to clean that function up, but that would change its API. > > bye, Dirk > > > -- > Geeklog Day at FrOSCon: August 25, 2007 - See you there! > http://www.geeklog.net/article.php/geeklog-day-at-froscon > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel From info at heatherengineering.com Sun Aug 19 05:40:22 2007 From: info at heatherengineering.com (Heather Engineering) Date: Sun, 19 Aug 2007 18:40:22 +0900 Subject: [geeklog-devel] Links plugin In-Reply-To: <20070813055513.1136795207@smtp.haun-online.de> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> Message-ID: Hi, Here is a patch to the cvs nightly with my work on the Links plugin so far, and a tarball with the complete plugin. As with the existing CVS version, Links 1.2 will now only work with the CVS version of Geeklog, so cannot be released before the next update of Geeklog. Currently missing access assignments, features and phpblocks on uninstall. I've tried to get a CVS nightly working, but I don't have time now and it is clear that there are major changes in that area. Someone will have to look into this with a working install of Geeklog 1.4.2. (I just copied accross lib-admin and lib-plugin, and bits of lib-common to an install of 1.4.1). Notes: 1) redirect on save works for links, but I added an extra category type to portal.php - this is not working properly on saving categories when $_LI_CONF['aftersave'] = 'item'. 2) Edited icons_array in lib-admin.php in two locations adding 'delete' and 'addchild' (in patch), image attached should be moved to layout/theme/images/addchild.png 3) Added
to admin list template (in patch) as category list table was not clearing menu items 4) Mouseover text for addchild and delete is not correct for category list - can't see where to correct this 5) category dropdown has javascript onchange submitForm(), but also button "Go". Remove button? check for javascript activation? Tested as root, links admin, submitter, and seems OK at the moment to me, but testing and comments needed before this hits CVS. From Tues Aug 21 to Weds Sep 26 I will be all over Japan, HK, the UK, and Germany so this is as far as I can go right now. If I can pass this back for someone else to run with, that would be great. If not, I'll look at it again some time in October. Dirk, you don't happen to live in Munich by any chance? I'll be there the evening of Sep 16/morning of Sep 17. Euan. -------------- next part -------------- A non-text attachment was scrubbed... Name: links_cvs_patch Type: application/octet-stream Size: 42732 bytes Desc: not available URL: -------------- next part -------------- -------------- next part -------------- A non-text attachment was scrubbed... Name: links_1.2_1.4.2.tar.gz Type: application/x-gzip Size: 62592 bytes Desc: not available URL: -------------- next part -------------- -------------- next part -------------- A non-text attachment was scrubbed... Name: addchild.png Type: image/png Size: 484 bytes Desc: not available URL: -------------- next part -------------- On 2007/08/13, at 14:55, Dirk Haun wrote: > Oliver Spiesshofer wrote: > >> if the version is OK shall I update the CVS with it? > > Yes, please. > > bye, Dirk > > > -- > Geeklog Day at FrOSCon: August 25, 2007 - See you there! > http://www.geeklog.net/article.php/geeklog-day-at-froscon > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel From oliver at spiesshofer.com Sun Aug 19 22:04:23 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Mon, 20 Aug 2007 09:04:23 +0700 Subject: [geeklog-devel] Links plugin In-Reply-To: <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> Message-ID: <46C8F6A7.3080100@spiesshofer.com> Euan, I will look into it ASAP - I am on a business trip right now, hope its rather soon than late. Oliver Heather Engineering wrote: > Hi, > > Tried sending this to the list, but must have got stopped somewhere. > > Here is a patch to the cvs nightly with my work on the Links plugin so > far, and a tarball with the complete plugin. > > As with the existing CVS version, Links 1.2 will now only work with > the CVS version of Geeklog, so cannot be released before the next > update of Geeklog. > > Currently missing access assignments, features and phpblocks on > uninstall. I've tried to get a CVS nightly working, but I don't have > time now and it is clear that there are major changes in that area. > Someone will have to look into this with a working install of Geeklog > 1.4.2. (I just copied accross lib-admin and lib-plugin, and bits of > lib-common to an install of 1.4.1). > > > Notes: > > 1) redirect on save works for links, but I added an extra category > type to portal.php - this is not working properly on saving categories > when $_LI_CONF['aftersave'] = 'item'. > > 2) Edited icons_array in lib-admin.php in two locations adding > 'delete' and 'addchild' (in patch), image attached should be moved to > layout/theme/images/addchild.png > > 3) Added
to admin list template (in patch) as > category list table was not clearing menu items > > 4) Mouseover text for addchild and delete is not correct for category > list - can't see where to correct this > > 5) category dropdown has javascript onchange submitForm(), but also > button "Go". Remove button? check for javascript activation? > > Tested as root, links admin, submitter, and seems OK at the moment to > me, but testing and comments needed before this hits CVS. > > From Tues Aug 21 to Weds Sep 26 I will be all over Japan, HK, the UK, > and Germany so this is as far as I can go right now. If I can pass > this back for someone else to run with, that would be great. If not, > I'll look at it again some time in October. > > Dirk, you don't happen to live in Munich by any chance? I'll be there > the evening of Sep 16/morning of Sep 17. > > Euan. > > > > > > ------------------------------------------------------------------------ > > > > On 2007/08/13, at 14:55, Dirk Haun wrote: > >> Oliver Spiesshofer wrote: >> >>> if the version is OK shall I update the CVS with it? >> >> Yes, please. >> >> bye, Dirk >> >> >> -- >> Geeklog Day at FrOSCon: August 25, 2007 - See you there! >> http://www.geeklog.net/article.php/geeklog-day-at-froscon >> >> _______________________________________________ >> geeklog-devel mailing list >> geeklog-devel at lists.geeklog.net >> http://eight.pairlist.net/mailman/listinfo/geeklog-devel > From joe at ThrowingDice.com Tue Aug 21 15:17:10 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Tue, 21 Aug 2007 15:17:10 -0400 Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) In-Reply-To: <46C8F6A7.3080100@spiesshofer.com> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> <46C8F6A7.3080100@spiesshofer.com> Message-ID: <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> Can you make it possible to name checkboxes used in the delete option? if (is_array($options) AND $options['chkdelete']) { $delitemtext = isset($options['chkitem']) ? $options['chkitem'] : 'delitem'; // new line $admin_templates->set_var('class', "admin-list-field"); $admin_templates->set_var('itemtext', ''); $admin_templates->parse('item_field', 'field', true); } if (is_array($options) AND $options['chkdelete']) { $delitemtext = isset($options['chkitem']) ? $options['chkitem'] : 'delitem'; // new line $admin_templates->set_var('header_text', ''); Probably would need to make a second caItems javascript function so you don't have to modify all the calls to caItems throughout the code. function caItemsExt(f, delitem) { var n=f.elements.length; for (i=0;i {buttons_below} // and then something like would be necessary if (count($data_arr) > 1 AND is_array($options) AND ($options['chkdelete'] OR $options['buttons_below']) { if ($options['chkdelete']) { $admin_templates->set_var('header_text', ''); $admin_templates->set_var('show_deleteimage', ''); } if ($options['buttons_below']) { $admin_templates->set_var('buttons_below', $options['buttons_below']); } $admin_templates->set_var('class', "admin-list-headerfield"); $admin_templates->parse('header_row', 'header', true); $admin_templates->clear_var('on_click'); } else { $admin_templates->set_var('show_deleteimage','display:none;'); } ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From WebSiteMaster at cogeco.net Tue Aug 21 19:08:14 2007 From: WebSiteMaster at cogeco.net (Web Site Master) Date: Tue, 21 Aug 2007 19:08:14 -0400 Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) In-Reply-To: <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com><46BFC6E3.7010307@spiesshofer.com><20070813055513.1136795207@smtp.haun-online.de><13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com><46C8F6A7.3080100@spiesshofer.com> <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> Message-ID: <48CC833F899F4F049774953665AFC5FC@PC1> Multiple buttons would be a great feature to add to the lists. -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Joe Mucchiello Sent: August-21-07 3:17 PM To: Geeklog Development Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) Can you make it possible to name checkboxes used in the delete option? if (is_array($options) AND $options['chkdelete']) { $delitemtext = isset($options['chkitem']) ? $options['chkitem'] : 'delitem'; // new line $admin_templates->set_var('class', "admin-list-field"); $admin_templates->set_var('itemtext', ''); $admin_templates->parse('item_field', 'field', true); } if (is_array($options) AND $options['chkdelete']) { $delitemtext = isset($options['chkitem']) ? $options['chkitem'] : 'delitem'; // new line $admin_templates->set_var('header_text', ''); Probably would need to make a second caItems javascript function so you don't have to modify all the calls to caItems throughout the code. function caItemsExt(f, delitem) { var n=f.elements.length; for (i=0;i {buttons_below} // and then something like would be necessary if (count($data_arr) > 1 AND is_array($options) AND ($options['chkdelete'] OR $options['buttons_below']) { if ($options['chkdelete']) { $admin_templates->set_var('header_text', ''); $admin_templates->set_var('show_deleteimage', ''); } if ($options['buttons_below']) { $admin_templates->set_var('buttons_below', $options['buttons_below']); } $admin_templates->set_var('class', "admin-list-headerfield"); $admin_templates->parse('header_row', 'header', true); $admin_templates->clear_var('on_click'); } else { $admin_templates->set_var('show_deleteimage','display:none;'); } ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel __________ NOD32 2473 (20070821) Information __________ This message was checked by NOD32 antivirus system. http://www.eset.com From oliver at spiesshofer.com Tue Aug 21 21:21:32 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Wed, 22 Aug 2007 09:21:32 +0800 Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) In-Reply-To: <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> <46C8F6A7.3080100@spiesshofer.com> <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> Message-ID: <46CB8F9C.8010902@spiesshofer.com> And I thought the whole Adminlist was complicated enough already :-) Can you tell me what you want to do? I do not want to blow this up into a monster where no one can handle the code afterwards anymore. I would prefer to allow the codewriter to add things through templates or so instead of making the main function even more complex. You want to have several checkboxes and then also for the next row another button on the end of the row? Oliver Joe Mucchiello wrote: > Can you make it possible to name checkboxes used in the delete option? > > if (is_array($options) AND $options['chkdelete']) { > $delitemtext = isset($options['chkitem']) ? > $options['chkitem'] : 'delitem'; // new line > $admin_templates->set_var('class', "admin-list-field"); > $admin_templates->set_var('itemtext', ' type="checkbox" name="'.$delitemtext.'[]" value="' . > $A[$options['chkfield']].'">'); > $admin_templates->parse('item_field', 'field', true); > } > > if (is_array($options) AND $options['chkdelete']) { > $delitemtext = isset($options['chkitem']) ? > $options['chkitem'] : 'delitem'; // new line > $admin_templates->set_var('header_text', ' type="checkbox" name="chk_selectall" title="'.$LANG01[126].'" > onclick="caItemsExt(this.form,'."'$delitemtext'".');">'); > > Probably would need to make a second caItems javascript function so > you don't have to modify all the calls to caItems throughout the code. > > function caItemsExt(f, delitem) { > var n=f.elements.length; > for (i=0;i var field=f.elements[i]; > if (field.type == 'checkbox' && field.name.match(delitem)) { > if (f.chk_selectall.checked) { > field.checked=true; > } else { > field.checked=false; > } > } > } > } > > Another ADMIN_list request: How about making a way to add more buttons > to the row where the trash can appears? I believe it is in > admin/lists/list.thtml. Perhaps add an $options['buttons_below'] and > then put a {buttons_below} into that thtml: > >
> src="{layout_url}/images/deleteitem.png" title="{lang_deleteall}" > onclick="return confirm('{lang_delconfirm}');"> > {buttons_below} >
> > // and then something like would be necessary > if (count($data_arr) > 1 AND is_array($options) AND > ($options['chkdelete'] OR $options['buttons_below']) { > if ($options['chkdelete']) { > $admin_templates->set_var('header_text', ' type="checkbox" name="chk_selectall" title="'.$LANG01[126].'" > onclick="caItems(this.form);">'); > $admin_templates->set_var('show_deleteimage', ''); > } > if ($options['buttons_below']) { > $admin_templates->set_var('buttons_below', > $options['buttons_below']); > } > $admin_templates->set_var('class', "admin-list-headerfield"); > $admin_templates->parse('header_row', 'header', true); > $admin_templates->clear_var('on_click'); > } else { > $admin_templates->set_var('show_deleteimage','display:none;'); > } > > > ---- > Joe Mucchiello > Throwing Dice Games > http://www.throwingdice.com > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > From joe at ThrowingDice.com Tue Aug 21 22:54:20 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Tue, 21 Aug 2007 22:54:20 -0400 Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) In-Reply-To: <46CB8F9C.8010902@spiesshofer.com> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> <46C8F6A7.3080100@spiesshofer.com> <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> <46CB8F9C.8010902@spiesshofer.com> Message-ID: <0JN50028FMR60U41@mta1.srv.hcvlny.cv.net> No, I just want to be able to NAME the checkboxes. Currently they are delitem and I need to put two admin lists on the same page and based on the setup, it isn't easy to generate unique form urls for the two lists. Multiple checkboxes would be a bit insane. (Although being able to specify where the check boxes appear would be nice too. :-) ) Adding things through templates only works if I can pass in the name of the template to admin_list(). I don't want ALL admin lists to have extra buttons. The extra buttons would go on the same line as the trash can. All the code changes are basically in my email. You just need to search for the lines to make the modifications. If you like, I'll send you a full function with my changes and you can compare it that way. (I'll have to go look at CVS's lib-admin to make sure I'm not losing any important fixes though.) Basically it would be nice to have something like: [] data data data [] data data data [drop list [v] [GO] So you could perform actions on several items besides deleting them. For example, [] data data data [] data data data Move to folder [drop list of folders [v] [GO] As much as you don't want to overcomplicate that beast of a function, I don't want to clone it and maintain a fork. :-) Joe At 09:21 PM 8/21/2007, Oliver Spiesshofer wrote: >And I thought the whole Adminlist was complicated enough already :-) > >Can you tell me what you want to do? I do not want to blow this up >into a monster where no one can handle the code afterwards anymore. >I would prefer to allow the codewriter to add things through >templates or so instead of making the main function even more complex. >You want to have several checkboxes and then also for the next row >another button on the end of the row? > >Oliver ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From oliver at spiesshofer.com Tue Aug 21 23:03:32 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Wed, 22 Aug 2007 11:03:32 +0800 Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) In-Reply-To: <0JN50028FMR60U41@mta1.srv.hcvlny.cv.net> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> <46C8F6A7.3080100@spiesshofer.com> <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> <46CB8F9C.8010902@spiesshofer.com> <0JN50028FMR60U41@mta1.srv.hcvlny.cv.net> Message-ID: <46CBA784.9030607@spiesshofer.com> Ok, I get what you mean now. However, if you have two different functions since you have two different lists, the fact that the form fields are called the same should not be an issue no? I am not sure how the "Check all" behaves though... Finally the url of each form can be different, and include get-variables to differentiate two forms pointing to the same target file (such as .../index.php?form=1)? The additional fields on the bottom can be done with an additional code in the array similar as you indicated. I do not think that would be too complicated Oliver Joe Mucchiello wrote: > No, I just want to be able to NAME the checkboxes. Currently they are > delitem and I need to put two admin lists on the same page and based > on the setup, it isn't easy to generate unique form urls for the two > lists. Multiple checkboxes would be a bit insane. (Although being able > to specify where the check boxes appear would be nice too. :-) ) > > Adding things through templates only works if I can pass in the name > of the template to admin_list(). I don't want ALL admin lists to have > extra buttons. > > The extra buttons would go on the same line as the trash can. > > All the code changes are basically in my email. You just need to > search for the lines to make the modifications. If you like, I'll send > you a full function with my changes and you can compare it that way. > (I'll have to go look at CVS's lib-admin to make sure I'm not losing > any important fixes though.) > > Basically it would be nice to have something like: > [] data data data > [] data data data > [drop list [v] [GO] > > So you could perform actions on several items besides deleting them. > For example, > [] data data data > [] data data data > Move to folder [drop list of folders [v] [GO] > > As much as you don't want to overcomplicate that beast of a function, > I don't want to clone it and maintain a fork. :-) > > Joe > > At 09:21 PM 8/21/2007, Oliver Spiesshofer wrote: >> And I thought the whole Adminlist was complicated enough already :-) >> >> Can you tell me what you want to do? I do not want to blow this up >> into a monster where no one can handle the code afterwards anymore. >> I would prefer to allow the codewriter to add things through >> templates or so instead of making the main function even more complex. >> You want to have several checkboxes and then also for the next row >> another button on the end of the row? >> >> Oliver > > ---- > Joe Mucchiello > Throwing Dice Games > http://www.throwingdice.com > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > From joe at ThrowingDice.com Tue Aug 21 23:30:07 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Tue, 21 Aug 2007 23:30:07 -0400 Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) In-Reply-To: <46CBA784.9030607@spiesshofer.com> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> <46C8F6A7.3080100@spiesshofer.com> <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> <46CB8F9C.8010902@spiesshofer.com> <0JN50028FMR60U41@mta1.srv.hcvlny.cv.net> <46CBA784.9030607@spiesshofer.com> Message-ID: <0JN5008WROEYYCL0@mta1.srv.hcvlny.cv.net> I can't really make the forms have different action urls. They pull their action url out of the $_GET array (so that they don't mess up the other display) and thus end up identical. It's too complicated to explain here. But I've figured out a different change that would be easier on you and not as messy in the Add a hidden input with the $component variable in it to the form. // added to (probably) the list.thtml just before the table opens. $admin_template->set_var('component', $component); // added somewhere in the big function That would be an easy fix for my dilemma and I wouldn't need the delitem change. ---------- Passing templates into admin_list would be cool: $admin_templates = new Template($_CONF['path_layout'] . 'admin/lists'); $template_files = array ( 'topmenu' => 'topmenu.thtml', 'list' => 'list.thtml', 'header' => 'header.thtml', 'row' => 'listitem.thtml', 'field' => 'field.thtml', 'menufields' => 'menufields.thtml' ); if (isset($options['templates'])) { foreach ($options['templates'] as $k => $v) { $template_files[$k] = $v; } } $admin_templates->set_file($template_files); if you pass in Array('list'=> 'mylist.thtml', 'special'=>'special.thtml') the 'list' element overwrites the default template array and the 'special' element is just added on. You'd need to use PLG_templatesetvars to use the extra template, still, it could be interesting. At 11:03 PM 8/21/2007, Oliver Spiesshofer wrote: >Ok, I get what you mean now. > >However, if you have two different functions since you have two >different lists, the fact that the form fields are called the same >should not be an issue no? I am not sure how the "Check all" behaves though... >Finally the url of each form can be different, and include >get-variables to differentiate two forms pointing to the same target >file (such as .../index.php?form=1)? > >The additional fields on the bottom can be done with an additional >code in the array similar as you indicated. I do not think that >would be too complicated > >Oliver > >Joe Mucchiello wrote: >>No, I just want to be able to NAME the checkboxes. Currently they >>are delitem and I need to put two admin lists on the same page and >>based on the setup, it isn't easy to generate unique form urls for >>the two lists. Multiple checkboxes would be a bit insane. (Although >>being able to specify where the check boxes appear would be nice too. :-) ) >> >>Adding things through templates only works if I can pass in the >>name of the template to admin_list(). I don't want ALL admin lists >>to have extra buttons. >> >>The extra buttons would go on the same line as the trash can. >> >>All the code changes are basically in my email. You just need to >>search for the lines to make the modifications. If you like, I'll >>send you a full function with my changes and you can compare it >>that way. (I'll have to go look at CVS's lib-admin to make sure I'm >>not losing any important fixes though.) >> >>Basically it would be nice to have something like: >>[] data data data >>[] data data data >>[drop list [v] [GO] >> >>So you could perform actions on several items besides deleting >>them. For example, >>[] data data data >>[] data data data >>Move to folder [drop list of folders [v] [GO] >> >>As much as you don't want to overcomplicate that beast of a >>function, I don't want to clone it and maintain a fork. :-) >> >> Joe >> >>At 09:21 PM 8/21/2007, Oliver Spiesshofer wrote: >>>And I thought the whole Adminlist was complicated enough already :-) >>> >>>Can you tell me what you want to do? I do not want to blow this up >>>into a monster where no one can handle the code afterwards anymore. >>>I would prefer to allow the codewriter to add things through >>>templates or so instead of making the main function even more complex. >>>You want to have several checkboxes and then also for the next row >>>another button on the end of the row? >>> >>>Oliver >> >>---- >>Joe Mucchiello >>Throwing Dice Games >>http://www.throwingdice.com >>_______________________________________________ >>geeklog-devel mailing list >>geeklog-devel at lists.geeklog.net >>http://eight.pairlist.net/mailman/listinfo/geeklog-devel > >_______________________________________________ >geeklog-devel mailing list >geeklog-devel at lists.geeklog.net >http://eight.pairlist.net/mailman/listinfo/geeklog-devel ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From joe at ThrowingDice.com Wed Aug 22 12:48:55 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Wed, 22 Aug 2007 12:48:55 -0400 Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) In-Reply-To: <46CBA784.9030607@spiesshofer.com> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> <46C8F6A7.3080100@spiesshofer.com> <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> <46CB8F9C.8010902@spiesshofer.com> <0JN50028FMR60U41@mta1.srv.hcvlny.cv.net> <46CBA784.9030607@spiesshofer.com> Message-ID: <0JN6004OFPEAN5V0@mta2.srv.hcvlny.cv.net> At 11:03 PM 8/21/2007, Oliver Spiesshofer wrote: >The additional fields on the bottom can be done with an additional >code in the array similar as you indicated. I do not think that >would be too complicated I just looked at CVS for this and the bottom line this is 90% of the way there. The Form_arr['top'] and ['bottom'] are new. Looking at the thtml files I just need a way to sneak some CSS into the form:
{formfields_bottom}
And some way to get following added to the function with some kind of if: if ($options['bottomfields'] == 'sameline') or use the $form_arr whatever you like as long as you get the option to add "display:inline" do the form. $admin_templates->set_var('bottomfields_onsameline', "display:inline"); ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From joe at ThrowingDice.com Wed Aug 22 19:54:10 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Wed, 22 Aug 2007 19:54:10 -0400 Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) In-Reply-To: <0JN6004OFPEAN5V0@mta2.srv.hcvlny.cv.net> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> <46C8F6A7.3080100@spiesshofer.com> <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> <46CB8F9C.8010902@spiesshofer.com> <0JN50028FMR60U41@mta1.srv.hcvlny.cv.net> <46CBA784.9030607@spiesshofer.com> <0JN6004OFPEAN5V0@mta2.srv.hcvlny.cv.net> Message-ID: <0JN7006K6KJTM490@mta5.srv.hcvlny.cv.net> More annoyances: If you set have_menu to false and have_extras to true, the instructions do not display. If you set have_menu to true and have_extras to false, the instructions appear twice. Probably the best fix is to remove the instruction dump at the end of the function: $retval .= COM_startBlock ($title, $help_url, COM_getBlockTemplate ('_admin_block', 'header')); if (!$has_extras) { $retval .= $text_arr['instructions']; // eliminate this } $retval .= $admin_templates->finish($admin_templates->get_var('output')) . COM_endBlock (COM_getBlockTemplate ('_admin_block', 'footer')); And move the set_var call out of the if ($has_menu) if ($text_arr['has_menu']) { # add text strings to template $admin_templates->set_var('lang_instructions', $text_arr['instructions']); becomes $admin_templates->set_var('lang_instructions', $text_arr['instructions']); if ($text_arr['has_menu']) { # add text strings to template ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From oliver at spiesshofer.com Thu Aug 23 00:52:42 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Thu, 23 Aug 2007 12:52:42 +0800 Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) In-Reply-To: <0JN5008WROEYYCL0@mta1.srv.hcvlny.cv.net> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> <46C8F6A7.3080100@spiesshofer.com> <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> <46CB8F9C.8010902@spiesshofer.com> <0JN50028FMR60U41@mta1.srv.hcvlny.cv.net> <46CBA784.9030607@spiesshofer.com> <0JN5008WROEYYCL0@mta1.srv.hcvlny.cv.net> Message-ID: <46CD129A.1030107@spiesshofer.com> Joe, IMHO, an additional hidden input does _exatly_ the same as an attached get-variable in the Url. The url is inserted in the admin-list function call. You can edit that there easily. The only difference is that you retrieve the value with get instead of post. I will think about adding additional input places in the template where you can add additional text/html/buttons/whatever, but there has to be a limit to where that is possible, so I will probably come up only with one or two locations, I guess that will be enough anyhow. I am _seriously_ worrying however that every further complication to the function is serving a maximum of 2-3 people that dig the code completely in all detail. I would very much make an effort first to document both functions in detail in the geeklog wiki. Before we can make sure that the current functions are understood and usable then we should not make the whole thing more complicated. Therefore I would like to invite you to help me to write a better and very detailed documentation in the wiki. I am ready to fix problems like the one mentioned before but not to add more things before the documentation is done. sorry if this comes twice, I had problems with my smtp. Oliver Joe Mucchiello wrote: > I can't really make the forms have different action urls. They pull > their action url out of the $_GET array (so that they don't mess up > the other display) and thus end up identical. It's too complicated to > explain here. But I've figured out a different change that would be > easier on you and not as messy in the > > > Add a hidden input with the $component variable in it to the form. > > // added > to (probably) the list.thtml just before the table opens. > > $admin_template->set_var('component', $component); // added somewhere > in the big function > > That would be an easy fix for my dilemma and I wouldn't need the > delitem change. > ---------- > Passing templates into admin_list would be cool: > > $admin_templates = new Template($_CONF['path_layout'] . > 'admin/lists'); > $template_files = array ( > 'topmenu' => 'topmenu.thtml', > 'list' => 'list.thtml', > 'header' => 'header.thtml', > 'row' => 'listitem.thtml', > 'field' => 'field.thtml', > 'menufields' => 'menufields.thtml' > ); > > if (isset($options['templates'])) { > foreach ($options['templates'] as $k => $v) { > $template_files[$k] = $v; > } > } > > $admin_templates->set_file($template_files); > > if you pass in Array('list'=> 'mylist.thtml', > 'special'=>'special.thtml') the 'list' element overwrites the default > template array and the 'special' element is just added on. You'd need > to use PLG_templatesetvars to use the extra template, still, it could > be interesting. > > At 11:03 PM 8/21/2007, Oliver Spiesshofer wrote: >> Ok, I get what you mean now. >> >> However, if you have two different functions since you have two >> different lists, the fact that the form fields are called the same >> should not be an issue no? I am not sure how the "Check all" behaves >> though... >> Finally the url of each form can be different, and include >> get-variables to differentiate two forms pointing to the same target >> file (such as .../index.php?form=1)? >> >> The additional fields on the bottom can be done with an additional >> code in the array similar as you indicated. I do not think that would >> be too complicated >> >> Oliver >> >> Joe Mucchiello wrote: >>> No, I just want to be able to NAME the checkboxes. Currently they >>> are delitem and I need to put two admin lists on the same page and >>> based on the setup, it isn't easy to generate unique form urls for >>> the two lists. Multiple checkboxes would be a bit insane. (Although >>> being able to specify where the check boxes appear would be nice >>> too. :-) ) >>> >>> Adding things through templates only works if I can pass in the name >>> of the template to admin_list(). I don't want ALL admin lists to >>> have extra buttons. >>> >>> The extra buttons would go on the same line as the trash can. >>> >>> All the code changes are basically in my email. You just need to >>> search for the lines to make the modifications. If you like, I'll >>> send you a full function with my changes and you can compare it that >>> way. (I'll have to go look at CVS's lib-admin to make sure I'm not >>> losing any important fixes though.) >>> >>> Basically it would be nice to have something like: >>> [] data data data >>> [] data data data >>> [drop list [v] [GO] >>> >>> So you could perform actions on several items besides deleting them. >>> For example, >>> [] data data data >>> [] data data data >>> Move to folder [drop list of folders [v] [GO] >>> >>> As much as you don't want to overcomplicate that beast of a >>> function, I don't want to clone it and maintain a fork. :-) >>> >>> Joe >>> >>> At 09:21 PM 8/21/2007, Oliver Spiesshofer wrote: >>>> And I thought the whole Adminlist was complicated enough already :-) >>>> >>>> Can you tell me what you want to do? I do not want to blow this up >>>> into a monster where no one can handle the code afterwards anymore. >>>> I would prefer to allow the codewriter to add things through >>>> templates or so instead of making the main function even more complex. >>>> You want to have several checkboxes and then also for the next row >>>> another button on the end of the row? >>>> >>>> Oliver >>> >>> ---- >>> Joe Mucchiello >>> Throwing Dice Games >>> http://www.throwingdice.com >>> _______________________________________________ >>> geeklog-devel mailing list >>> geeklog-devel at lists.geeklog.net >>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel >> >> _______________________________________________ >> geeklog-devel mailing list >> geeklog-devel at lists.geeklog.net >> http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > ---- > Joe Mucchiello > Throwing Dice Games > http://www.throwingdice.com > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > From oliver at spiesshofer.com Thu Aug 23 01:23:02 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Thu, 23 Aug 2007 13:23:02 +0800 Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) In-Reply-To: <46CD129A.1030107@spiesshofer.com> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> <46C8F6A7.3080100@spiesshofer.com> <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> <46CB8F9C.8010902@spiesshofer.com> <0JN50028FMR60U41@mta1.srv.hcvlny.cv.net> <46CBA784.9030607@spiesshofer.com> <0JN5008WROEYYCL0@mta1.srv.hcvlny.cv.net> <46CD129A.1030107@spiesshofer.com> Message-ID: <46CD19B6.1070005@spiesshofer.com> Here is the Wiki-page for the Admin-lists btw with its current rudimentary docs. http://wiki.geeklog.net/wiki/index.php/AdminLists Oliver Oliver Spiesshofer wrote: > I am _seriously_ worrying however that every further complication to the > function is serving a maximum of 2-3 people that dig the code completely > in all detail. > I would very much make an effort first to document both functions in > detail in the geeklog wiki. Before we can make sure that the current > functions are understood and usable then we should not make the whole > thing more complicated. Therefore I would like to invite you to help me > to write a better and very detailed documentation in the wiki. I am > ready to fix problems like the one mentioned before but not to add more > things before the documentation is done. > > > From oliver at spiesshofer.com Thu Aug 23 01:49:12 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Thu, 23 Aug 2007 13:49:12 +0800 Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) In-Reply-To: <0JN6004OFPEAN5V0@mta2.srv.hcvlny.cv.net> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> <46C8F6A7.3080100@spiesshofer.com> <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> <46CB8F9C.8010902@spiesshofer.com> <0JN50028FMR60U41@mta1.srv.hcvlny.cv.net> <46CBA784.9030607@spiesshofer.com> <0JN6004OFPEAN5V0@mta2.srv.hcvlny.cv.net> Message-ID: <46CD1FD8.2020708@spiesshofer.com> I will take out the "
" around the formfields in order to allow the admin to insert anything else at his discretion, and move the formfields into the div above where the buttons are in. Check CVS for this please. Oliver Joe Mucchiello wrote: >
> {formfields_bottom} >
> > And some way to get following added to the function with some kind of > if: if ($options['bottomfields'] == 'sameline') or use the $form_arr > whatever you like as long as you get the option to add > "display:inline" do the form. > $admin_templates->set_var('bottomfields_onsameline', > "display:inline"); From joe at ThrowingDice.com Thu Aug 23 18:00:26 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Thu, 23 Aug 2007 18:00:26 -0400 Subject: [geeklog-devel] Feature Request: ADMIN_list (2 requests) In-Reply-To: <46CD129A.1030107@spiesshofer.com> References: <9008B5A5-852E-4AE4-886A-DBCC8405FE33@heatherengineering.com> <46BFC6E3.7010307@spiesshofer.com> <20070813055513.1136795207@smtp.haun-online.de> <13B3D38D-EF0E-4F89-8094-B6A2B4DB47D4@heatherengineering.com> <46C8F6A7.3080100@spiesshofer.com> <0JN5009ML1L8PMU0@mta3.srv.hcvlny.cv.net> <46CB8F9C.8010902@spiesshofer.com> <0JN50028FMR60U41@mta1.srv.hcvlny.cv.net> <46CBA784.9030607@spiesshofer.com> <0JN5008WROEYYCL0@mta1.srv.hcvlny.cv.net> <46CD129A.1030107@spiesshofer.com> Message-ID: <0JN800FWEYHIQ741@mta1.srv.hcvlny.cv.net> At 12:52 AM 8/23/2007, Oliver Spiesshofer wrote: >I am _seriously_ worrying however that every further complication to the >function is serving a maximum of 2-3 people that dig the code completely >in all detail. I understand that concern. You don't want to end up with a 3rd function called ADMIN_complexList(). :-) >I would very much make an effort first to document both functions in >detail in the geeklog wiki. Before we can make sure that the current >functions are understood and usable then we should not make the whole >thing more complicated. Therefore I would like to invite you to help me >to write a better and very detailed documentation in the wiki. I am >ready to fix problems like the one mentioned before but not to add more >things before the documentation is done. Sure. I just need a wiki account. I'll see what I can do since I want to get better at writing the setup routine without cribbing off another one. I also have some minor optimizations for the function. But they aren't important. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From dirk at haun-online.de Mon Aug 27 10:03:56 2007 From: dirk at haun-online.de (Dirk Haun) Date: Mon, 27 Aug 2007 16:03:56 +0200 Subject: [geeklog-devel] FrOSCon 2007 Message-ID: <20070827140356.1008304020@smtp.haun-online.de> So I'm sitting here, sipping my coffee from a "FrOSCon 2007" mug and wondering how to phrase it ... In a nutshell, the idea of having a Geeklog Day didn't work out. It seems we're not well-known enough yet over here to draw interest in a series of Geeklog-related talks. So what we did instead was to pretty much abandon the program and concentrate on one-to-one talks and presentations with those that dropped by. The organization had an entire wing of the building dedicated to the various projects (including PHP, KDE, Typo 3, Zope, and a few others). The room[1] was nice and big, with a projector and 5 or 6 rows of tables and chairs - and completely oversized for us. Part of the problem was that the project rooms were separated from the main conference area and somewhat hard to find, so we didn't get a lot of people just wandering around in this part of the conference. But even though Markus and Georg did their best with plastering the way to our room with posters and handing out our new flyers, I got the impression that we would have been better off with a booth (primitive as those were [2] - effectively just a table and a chair) in the main area, where a lot more people were just walking by. So I think that's what we will be doing next year. Well, it was worth a try. And we did get some good feedback from the few people that did drop by. To be clear: Even though I think that something could have been done to make the project rooms easier to find, I'm not critizing the organization here. FrOSCon was actually really, really well organized, with things like free catering for speakers and helpers and a general "need something? just ask" mentality. We did use FrOSCon to launch our new "marketing campaign" based on the designs and ideas that Markus posted here on the list a few weeks ago. We're using the picture of an airplane and the phrases "reliability built-in" and "Durchstarten mit Geeklog" (couldn't find a good translation - something like "take off with Geeklog", again an airplane metaphor) to draw attention and direct people to http://geeklog.de/durchstarten where we list some arguments for Geeklog. This is still work in progress but it's a good start. A big thanks to Markus who did all of the hard work of collecting those items and also did the artwork and the flyer (btw, we bought the rights to use that airplane image). Okay, back to FrOSCon: Day 2 started quiet for me, as I finally had the chance to go and see some of the presentations. I visited two about copyrights, software licenses, software patents, and all that and also attended one about WebTest (which reminded me that we really should be looking into using something like this). And then I had to give two presentations of my own. My Webspam talk was well received and resulted in a lively discussion. No real new ideas emerged, but it did seem to raise awareness of the problem somewhat, which was one of my main goals. For example, an editor for O'Reilly Germany came to me afterwards and mentioned that he was now thinking about adding a chapter about webspam to the next edition of one of their books about email spam. My second talk was scheduled for 5:45pm, the last slot on the last day of the conference ... But I was pleasantly surprised with the amount of people who did show up (I stopped counting at 20 - I think there were more than 30 in the end). The topic was why you should not rewrite an applicatin from scratch. The audience seemed to agree with the basic premise but also brought up some examples where my proposed solution of using refactoring instead didn't quite work out. Something to work on for the next iteration of that talk :-) Despite the slight disappointment on the first day, I enjoyed being at FrOSCon. It's really a good conference with a great atmosphere and a superb organization. I think I know where I will be on August 23 and 24, 2008 - at FrOSCon 2008. bye, Dirk [1] [2] [3] more photos: -- http://www.geeklog.net/ http://geeklog.info/ From casual.dodo at gmail.com Mon Aug 27 14:07:07 2007 From: casual.dodo at gmail.com (Ramnath R Iyer) Date: Mon, 27 Aug 2007 14:07:07 -0400 Subject: [geeklog-devel] FrOSCon 2007 In-Reply-To: <20070827140356.1008304020@smtp.haun-online.de> References: <20070827140356.1008304020@smtp.haun-online.de> Message-ID: <200708271407.19827.casual.dodo@gmail.com> On the marketing front, it would be good idea to have a pretty Web 2.0 style theme as a default. That's something that attracts users nowadays. Is there something like this already? -- Ramnath R Iyer -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part. URL: From dirk at haun-online.de Mon Aug 27 14:22:36 2007 From: dirk at haun-online.de (Dirk Haun) Date: Mon, 27 Aug 2007 20:22:36 +0200 Subject: [geeklog-devel] Themes (was: FrOSCon 2007) In-Reply-To: <200708271407.19827.casual.dodo@gmail.com> References: <20070827140356.1008304020@smtp.haun-online.de> <200708271407.19827.casual.dodo@gmail.com> Message-ID: <20070827182236.1626529663@smtp.haun-online.de> Ramnath R Iyer wrote: >On the marketing front, it would be good idea to have a pretty Web 2.0 style >theme as a default. Wouldn't that be false advertising? ;-) I always get a good laugh out of people when I point out that Geeklog is decidedly Web 1.0 Personally, I like the Professional theme. IMHO, it's in need of a once- over by someone with an eye for colors, spacing, and such. But other than that, it's a good starting point to create your own theme. Of course, that wouldn't (and shouldn't) stop us from using a more snazzy theme as the default on geeklog.net. I just don't see a worthy contender yet. bye, Dirk -- http://www.haun-online.de/ http://spam.tinyweb.net/ From 1000ideen at gmx.de Mon Aug 27 15:09:44 2007 From: 1000ideen at gmx.de (Markus Wollschlaeger) Date: Mon, 27 Aug 2007 21:09:44 +0200 Subject: [geeklog-devel] the show was good Message-ID: <20070827190944.174430@gmx.net> Yep, the show was good but no success for the so called "projects" there. I think the main problem was that no "project`s" program had been listed online but just in a printed program. Most people will have consulted the internet to find out conference details beforehand. You don`t expect there to be more good stuff by more or less independet "projects". So the Geeklog room was almost as empty as the typo3 room. This shows it was not a matter of not being known in general. The building was very nice, the area too. It is close to Bonn which is the former West-German capital. So all in all we had a good time ;-) Ciao, Markus -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal f?r Modem und ISDN: http://www.gmx.net/de/go/smartsurfer From mevans at ecsnet.com Mon Aug 27 17:22:44 2007 From: mevans at ecsnet.com (Mark R. Evans) Date: Mon, 27 Aug 2007 16:22:44 -0500 Subject: [geeklog-devel] Themes (was: FrOSCon 2007) In-Reply-To: <20070827182236.1626529663@smtp.haun-online.de> References: <20070827140356.1008304020@smtp.haun-online.de> <200708271407.19827.casual.dodo@gmail.com> <20070827182236.1626529663@smtp.haun-online.de> Message-ID: <50aae8730708271422q1dc75eeev9e13f8ba3929c3c5@mail.gmail.com> There has been some very good progress in themes for Geeklog over the past month or so. I expect to see much more too. Eric Warren's latest them, Webstruments, is very well done. To see some of the more recent work, check out http://www.gllabs.org/vthemes/index.php If you are serious about giving geeklog.net a new look, why don't you throw out some ideas on what you would like to see. Maybe one of the current theming wizards will champion the cause. >From a marketing standpoint, I would suggest that we at least start with removing links to items that simply no longer work at geeklog.net. For example, 'Report a bug', it simply gives a page not found error. On the CVS page, the links to the geeklog-devtalk and geeklog-cvs also give a 404 error as do the 2 CVS browser links as well. My point being, marketing is more than a snazzy look, it is also a positive presentation of your product or service. When key links like report a bug go nowhere, it doesn't send the positive message. I realize these systems are down and will probably be up again some day, but until then, it is best to replace them with a static page that states what / where to report bugs in the interim. I'm still working on the wiki, although slowly, but I am making some progress. Thanks! Mark On 8/27/07, Dirk Haun wrote: > > Ramnath R Iyer wrote: > > >On the marketing front, it would be good idea to have a pretty Web 2.0style > >theme as a default. > > Wouldn't that be false advertising? ;-) I always get a good laugh out of > people when I point out that Geeklog is decidedly Web 1.0 > > Personally, I like the Professional theme. IMHO, it's in need of a once- > over by someone with an eye for colors, spacing, and such. But other > than that, it's a good starting point to create your own theme. > > Of course, that wouldn't (and shouldn't) stop us from using a more > snazzy theme as the default on geeklog.net. I just don't see a worthy > contender yet. > > bye, Dirk > > > -- > http://www.haun-online.de/ > http://spam.tinyweb.net/ > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From joe at ThrowingDice.com Mon Aug 27 19:20:12 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Mon, 27 Aug 2007 19:20:12 -0400 Subject: [geeklog-devel] Themes (was: FrOSCon 2007) In-Reply-To: <50aae8730708271422q1dc75eeev9e13f8ba3929c3c5@mail.gmail.co m> References: <20070827140356.1008304020@smtp.haun-online.de> <200708271407.19827.casual.dodo@gmail.com> <20070827182236.1626529663@smtp.haun-online.de> <50aae8730708271422q1dc75eeev9e13f8ba3929c3c5@mail.gmail.com> Message-ID: <0JNG005NAGUT0ZU0@mta5.srv.hcvlny.cv.net> At 05:22 PM 8/27/2007, Mark R. Evans wrote: > From a marketing standpoint, I would suggest that we at least start > with removing links to items that simply no longer work at > geeklog.net. For example, 'Report a bug', it > simply gives a page not found error. On the CVS page, the links > to the geeklog-devtalk and geeklog-cvs also give a 404 error as do > the 2 CVS browser links as well. I hope you actually meant fixing those links, not removing them. A bug tracker is essential for a project of Geeklog's size. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From dirk at haun-online.de Tue Aug 28 14:05:38 2007 From: dirk at haun-online.de (Dirk Haun) Date: Tue, 28 Aug 2007 20:05:38 +0200 Subject: [geeklog-devel] Themes (was: FrOSCon 2007) In-Reply-To: <50aae8730708271422q1dc75eeev9e13f8ba3929c3c5@mail.gmail.com> References: <20070827140356.1008304020@smtp.haun-online.de> <200708271407.19827.casual.dodo@gmail.com> <20070827182236.1626529663@smtp.haun-online.de> <50aae8730708271422q1dc75eeev9e13f8ba3929c3c5@mail.gmail.com> Message-ID: <20070828180538.1830234712@smtp.haun-online.de> Mark R. Evans wrote: >From a marketing standpoint, I would suggest that we at least start with >removing links to items that simply no longer work at geeklog.net. For >example, 'Report a bug', it simply gives a page not found error. On the >CVS page, the links to the geeklog-devtalk and geeklog-cvs also give a 404 >error as do the 2 CVS browser links as well. Thanks. I was aware of the broken CVS viewer link but not of the two for the mailing lists. Those must have been dead for a long time, actually (even before the last server move). Fixed the links to the mailing lists and commented out "report a bug" and the CVS viewer link for now. bye, Dirk -- http://www.haun-online.de/ http://spam.tinyweb.net/ From oliver at spiesshofer.com Tue Aug 28 23:12:10 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Wed, 29 Aug 2007 11:12:10 +0800 Subject: [geeklog-devel] Geeklog Config Updates Message-ID: <46D4E40A.9020100@spiesshofer.com> Hi Aaron, I just have seen your updates to the CVS. With the current status of the CVS as you submitted it, the system breaks as you might be aware. I realize that there are several files still missing in your submit. (db-config.php, siteconfig.php, config.class.php) Are you going to submit them soon? Otherwise I have to revert to the previous version to be able to work on the system thanks Oliver From blanks at mit.edu Tue Aug 28 23:25:34 2007 From: blanks at mit.edu (Aaron Blankstein) Date: Tue, 28 Aug 2007 23:25:34 -0400 Subject: [geeklog-devel] Geeklog Config Updates In-Reply-To: <46D4E40A.9020100@spiesshofer.com> References: <46D4E40A.9020100@spiesshofer.com> Message-ID: <2a1a3bb50708282025n48c7d0f6nf2f9f666d52d6337@mail.gmail.com> Sorry about that, they are submitted now. Aaron On 8/28/07, Oliver Spiesshofer wrote: > > Hi Aaron, > > I just have seen your updates to the CVS. With the current status of the > CVS as you submitted it, the system breaks as you might be aware. I > realize that there are several files still missing in your submit. > (db-config.php, siteconfig.php, config.class.php) > Are you going to submit them soon? Otherwise I have to revert to the > previous version to be able to work on the system > > thanks > > Oliver > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From oliver at spiesshofer.com Tue Aug 28 23:32:36 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Wed, 29 Aug 2007 11:32:36 +0800 Subject: [geeklog-devel] Geeklog Config Updates In-Reply-To: <2a1a3bb50708282025n48c7d0f6nf2f9f666d52d6337@mail.gmail.com> References: <46D4E40A.9020100@spiesshofer.com> <2a1a3bb50708282025n48c7d0f6nf2f9f666d52d6337@mail.gmail.com> Message-ID: <46D4E8D4.3020607@spiesshofer.com> thanks! I forget myself sometimes to do the config add in CVS for new files, so I though I notify you :-) Oliver Aaron Blankstein wrote: > Sorry about that, they are submitted now. > > Aaron > > On 8/28/07, *Oliver Spiesshofer* > wrote: > > Hi Aaron, > > I just have seen your updates to the CVS. With the current status > of the > CVS as you submitted it, the system breaks as you might be aware. I > realize that there are several files still missing in your submit. > (db-config.php, siteconfig.php, config.class.php) > Are you going to submit them soon? Otherwise I have to revert to the > previous version to be able to work on the system > > thanks > > Oliver > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > > ------------------------------------------------------------------------ > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > From oliver at spiesshofer.com Tue Aug 28 23:38:45 2007 From: oliver at spiesshofer.com (Oliver Spiesshofer) Date: Wed, 29 Aug 2007 11:38:45 +0800 Subject: [geeklog-devel] Geeklog Config Updates In-Reply-To: <2a1a3bb50708282025n48c7d0f6nf2f9f666d52d6337@mail.gmail.com> References: <46D4E40A.9020100@spiesshofer.com> <2a1a3bb50708282025n48c7d0f6nf2f9f666d52d6337@mail.gmail.com> Message-ID: <46D4EA45.4080706@spiesshofer.com> Aaron, just did a blank install with the new system and it worked fine! The config editor also looks great. The system seems to set itself up as multilanguage though, and then the default story is not visible. But I guess you are still working on it, so tell me when you want some feedback. Oliver Aaron Blankstein wrote: > Sorry about that, they are submitted now. > > Aaron > > On 8/28/07, *Oliver Spiesshofer* > wrote: > > Hi Aaron, > > I just have seen your updates to the CVS. With the current status > of the > CVS as you submitted it, the system breaks as you might be aware. I > realize that there are several files still missing in your submit. > (db-config.php, siteconfig.php, config.class.php) > Are you going to submit them soon? Otherwise I have to revert to the > previous version to be able to work on the system > > thanks > > Oliver > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > > ------------------------------------------------------------------------ > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > From joe at ThrowingDice.com Wed Aug 29 01:29:47 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Wed, 29 Aug 2007 01:29:47 -0400 Subject: [geeklog-devel] [geeklog-cvs] Geeklog-1.x/system/classes config.class.php, NONE, 1.1 In-Reply-To: <20070829032514.7D6A510FE18@qs1489.pair.com> References: <20070829032514.7D6A510FE18@qs1489.pair.com> Message-ID: <0JNI005HFSMVDS90@mta1.srv.hcvlny.cv.net> At 11:25 PM 8/28/2007, Aaron Blankstein wrote: > "name = '{$escaped_name}' AND group_name = '{$this->ref}'"; I don't believe "{$this->variable}" works in PHP 4 you have break out of the string and concatenate or assign to a local variable first. I think Michael ran into that problem when doing the story rewrite. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From joe at ThrowingDice.com Wed Aug 29 09:16:47 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Wed, 29 Aug 2007 09:16:47 -0400 Subject: [geeklog-devel] [geeklog-cvs] Geeklog-1.x/system lib-admin.php, 1.113, 1.114 In-Reply-To: <20070829093455.D392210FE15@qs1489.pair.com> References: <20070829093455.D392210FE15@qs1489.pair.com> Message-ID: <0JNJ00BS0E983751@mta3.srv.hcvlny.cv.net> At 05:34 AM 8/29/2007, Oliver wrote: >display the menu by itself instead of piping it through the >admin-list-functions I understand why you would create the ADMIN_menu function. What I don't understand is why you changed the interface to ADMIN_list/ADMIN_simpleList. Couldn't the list functions just call ADMIN_menu? That would minimize the code changes wouldn't it? This change means no 1.4.1 plugins that use ADMIN_{simple|}list are compatible with 1.4.2. The call to ADMIN_menu could have been done in ADMIN_list: if ($text_arr['has_menu']) { retval .= ADMIN_createMenu($menu_arr, $text_arr['title'], $text_arr['icon']); } Perhaps removing it from ADMIN_simpleList makes sense (as it makes the function simpler). But having to change all those other lists seems like a waste of time. If the interface to the list functions keeps changing, it makes them less useful for a library function. ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From dirk at haun-online.de Wed Aug 29 15:41:42 2007 From: dirk at haun-online.de (Dirk Haun) Date: Wed, 29 Aug 2007 21:41:42 +0200 Subject: [geeklog-devel] Themes (was: FrOSCon 2007) In-Reply-To: <50aae8730708271422q1dc75eeev9e13f8ba3929c3c5@mail.gmail.com> References: <20070827140356.1008304020@smtp.haun-online.de> <200708271407.19827.casual.dodo@gmail.com> <20070827182236.1626529663@smtp.haun-online.de> <50aae8730708271422q1dc75eeev9e13f8ba3929c3c5@mail.gmail.com> Message-ID: <20070829194142.282437333@smtp.haun-online.de> Mark R. Evans wrote: >There has been some very good progress in themes for Geeklog over the past >month or so. Yeah, I noticed them. There are some fresh new designs now. Kudos to Eric Warren (aka geiss) for taking the initiative. >If you are serious about giving geeklog.net a new look, why don't you throw >out some ideas on what you would like to see. Maybe one of the current >theming wizards will champion the cause. Well, here are some thoughts: I think we'll have to stick with a 3-column layout. We just have too many blocks to put on the site. I'd prefer something blue-ish, maybe a bit brighter than in the Professional theme. Something to go along with the airplane picture, for example: As for the looks - maybe something like a cross between the Integral and Refresh themes. I like the roundness in both, the menu bar of Refresh and the block design of Integral. I don't like the green in either, though ;-) Just my personal preferences, of course. bye, Dirk -- http://www.haun-online.de/ http://geeklog.info/ From casual.dodo at gmail.com Wed Aug 29 16:17:28 2007 From: casual.dodo at gmail.com (Ramnath R Iyer) Date: Wed, 29 Aug 2007 16:17:28 -0400 Subject: [geeklog-devel] Themes (was: FrOSCon 2007) In-Reply-To: <50aae8730708271422q1dc75eeev9e13f8ba3929c3c5@mail.gmail.com> References: <20070827140356.1008304020@smtp.haun-online.de> <20070827182236.1626529663@smtp.haun-online.de> <50aae8730708271422q1dc75eeev9e13f8ba3929c3c5@mail.gmail.com> Message-ID: <200708291617.32831.casual.dodo@gmail.com> I sent this mail a few days ago, and just realized I had done so using the wrong email address, so it never turned up on the list. :( On Monday 27 August 2007 17:22:44 Mark R. Evans wrote: > My point being, marketing is more than a snazzy look, it is also a positive > presentation of your product or service. When key links like report a bug > go nowhere, it doesn't send the positive message. I realize these systems > are down and will probably be up again some day, but until then, it is best > to replace them with a static page that states what / where to report bug > in the interim. Well, that's true, but a snazzy look is a good start to any marketing attempt. What I'd really like to see is to see two different viewpoints, one from a 'marketing team' that tells us what the "non-geeky" user wants, and another team that tells us what serious users and website administrators want. Then we can strike a balance between the two. The content of the main site could also be restructured to maintain this distinction. Look at the Mozilla website for example (www.mozilla.com). There is no development news at all, except for the 'Developers' link on the top. My point is that a casual user would see Firefox/Thunderbird as an "end-product" rather than some developmental process that he/she needs to get involved in. The Geeklog site in contrast has a lot of text on the main page that the inexperienced user would not understand. We do need some kind of a roadmap that we can stick to. (If I remember correctly, Joe has been quite vocal about this.) What I think is that no matter what kind of user we are ultimately targetting, we should try to ensure that GL is noticed by everyone, even if it is not *used* by all. Yes, it is a kind of marketing campaign, but I think it is worth the effort that would be required. > On 8/27/07, Dirk Haun wrote: > > Ramnath R Iyer wrote: > > >On the marketing front, it would be good idea to have a pretty Web > > > 2.0style theme as a default. > > > > Wouldn't that be false advertising? ;-) I always get a good laugh out of > > people when I point out that Geeklog is decidedly Web 1.0 I don't it is false advertising. It's not that we are trying to portray GL as something it is not; rather we are trying to make people believe that they may be looking at something they want, so that they then take a closer look. It is all about anticipating the requirements of different classes of users and highlighting those features. > > Personally, I like the Professional theme. IMHO, it's in need of a once- > > over by someone with an eye for colors, spacing, and such. But other > > than that, it's a good starting point to create your own theme. Probably true, but I submit that we should also think of the users who don't want to and don't care about creating their own themes. A major chunk of users looking for something like GL would be of this type. Sometime ago, there was a suggestion that GL be packaged as a forum, or something to that effect. There was some merit to that suggestion, because lots of people are on the lookout for forum software. But GL can do much more, right? So why not package GL as different aspects of a CMS - a blog, a forum etc. with its own set of themes and defaults so that anyone who is interested can give it a shot? I guess the bottomline of all this talk is that if our aim is to increase the popularity of GL, we need to cater to different kinds of audiences. Some of these types would be willing to play with the software, but a majority will not. -- Ramnath R Iyer -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part. URL: From dirk at haun-online.de Wed Aug 29 17:05:32 2007 From: dirk at haun-online.de (Dirk Haun) Date: Wed, 29 Aug 2007 23:05:32 +0200 Subject: [geeklog-devel] Themes (was: FrOSCon 2007) In-Reply-To: <200708291617.32831.casual.dodo@gmail.com> References: <20070827140356.1008304020@smtp.haun-online.de> <20070827182236.1626529663@smtp.haun-online.de> <50aae8730708271422q1dc75eeev9e13f8ba3929c3c5@mail.gmail.com> <200708291617.32831.casual.dodo@gmail.com> Message-ID: <20070829210532.1060108358@smtp.haun-online.de> Ramnath R Iyer wrote: >I sent this mail a few days ago, and just realized I had done so using the >wrong email address, so it never turned up on the list. :( Yeah, sorry - emails from non-subscribers are silently discarded. >The content of the main site could also be restructured to maintain this >distinction. Look at the Mozilla website for example (www.mozilla.com). There >is no development news at all, except for the 'Developers' link on the top. Actually, that was discussed briefly at FrOSCon and the result was that we should probably have _more_ developer news and discussions on the site. Currently, you don't see any of the discussions that are happening on this list mirrored on the site which could lead to the impression that there is no real development happening. mozilla.com probably isn't the best example. We _want_ users to return to geeklog.net regularly. And therefore, we have to give them something to make sure they do. Like news and discussions. The content of mozilla.com is something for a landing page, similar to what we're trying with . This could then be linked prominently from the homepage and we would have both. bye, Dirk -- http://www.geeklog.net/ http://geeklog.info/ From casual.dodo at gmail.com Wed Aug 29 17:34:20 2007 From: casual.dodo at gmail.com (Ramnath R Iyer) Date: Wed, 29 Aug 2007 17:34:20 -0400 Subject: [geeklog-devel] Themes (was: FrOSCon 2007) In-Reply-To: <20070829210532.1060108358@smtp.haun-online.de> References: <20070827140356.1008304020@smtp.haun-online.de> <200708291617.32831.casual.dodo@gmail.com> <20070829210532.1060108358@smtp.haun-online.de> Message-ID: <200708291734.23849.casual.dodo@gmail.com> On Wednesday 29 August 2007 17:05:32 Dirk Haun wrote: > Actually, that was discussed briefly at FrOSCon and the result was that > we should probably have _more_ developer news and discussions on the > site. Currently, you don't see any of the discussions that are happening > on this list mirrored on the site which could lead to the impression > that there is no real development happening. > > mozilla.com probably isn't the best example. We _want_ users to return > to geeklog.net regularly. And therefore, we have to give them something > to make sure they do. Like news and discussions. I don't have any objections to putting more (or less) content on the website. What I'm talking about is the separation of this content, so that users who know nothing about PHP etc. can simply view GL as a complete product. For example, you could put up a few download links, some nice pictures, tell them about the great features, and give them an idea of what they can expect in the next release. The *developer* site would focus on all the development news and discussions. You could even put the archives of this list on this site. If these two types of content are put up on the same site, I think it would scare away a lot of potential users who are not interested in development. I think this may be happening *right now*. -- Ramnath R Iyer -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part. URL: From joe at ThrowingDice.com Wed Aug 29 17:53:14 2007 From: joe at ThrowingDice.com (Joe Mucchiello) Date: Wed, 29 Aug 2007 17:53:14 -0400 Subject: [geeklog-devel] Themes (was: FrOSCon 2007) In-Reply-To: <20070829210532.1060108358@smtp.haun-online.de> References: <20070827140356.1008304020@smtp.haun-online.de> <20070827182236.1626529663@smtp.haun-online.de> <50aae8730708271422q1dc75eeev9e13f8ba3929c3c5@mail.gmail.com> <200708291617.32831.casual.dodo@gmail.com> <20070829210532.1060108358@smtp.haun-online.de> Message-ID: <0JNK004R525ZAVM0@mta3.srv.hcvlny.cv.net> At 05:05 PM 8/29/2007, Dirk Haun wrote: >Actually, that was discussed briefly at FrOSCon and the result was that >we should probably have _more_ developer news and discussions on the >site. Currently, you don't see any of the discussions that are happening >on this list mirrored on the site which could lead to the impression >that there is no real development happening. People always ask for a mail gateway to forums/stories. Now you have a need. :-) ---- Joe Mucchiello Throwing Dice Games http://www.throwingdice.com From dirk at haun-online.de Thu Aug 30 16:18:40 2007 From: dirk at haun-online.de (Dirk Haun) Date: Thu, 30 Aug 2007 13:18:40 -0700 Subject: [geeklog-devel] MacFixIt Article: MacFixIt joins the CNET family Message-ID: <200708302018.l7UKIeFQ003467@www7.versiontracker.com> An HTML attachment was scrubbed... URL: From dirk at haun-online.de Thu Aug 30 16:55:41 2007 From: dirk at haun-online.de (Dirk Haun) Date: Thu, 30 Aug 2007 22:55:41 +0200 Subject: [geeklog-devel] MacFixIt Article: MacFixIt joins the CNET family In-Reply-To: <200708302018.l7UKIeFQ003467@www7.versiontracker.com> References: <200708302018.l7UKIeFQ003467@www7.versiontracker.com> Message-ID: <20070830205541.1694055800@smtp.haun-online.de> Hmm, that didn't come out as expected. They must have modified the "Send to a friend" option to sent HTML (yuck). I was only wondering if they would be running Geeklog for much longer after that acquisition: --- snip --- MacFixIt joins the CNET family Wednesday, August 29 2007 @ 04:00 PM PDT Today is a big day for us at MacFixIt, as we join the CNET family of technology sites. Like us, CNET has a long and proud tradition of providing technology information--news, reviews, tips and tricks and more--to a large and diverse community of readers. As MacFixIt's Senior Editor, I'm very pleased that we will become part of this group. The current MacFixIt staff will remain intact in Portland, Oregon, and we will continue every day to publish the most-focused and most- comprehensive Mac troubleshooting information on the Web. For you, our loyal readers, the only changes you will see will be positive ones, as we work to improve site tools and features to make it easier for you to stay informed with changes in the Mac market. Ted Landau, MacFixIt's founder, and a contributing editor to the site, sent me his thoughts earlier this week about the deal: "CNET's acquisition of MacFixIt is exciting news. I am confident that MacFixIt will continue to be the ! top Web destination for Mac troubleshooting. With the resources of CNET behind it, I also expect that MacFixIt will evolve into an even greater site, and I will remain, via my columns and tutorial articles, a part of MacFixIt." Ben Wilson Senior Editor, MacFixIt --- snip --- -- http://www.haun-online.de/ http://geeklog.info/