[geeklog-hg] geeklog: Non-existent user profile (or if user doen't have acces...

geeklog-cvs at lists.geeklog.net geeklog-cvs at lists.geeklog.net
Mon Aug 19 19:21:27 EDT 2013


changeset 9259:bd74a5d0ecb6
url:  http://project.geeklog.net/cgi-bin/hgwebdir.cgi/geeklog/rev/bd74a5d0ecb6
user: Tom <websitemaster at cogeco.net>
date: Mon Aug 19 19:16:33 2013 -0400
description:
Non-existent user profile (or if user doen't have access to it) will return a proper 404 now instead of a soft 404 (Google doesn't like redirects)

diffstat:

 public_html/users.php |  2 +-
 system/lib-user.php   |  4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diffs (33 lines):

diff -r f415088f2e3d -r bd74a5d0ecb6 public_html/users.php
--- a/public_html/users.php	Mon Aug 19 22:45:12 2013 +0900
+++ b/public_html/users.php	Mon Aug 19 19:16:33 2013 -0400
@@ -633,7 +633,7 @@
         }
         $display .= USER_showProfile($uid, false, $msg, $plugin);
     } else {
-        $display .= COM_refresh ($_CONF['site_url'] . '/index.php');
+        COM_handle404();
     }
     break;
 
diff -r f415088f2e3d -r bd74a5d0ecb6 system/lib-user.php
--- a/system/lib-user.php	Mon Aug 19 22:45:12 2013 +0900
+++ b/system/lib-user.php	Mon Aug 19 19:16:33 2013 -0400
@@ -860,7 +860,7 @@
     $result = DB_query("SELECT {$_TABLES['users']}.uid,username,fullname,regdate,homepage,about,location,pgpkey,photo,email,status FROM {$_TABLES['userinfo']},{$_TABLES['users']} WHERE {$_TABLES['userinfo']}.uid = {$_TABLES['users']}.uid AND {$_TABLES['users']}.uid = $uid");
     $nrows = DB_numRows($result);
     if ($nrows == 0) { // no such user
-        return COM_refresh($_CONF['site_url'] . '/index.php');
+        COM_handle404();
     }
     $A = DB_fetchArray($result);
 
@@ -869,7 +869,7 @@
     }
 
     if ($A['status'] != USER_ACCOUNT_ACTIVE && !SEC_hasRights('user.edit')) {
-        return COM_refresh($_CONF['site_url'] . '/index.php');
+        COM_handle404();
     }
     
     $display_name = COM_getDisplayName($uid, $A['username'], $A['fullname']);



More information about the geeklog-cvs mailing list