[geeklog-cvs] geeklog: Bug #0001318: HTML coding errors in the configuration p...

[geeklog-cvs at lists.geeklog.net]

changeset 8236:6dd7c8ff1cc3
url:  http://project.geeklog.net/cgi-bin/hgwebdir.cgi/geeklog/rev/6dd7c8ff1cc3
user: Rouslan Placella <rouslan at placella.com>
date: Wed Apr 20 15:23:40 2011 +0100
description:
Bug #0001318: HTML coding errors in the configuration page. Fix provided by Dengen.

diffstat:

 public_html/layout/professional/admin/config/config_element.thtml |  18 +++++-----
 system/classes/config.class.php                                   |   1 +
 2 files changed, 10 insertions(+), 9 deletions(-)

diffs (87 lines):

diff -r 4eb4bb47b523 -r 6dd7c8ff1cc3 public_html/layout/professional/admin/config/config_element.thtml
--- a/public_html/layout/professional/admin/config/config_element.thtml	Tue Apr 19 13:28:34 2011 -0400
+++ b/public_html/layout/professional/admin/config/config_element.thtml	Wed Apr 20 15:23:40 2011 +0100
@@ -7,7 +7,7 @@
 <!-- END delete-button -->
 
 <!-- BEGIN text-element -->
-<tr id="{name}" class="config_name"><td class="alignright">{display_name} {doc_link} {unset_link}</td>
+<tr id="text_{id_name}" class="config_name"><td class="alignright">{display_name} {doc_link} {unset_link}</td>
 <td>
 <input type="text" class="opt{error_class}" name="{name}" style="width:300px" value="{value}"{xhtml}>
 {delete}{error_block}
@@ -15,7 +15,7 @@
 <!-- END text-element -->
 
 <!-- BEGIN text-area -->
-<tr id="{name}" class="config_name"><td class="alignright">{display_name} {doc_link} {unset_link}</td>
+<tr id="textarea_{id_name}" class="config_name"><td class="alignright">{display_name} {doc_link} {unset_link}</td>
 <td>
 <textarea class="opt{error_class}" name="{name}" style="width:300px" cols="3" rows="3">{value}</textarea>
 {delete}{error_block}
@@ -23,14 +23,14 @@
 <!-- END text-area -->
 
 <!-- BEGIN placeholder-element -->
-<tr id="{name}" class="config_name"><td class="alignright">{display_name}</td><td>
+<tr id="placeholder_{id_name}" class="config_name"><td class="alignright">{display_name}</td><td>
 <input type="hidden" name="{name}" value="{value}"{xhtml}>
 {delete}
 </td></tr>
 <!-- END placeholder-element -->
 
 <!-- BEGIN select-element -->
-<tr{hide_row} id="{name}" class="config_name"><td class="alignright">{display_name} {doc_link} {unset_link}</td>
+<tr{hide_row} id="select_{id_name}" class="config_name"><td class="alignright">{display_name} {doc_link} {unset_link}</td>
 <td>
 <select name="{name}" class="opt{error_class}">
   <!-- BEGIN select-options -->
@@ -42,7 +42,7 @@
 <!-- END select-element -->
 
 <!-- BEGIN unset-param -->
-<tr id="{name}" class="config_name"><td class="alignright">{display_name} {doc_link}</td>
+<tr id="unset_param_{id_name}" class="config_name"><td class="alignright">{display_name} {doc_link}</td>
 <td><a href="#{name}" class="restore_param">{lang_enable}</a></td>
 </tr>
 <!-- END unset-param -->
@@ -50,10 +50,10 @@
 <!-- BEGIN list-element -->
 <tr id="{name}" class="config_name"><td class="alignright" style="vertical-align:top">{display_name} {doc_link} {unset_link}</td>
 <td>
-<input type="button" value="+" onclick="hide_show_tbl(selectChildByID(this.parentNode, 'arr_table'), this);"{xhtml}>
+<input type="button" value="+" onclick="hide_show_tbl(selectChildByID(this.parentNode, 'arr_table_{id_name}'), this);"{xhtml}>
 {delete}
 <input type="hidden" value="true" name="{name}[placeholder]"{xhtml}>
-<table style="display:none" id="arr_table" class="{arr_table_class_list}">
+<table style="display:none" id="arr_table_{id_name}" class="{arr_table_class_list}">
 <col width="100">
 <col width="100%">
 {my_elements}
@@ -63,13 +63,13 @@
 <!-- END list-element -->
 
 <!-- BEGIN keyed-add-button -->
-<tr id="{name}" class="config_name"><td colspan="2">
+<tr id="keyed_button_{id_name}" class="config_name"><td colspan="2">
 <input type="button" value="{lang_add_element}" class="add_ele_input" onclick="handleAdd(this, '{array_type}', '{arr_name}')"{xhtml}><input style="width: 65px"{xhtml}>
 </td></tr>
 <!-- END keyed-add-button -->
 
 <!-- BEGIN unkeyed-add-button -->
-<tr id="{name}" class="config_name"><td colspan="2">
+<tr id="unkeyed_button_{id_name}" class="config_name"><td colspan="2">
 <input type="button" value="{lang_add_element}" class="add_ele_input" onclick="handleAdd(this, '{array_type}', '{arr_name}')"{xhtml}>
 </td></tr>
 <!-- END unkeyed-add-button -->
diff -r 4eb4bb47b523 -r 6dd7c8ff1cc3 system/classes/config.class.php
--- a/system/classes/config.class.php	Tue Apr 19 13:28:34 2011 -0400
+++ b/system/classes/config.class.php	Wed Apr 20 15:23:40 2011 +0100
@@ -1118,6 +1118,7 @@
         $t->set_var('lang_add_element', $LANG_CONFIG['add_element']);
 
         $t->set_var('name', $name);
+        $t->set_var('id_name', str_replace(array('[', ']'), array('_', ''), $name));
         $t->set_var('display_name', $display_name);
         
         // check tmp values