[geeklog-cvs] geeklog: Use implode() instead of join() (for bug #0001105)

geeklog-cvs at lists.geeklog.net geeklog-cvs at lists.geeklog.net
Thu May 13 10:42:16 EDT 2010


changeset 7931:bae3a11e6b58
url:  http://project.geeklog.net/cgi-bin/hgwebdir.cgi/geeklog/rev/bae3a11e6b58
user: Dirk Haun <dirk at haun-online.de>
date: Thu May 13 16:00:42 2010 +0200
description:
Use implode() instead of join() (for bug #0001105)

diffstat:

 public_html/admin/group.php |  4 ++--
 system/lib-security.php     |  6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diffs (51 lines):

diff -r 596b4f50db12 -r bae3a11e6b58 public_html/admin/group.php
--- a/public_html/admin/group.php	Thu May 13 15:51:24 2010 +0200
+++ b/public_html/admin/group.php	Thu May 13 16:00:42 2010 +0200
@@ -2,7 +2,7 @@
 
 /* Reminder: always indent with 4 spaces (no tabs). */
 // +---------------------------------------------------------------------------+
-// | Geeklog 1.6                                                               |
+// | Geeklog 1.7                                                               |
 // +---------------------------------------------------------------------------+
 // | group.php                                                                 |
 // |                                                                           |
@@ -338,7 +338,7 @@
     while (count($tocheck) > 0);
 
     // get features for all groups in $checked
-    $glist = join (',', $checked);
+    $glist = implode(',', $checked);
     $result = DB_query("SELECT DISTINCT ft_name FROM {$_TABLES['access']},{$_TABLES['features']} WHERE ft_id = acc_ft_id AND acc_grp_id IN ($glist)");
     $nrows = DB_numRows ($result);
 
diff -r 596b4f50db12 -r bae3a11e6b58 system/lib-security.php
--- a/system/lib-security.php	Thu May 13 15:51:24 2010 +0200
+++ b/system/lib-security.php	Thu May 13 16:00:42 2010 +0200
@@ -2,7 +2,7 @@
 
 /* Reminder: always indent with 4 spaces (no tabs). */
 // +---------------------------------------------------------------------------+
-// | Geeklog 1.6                                                               |
+// | Geeklog 1.7                                                               |
 // +---------------------------------------------------------------------------+
 // | lib-security.php                                                          |
 // |                                                                           |
@@ -139,7 +139,7 @@
         }
 
         if (count($cgroups) > 0) {
-            $glist = join(',', $cgroups);
+            $glist = implode(',', $cgroups);
             $result = DB_query("SELECT ug_main_grp_id,grp_name FROM {$_TABLES["group_assignments"]},{$_TABLES["groups"]}"
                     . " WHERE grp_id = ug_main_grp_id AND ug_grp_id IN ($glist)",1);
             $nrows = DB_numRows($result);
@@ -517,7 +517,7 @@
         return '';
     }
 
-    $glist = join(',', $groups);
+    $glist = implode(',', $groups);
     $result = DB_query("SELECT DISTINCT ft_name FROM {$_TABLES["access"]},{$_TABLES["features"]} "
                      . "WHERE ft_id = acc_ft_id AND acc_grp_id IN ($glist)");
 



More information about the geeklog-cvs mailing list