[geeklog-cvs] geeklog: Make sure all onclick events in the Configuration retur...

[geeklog-cvs at lists.geeklog.net]

changeset 7578:05d0ecb57c45
url:  http://project.geeklog.net/cgi-bin/hgwebdir.cgi/geeklog/rev/05d0ecb57c45
user: Dirk Haun <dirk at haun-online.de>
date: Sat Jan 02 15:56:38 2010 +0100
description:
Make sure all onclick events in the Configuration return false (bug #0001054)

diffstat:

 public_html/docs/history                                          |  1 +
 public_html/layout/professional/admin/config/config_element.thtml |  2 +-
 public_html/layout/professional/admin/config/menu_element.thtml   |  4 ++--
 system/classes/config.class.php                                   |  6 +++---
 4 files changed, 7 insertions(+), 6 deletions(-)

diffs (68 lines):

diff -r ee6d25ffcfb4 -r 05d0ecb57c45 public_html/docs/history
--- a/public_html/docs/history	Sat Jan 02 15:29:13 2010 +0100
+++ b/public_html/docs/history	Sat Jan 02 15:56:38 2010 +0100
@@ -3,6 +3,7 @@
 ??? ??, 2010 (1.6.2)
 ------------
 
+- Make sure all onclick events in the Configuration return false (bug #0001054)
 - Moved hard-coded sort direction indicator (asc/desc) for search results to
   the language files [Dirk]
 - Changed the 'default_perm_cookie_timeout' config option to a dropdown so that
diff -r ee6d25ffcfb4 -r 05d0ecb57c45 public_html/layout/professional/admin/config/config_element.thtml
--- a/public_html/layout/professional/admin/config/config_element.thtml	Sat Jan 02 15:29:13 2010 +0100
+++ b/public_html/layout/professional/admin/config/config_element.thtml	Sat Jan 02 15:56:38 2010 +0100
@@ -31,7 +31,7 @@
 
 <!-- BEGIN unset-param -->
 <tr><td class="alignright">{display_name} {doc_link}</td>
-<td><a href="#" onclick="restore('{name}');">{lang_enable}</a></td>
+<td><a href="#" onclick="restore('{name}');return false;">{lang_enable}</a></td>
 </tr>
 <!-- END unset-param -->
 
diff -r ee6d25ffcfb4 -r 05d0ecb57c45 public_html/layout/professional/admin/config/menu_element.thtml
--- a/public_html/layout/professional/admin/config/menu_element.thtml	Sat Jan 02 15:29:13 2010 +0100
+++ b/public_html/layout/professional/admin/config/menu_element.thtml	Sat Jan 02 15:56:38 2010 +0100
@@ -1,9 +1,9 @@
 
-<li><a href="#" onclick='open_group("{group_select_value}")'>{group_display}</a>
+<li><a href="#" onclick='open_group("{group_select_value}");return false;'>{group_display}</a>
     <ul>
 <!-- BEGIN subgroup-selector -->
    <li>
-     <a  href="#" {select_id} onclick='open_subgroup("{group_select_value}","{subgroup_name}")'>{subgroup_display_name}</a>
+     <a  href="#" {select_id} onclick='open_subgroup("{group_select_value}","{subgroup_name}");return false;'>{subgroup_display_name}</a>
    </li>
 <!-- END subgroup-selector -->
     </ul>
diff -r ee6d25ffcfb4 -r 05d0ecb57c45 system/classes/config.class.php
--- a/system/classes/config.class.php	Sat Jan 02 15:29:13 2010 +0100
+++ b/system/classes/config.class.php	Sat Jan 02 15:56:38 2010 +0100
@@ -654,7 +654,7 @@
         } else {
             if ($allow_reset) {
                 $t->set_var('unset_link',
-                        "(<a href='#' onClick='unset(\"{$name}\");' title='"
+                        "(<a href='#' onclick='unset(\"{$name}\");return false;' title='"
                         . $LANG_CONFIG['disable'] . "'>X</a>)");
             }
             if (($a = strrchr($name, '[')) !== FALSE) {
@@ -870,7 +870,7 @@
                 if ($conf_group == $group) {
                     $link = "<div>$group_display</div>";
                 } else {
-                    $link = "<div><a href=\"#\" onclick='open_group(\"$group\")'>$group_display</a></div>";
+                    $link = "<div><a href=\"#\" onclick='open_group(\"$group\");return false;'>$group_display</a></div>";
                 }
 
                 if ($group == 'Core') {
@@ -916,7 +916,7 @@
                 if ($i == $sg) {
                     $retval .= "<div>$group_display</div>";
                 } else {
-                    $retval .= "<div><a href=\"#\" onclick='open_subgroup(\"$conf_group\",\"$sgroup\")'>$group_display</a></div>";
+                    $retval .= "<div><a href=\"#\" onclick='open_subgroup(\"$conf_group\",\"$sgroup\");return false;'>$group_display</a></div>";
                 }
                 $i++;
             }