[geeklog-cvs] geeklog: Fixed sort by hits not updating dropdown list correctly

geeklog-cvs at lists.geeklog.net geeklog-cvs at lists.geeklog.net
Sun Apr 25 15:10:32 EDT 2010


changeset 7898:163120dd9e7d
url:  http://project.geeklog.net/cgi-bin/hgwebdir.cgi/geeklog/rev/163120dd9e7d
user: Sami Barakat <sami at sbarakat.co.uk>
date: Sun Apr 25 20:05:00 2010 +0100
description:
Fixed sort by hits not updating dropdown list correctly

diffstat:

 system/classes/listfactory.class.php |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (30 lines):

diff -r ca092e871b04 -r 163120dd9e7d system/classes/listfactory.class.php
--- a/system/classes/listfactory.class.php	Sun Apr 25 20:03:59 2010 +0100
+++ b/system/classes/listfactory.class.php	Sun Apr 25 20:05:00 2010 +0100
@@ -2,7 +2,7 @@
 
 /* Reminder: always indent with 4 spaces (no tabs). */
 // +---------------------------------------------------------------------------+
-// | Geeklog 1.6                                                               |
+// | Geeklog 1.7                                                               |
 // +---------------------------------------------------------------------------+
 // | listfactory.class.php                                                     |
 // |                                                                           |
@@ -12,7 +12,7 @@
 // +---------------------------------------------------------------------------+
 // | Copyright (C) 2000-2010 by the following authors:                         |
 // |                                                                           |
-// | Authors: Sami Barakat     - s.m.barakat AT gmail DOT com                  |
+// | Authors: Sami Barakat     - sami AT sbarakat DOT co DOT uk                |
 // +---------------------------------------------------------------------------+
 // |                                                                           |
 // | This program is free software; you can redistribute it and/or             |
@@ -454,7 +454,7 @@
         if (isset($_GET['order'])) {
             // Loop though the order fields and find a match against $_GET param
             foreach ($this->_fields as $field) {
-                if ($field['sort'] == true && $field['name'] == $_GET['order']) {
+                if ($field['sort'] == true && strcmp($field['name'], $_GET['order']) == 0) {
                     $this->_sort_arr['field'] = $field['name']; // Use a trusted value
                     break;
                 }



More information about the geeklog-cvs mailing list