[geeklog-cvs] geeklog: Admin lists allowed non-sortable columns to be sortable...

[geeklog-cvs at lists.geeklog.net]

details:   http://project.geeklog.net/cgi-bin/hgweb.cgi/rev/2638dcb8940d
changeset: 6584:2638dcb8940d
user:      Dirk Haun <dirk at haun-online.de>
date:      Mon Dec 22 15:11:36 2008 +0100
description:
Admin lists allowed non-sortable columns to be sortable (bug #0000791)

diffstat:

2 files changed, 4 insertions(+), 1 deletion(-)
public_html/docs/history |    2 ++
system/lib-admin.php     |    3 ++-

diffs (31 lines):

diff -r 22c2a7257ee6 -r 2638dcb8940d public_html/docs/history
--- a/public_html/docs/history	Sun Dec 21 18:39:25 2008 +0100
+++ b/public_html/docs/history	Mon Dec 22 15:11:36 2008 +0100
@@ -3,6 +3,8 @@
 ??? ??, 2009 (1.6.0)
 ------------
 
+- Admin lists allowed non-sortable columns to be sortable (reported and patch
+  provided by hiroron, bug #0000791)
 - Implemented extended API for PLG_getItemInfo [mystral-kk, Dirk]
 - Fixed wrong use of COM_isAnonUser in COM_getPermSQL (since 1.5.0) [Dirk]
 - When calling COM_getYearFormOptions with a $startoffset parameter, the list
diff -r 22c2a7257ee6 -r 2638dcb8940d system/lib-admin.php
--- a/system/lib-admin.php	Sun Dec 21 18:39:25 2008 +0100
+++ b/system/lib-admin.php	Mon Dec 22 15:11:36 2008 +0100
@@ -372,13 +372,14 @@
     if (!empty ($order_for_query)) { # concat order string
         $order_sql = "ORDER BY $order_for_query $direction";
     }
-    $th_subtags = ''; // other tags in the th, such as onlick and mouseover
+    $th_subtags = ''; // other tags in the th, such as onclick and mouseover
     $header_text = ''; // title as displayed to the user
     // HEADER FIELDS array(text, field, sort, class)
     // this part defines the contents & format of the header fields
 
     for ($i=0; $i < count( $header_arr ); $i++) { #iterate through all headers
         $header_text = $header_arr[$i]['text'];
+        $th_subtags = '';
         if ($header_arr[$i]['sort'] != false) { # is this sortable?
             if ($order==$header_arr[$i]['field']) { # is this currently sorted?
                 $header_text .= $img_arrow;