[geeklog-cvs] Geeklog-1.x/public_html/admin user.php,1.191,1.192

[Oliver]

Update of /usr/home/geeklog2/cvsroot/geeklog/Geeklog-1.x/public_html/admin
In directory qs1489.pair.com:/tmp/cvs-serv42435

Modified Files:
	user.php 
Log Message:
add todo for future version

Index: user.php
===================================================================
RCS file: /usr/home/geeklog2/cvsroot/geeklog/Geeklog-1.x/public_html/admin/user.php,v
retrieving revision 1.191
retrieving revision 1.192
diff -C2 -d -r1.191 -r1.192
*** user.php	29 Aug 2007 09:33:54 -0000	1.191
--- user.php	9 Oct 2007 07:22:44 -0000	1.192
***************
*** 848,851 ****
--- 848,857 ----
  * This function allows the administrator to import batches of users
  *
+ * TODO: This function should first display the users that are to be imported,
+ * together with the invalid users and the reason of invalidity. Each valid line
+ * should have a checkbox that allows selection of final to be imported users.
+ * After clicking an extra button, the actual import should take place. This will
+ * prevent problems in case the list formatting is incorrect.
+ *
  * @param    string  $file   file to import
  * @return   string          HTML with success or error message
***************
*** 930,940 ****
                                             $fullName);
  
!                 USER_createAndSendPassword ($userName, $emailAddr, $uid);
  
!                 if ($verbose_import) {
                      $retval .= "<br> Account for <b>$u_name</b> created successfully.<br>\n";
                      COM_errorLog("Account for $u_name created successfully",1);
                  }
-                 $successes++;
              } else {
                  if ($verbose_import) {
--- 936,949 ----
                                             $fullName);
  
!                 $result = USER_createAndSendPassword ($userName, $emailAddr, $uid);
  
!                 if ($result && $verbose_import) {
                      $retval .= "<br> Account for <b>$u_name</b> created successfully.<br>\n";
                      COM_errorLog("Account for $u_name created successfully",1);
+                 } else if ($result) {
+                     $successes++;
+                 } else {
+                     // user creation failed
                  }
              } else {
                  if ($verbose_import) {